Attention is currently required from: Paul Menzel, Angel Pons. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62994 )
Change subject: ec/starlabs/merlin: Add EC related files for Cezanne boards ......................................................................
Patch Set 6:
(1 comment)
File src/ec/starlabs/merlin/variants/cezanne/emem.asl:
https://review.coreboot.org/c/coreboot/+/62994/comment/52f238fc_bfebba11 PS4, Line 138: Offset(0xf7), : TBTC, 8, // Thunderbolt Command : TBTP, 8, // Thunderbolt Data Port : TBTD, 8, // Thunderbolt Data : TBTA, 8, // Thunderbolt Acknowledge : TBTG, 16, // Thunderbolt DBG Data
If possible (i.e. if it doesn't cause errors), I wouldn't define these fields. […]
I don't think it will (2 boards still need a lot of work to say for sure) - so I think for now, go halfway and I'll scrap them later if nothing breaks!
-
Sean Rhodes (Code Review)