Change in coreboot[master]: soc/intel: Drop copy-pasted `MSR_VR_MISC_CONFIG2` define

Attention is currently required from: Jeff Daly, Subrata Banik, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Arthur Heymans. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63367 ) Change subject: soc/intel: Drop copy-pasted `MSR_VR_MISC_CONFIG2` define ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/alderlake/include/soc/msr.h: https://review.coreboot.org/c/coreboot/+/63367/comment/3770c07e_ca78b82e PS1, Line 10: MSR_VR_MISC_CONFIG2
Hmmm, I guess this MSR only exists on platforms with FIVR? If so, I'd expect TGL to have this MSR as […] Oh yeah, I don't see it in the TGL EDS... I know that Intel keeps reconfiguring the FIVR support, but TGL was all-in IIRC.
-- To view, visit https://review.coreboot.org/c/coreboot/+/63367 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1b203aa243ab97e3569f7347b424dd72318bd65f Gerrit-Change-Number: 63367 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Jeff Daly <jeffd@silicom-usa.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski@intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli@intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Jeff Daly <jeffd@silicom-usa.com> Gerrit-Attention: Subrata Banik <subratabanik@google.com> Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski@intel.com> Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli@intel.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio@intel.com> Gerrit-Attention: Angel Pons <th3fanbus@gmail.com> Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Comment-Date: Tue, 05 Apr 2022 15:18:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik@google.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
participants (1)
-
Tim Wawrzynczak (Code Review)