Change in coreboot[master]: ec/starlabs/merlin: Add EC related files for Cezanne boards
Attention is currently required from: Sean Rhodes, Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62994 ) Change subject: ec/starlabs/merlin: Add EC related files for Cezanne boards ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/ec/starlabs/merlin/variants/cezanne/emem.asl: https://review.coreboot.org/c/coreboot/+/62994/comment/1f62b2be_2675621d PS4, Line 138: Offset(0xf7), : TBTC, 8, // Thunderbolt Command : TBTP, 8, // Thunderbolt Data Port : TBTD, 8, // Thunderbolt Data : TBTA, 8, // Thunderbolt Acknowledge : TBTG, 16, // Thunderbolt DBG Data
They share the same EC code as the Intel ones - so I guess these are just "Reserved but added for co […] If possible (i.e. if it doesn't cause errors), I wouldn't define these fields. If not, I'd add a comment about it.
-- To view, visit https://review.coreboot.org/c/coreboot/+/62994 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f837263d24e6b642cf33fd2995d8c90529706f6 Gerrit-Change-Number: 62994 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean@starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Sean Rhodes <sean@starlabs.systems> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Comment-Date: Tue, 05 Apr 2022 15:17:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Sean Rhodes <sean@starlabs.systems> Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com> Gerrit-MessageType: comment
participants (1)
-
Angel Pons (Code Review)