Attention is currently required from: Angel Pons, Jean Lucas, Nicholas Chin.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81861?usp=email )
Change subject: nb/intel/gm45: Fill in memory info ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
File src/northbridge/intel/gm45/raminit_meminfo.c:
https://review.coreboot.org/c/coreboot/+/81861/comment/4f6610df_bda41035 : PS1, Line 63: 2 Too bad we don't have a constant for this. I suppose it should be `ARRAY_SIZE(sysinfo->spd_map) / TOTAL_CHANNELS`. As we know this won't change, I guess we can just leave the literal 2.
https://review.coreboot.org/c/coreboot/+/81861/comment/b4755742_d8a091a9 : PS1, Line 83: mem_info->number_of_devices = 2; Is this like the number of slots? Just curious.