Change in coreboot[master]: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

30 Oct 2020 30 Oct '20

4:08 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47029 )

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

soc/intel/broadwell/pch/sata.c: Add missing SATA init steps

WildcatPoint-LP BIOS spec lists them, and are the same for Lynxpoint. Keep the BWG comments for now, since both platforms will be merged soon.

Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/pch/sata.c 1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/47029/1

diff --git a/src/soc/intel/broadwell/pch/sata.c b/src/soc/intel/broadwell/pch/sata.c index 91c2ff5..e9d70f1 100644 --- a/src/soc/intel/broadwell/pch/sata.c +++ b/src/soc/intel/broadwell/pch/sata.c @@ -95,6 +95,15 @@

/* Setup register 98h */ reg32 = pci_read_config32(dev, 0x98); + reg32 |= 1 << 19; /* BWG step 6 */ + reg32 |= 1 << 22; /* BWG step 5 */ + reg32 &= ~(0x3f << 7); + reg32 |= 0x04 << 7; /* BWG step 7 */ + reg32 |= 1 << 20; /* BWG step 8 */ + reg32 &= ~(0x03 << 5); + reg32 |= 1 << 5; /* BWG step 9 */ + reg32 |= 1 << 18; /* BWG step 10 */ + reg32 |= 1 << 29; /* BWG step 11 */ reg32 &= ~((1 << 31) | (1 << 30)); reg32 |= 1 << 23; reg32 |= 1 << 24; /* Enable MPHY Dynamic Power Gating */

Attachments:

attachment.htm (text/html — 3.3 KB)

Show replies by date

Angel Pons (Code Review)

30 Oct 30 Oct

4:11 p.m.

Hello Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47029

to look at the new patch set (#2).

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

soc/intel/broadwell/pch/sata.c: Add missing SATA init steps

WildcatPoint-LP BIOS spec lists them, and are the same for Lynxpoint. Keep the BWG comments for now, since both platforms will be merged soon.

Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/pch/sata.c 1 file changed, 9 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/47029/2

Michael Niewöhner (Code Review)

13 Nov 13 Nov

1:14 p.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47029 )

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

Patch Set 2:

tested?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Gerrit-Change-Number: 47029 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 13 Nov 2020 12:14:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

1:18 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47029 )

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

Patch Set 2:

...

Patch Set 2:

tested?

Nope, but will test soon

-- To view, visit https://review.coreboot.org/c/coreboot/+/47029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Gerrit-Change-Number: 47029 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 13 Nov 2020 12:18:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

8 Feb 8 Feb

10:26 p.m.

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47029 )

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

File src/soc/intel/broadwell/pch/sata.c:

https://review.coreboot.org/c/coreboot/+/47029/comment/d74736ca_ef3ce32b PS3, Line 66: reg32 |= 1 << 29; /* BWG step 11 */ Already set near the end of this function?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Gerrit-Change-Number: 47029 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Mon, 08 Feb 2021 21:26:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

10:28 p.m.

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47029 )

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

Patch Set 3:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/47029/comment/2ec088be_576f2075 PS3, Line 10: BWG BWG is not the same as BIOS spec (even though most insiders don't know the difference). I've also noticed that the numbers you commented match the LP BIOS spec, not the mentioned WP-LP one.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Gerrit-Change-Number: 47029 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Mon, 08 Feb 2021 21:28:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

10:30 p.m.

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47029 )

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

Patch Set 3:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/47029/comment/f9355ae6_faa33b12 PS3, Line 10: BWG

...

BWG is not the same as BIOS spec (even though most insiders don't […]

I meant the "BWG step" comments on the code.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Gerrit-Change-Number: 47029 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Mon, 08 Feb 2021 21:30:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Angel Pons (Code Review)

10:35 p.m.

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47029

to look at the new patch set (#5).

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

soc/intel/broadwell/pch/sata.c: Add missing SATA init steps

WildcatPoint-LP BIOS spec lists them, and are the same for Lynxpoint.

Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/pch/sata.c 1 file changed, 9 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/47029/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/47029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Gerrit-Change-Number: 47029 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

10:36 p.m.

Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47029 )

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

Patch Set 5:

(2 comments)

Patchset:

PS5: I should re-test

File src/soc/intel/broadwell/pch/sata.c:

https://review.coreboot.org/c/coreboot/+/47029/comment/c435c9fa_bcb6158d PS3, Line 66: reg32 |= 1 << 29; /* BWG step 11 */

...

Already set near the end of this function?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Gerrit-Change-Number: 47029 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Mon, 08 Feb 2021 21:36:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nico Huber (Code Review)

10:51 p.m.

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47029 )

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47029 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Gerrit-Change-Number: 47029 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Mon, 08 Feb 2021 21:51:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Stefan Reinauer (Code Review)

10 Jun 10 Jun

5:15 a.m.

New subject: [S] Change in coreboot[master]: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps

Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47029?usp=email )

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/47029?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iba28c1591affafeb37097084c2fa58128974bd00 Gerrit-Change-Number: 47029 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

Angel Pons (Code Review)

19 Jun 19 Jun

3:26 p.m.

New subject: [S] Change in coreboot[master]: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps

Angel Pons has restored this change. ( https://review.coreboot.org/c/coreboot/+/47029?usp=email )

Change subject: soc/intel/broadwell/pch/sata.c: Add missing SATA init steps ......................................................................

Restored

102

days inactive

1064

days old

coreboot-gerrit@coreboot.org

11 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Michael Niewöhner (Code Review)
Nico Huber (Code Review)
Stefan Reinauer (Code Review)