Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33509
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S config and AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 876 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/1
diff --git a/csb_patcher.sh b/csb_patcher.sh new file mode 100755 index 0000000..b325f71 --- /dev/null +++ b/csb_patcher.sh @@ -0,0 +1,876 @@ +#!/bin/sh +# +# csb_patcher.sh: coreboot and SeaBIOS patcher script. +# +# Conveniently and securely gets, checks SHA256 and installs some of my +# patches from this page - https://review.coreboot.org/q/status:open+banon +# and also gets a collection of useful floppy-based operating systems. +# Please send your feedback to Mike Banon mikebdp2@gmail.com +# + +# Keys +enter=$( printf '\015' ) +ctrl_c=$( printf '\003' ) +ctrl_x=$( printf '\030' ) +ctrl_z=$( printf '\032' ) + +# Formatting +bold="\e[1m" +bred="\e[1;31m" +bgreen="\e[1;32m" +byellow="\e[1;33m" +bend="\e[0m" + +# Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. +yesno () { + printf "$1 [Y/N] " + yesno_old_stty_cfg=$( stty -g ) + stty raw -echo + while true ; do + yesno_answer=$( head -c 1 ) + case "$yesno_answer" in + *"$ctrl_c"*|"$ctrl_x"*|"$ctrl_z"*) + stty "$yesno_old_stty_cfg" + printf "${bred}TERMINATED${bend}\n" + exit 1 + ;; + *"y"*|"Y"*) + stty "$yesno_old_stty_cfg" + printf "${bgreen}YES${bend}$2\n" + return 0 + ;; + *"n"*|"N"*) + stty "$yesno_old_stty_cfg" + printf "${byellow}NO${bend}\n" + return 1 + ;; + esac + done +} + +# Waits until a user presses Enter. +encontinue () { + printf "\npress [ENTER] to continue... " + encontinue_old_stty_cfg=$( stty -g ) + stty raw -echo + while true ; do + encontinue_answer=$( head -c 1 ) + case "$encontinue_answer" in + *"$ctrl_c"*|"$ctrl_x"*|"$ctrl_z"*) + stty "$encontinue_old_stty_cfg" + printf "${bred}TERMINATED${bend}\n" + exit 1 + ;; + *"$enter"*) + stty "$encontinue_old_stty_cfg" + printf "\n" + return 0 + ;; + esac + done +} + +# Checks if a command '$1' exists. +command_exists() { + if [ ! -x "$( command -v $1 )" ] ; then + printf "\n${bred}ERROR${bend}: command ${bold}$1${bend} is not found !\n" + encontinue + return 1 + else + return 0 + fi +} + +# Checks if a file '$1' exists. +file_exists () { + if [ ! -f "$1" ] ; then + printf "\n${byellow}WARNING${bend}: file ${bold}$1${bend} is not found !\n" + encontinue + return 1 + else + return 0 + fi +} + +# Force removes a file '$2' and then copies a file '$1' to '$2'. +copier () { + if file_exists "$1" ; then + rm -f "$2" + cp "$1" "$2" + return 0 + else + return 1 + fi +} + +# Force removes a file '$2' and then moves a file '$1' to '$2'. +mover () { + if file_exists "$1" ; then + rm -f "$2" + mv "$1" "$2" + return 0 + else + return 1 + fi +} + +# Checks if line '$1' contains the text '$2'. +checker () { + case "$1" in + *"$2"*) + return 0 + ;; + *) + return 1 + ;; + esac +} + +# Prints the lines of a file '$2' which contain the text '$1'. +grepper () { + if file_exists "$2" ; then + while IFS= read -r grepper_line + do + case "$grepper_line" in + *"$1"*) + printf '%s\n' "$grepper_line" + ;; + esac + done < "$2" + return 0 + else + return 1 + fi +} + +# Checks if a file '$2' contains the text '$1'. +grepcheck () { + if file_exists "$2" ; then + while IFS= read -r grepcheck_line + do + case "$grepcheck_line" in + *"$1"*) + return 0 + ;; + esac + done < "$2" + return 1 + else + return 1 + fi +} + +# Replaces the lines containing the text '$2' of a file '$1' with a line '$3'. +sedder () { + if file_exists "$1" ; then + csb_sedder_tmp="./.csb_sedder" + rm -f "$csb_sedder_tmp" + while IFS= read -r sedder_line + do + case "$sedder_line" in + *"$2"*) + if [ ! -z "$3" ] ; then + printf '%s\n' "$3" >> "$csb_sedder_tmp" + fi + ;; + *) + printf '%s\n' "$sedder_line" >> "$csb_sedder_tmp" + ;; + esac + done < "$1" + mover "$csb_sedder_tmp" "$1" + return 0 + else + return 1 + fi +} + +# Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. +wgetter () { + rm -f "$1" + if [ -z "$3" ] ; then + wget "$2" + else + wget "$3" "$2" + fi + if [ -f "$1" ] ; then + wgetter_file_size=$(($( wc -c < "$1" ))) + if [ "$wgetter_file_size" -eq "0" ] ; then + rm -f "$1" + fi + fi + if [ ! -f "$1" ] ; then + printf "\n${byellow}WARNING${bend}: can't download a ${bold}$1${bend} file !" + printf "\n Please check your Internet connection and try again.\n" + encontinue + return 1 + else + return 0 + fi +} + +# Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. +unzipper () { + if file_exists "$1" ; then + if [ -z "$2" ] ; then + unzip "$1" + else + unzip -j "$1" "$2" + fi + rm -f "$1" + return 0 + else + return 1 + fi +} + +# Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. +expander () { + if file_exists "$1" && [ ! -z "$2" ] ; then + expander_file_size=$(($( wc -c < "$1" ))) + if [ "$expander_file_size" -lt "$2" ] ; then + dd if=/dev/zero of=$1 bs=1 count=1 seek="$(( $2 - 1 ))" conv=notrunc iflag=nocache + fi + return 0 + else + return 1 + fi +} + +# Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. +floppy_verifier () { + rm -f "./.$1" + cd ".." + if [ ! -z "$2" ] ; then + if file_exists "./floppies/$1.img" ; then + floppy_verifier_sha256sum_correct="$2 ./floppies/$1.img" + floppy_verifier_sha256sum_my=$( sha256sum "./floppies/$1.img" ) + printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" + if [ "$floppy_verifier_sha256sum_my" = "$floppy_verifier_sha256sum_correct" ] ; then + printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" + cd "./floppies/" + touch "./.$1" + return 0 + else + printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" + encontinue + cd "./floppies/" + return 1 + fi + else + printf "\n${byellow}WARNING${bend}: cannot find ./floppies/${bold}$1.img${bend} !\n" + printf "\n Please re-download a set of floppies.\n" + encontinue + return 1 + fi + else + printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" + printf "\n is changing constantly and not provided by $1 project, so not checked.\n" + encontinue + cd "./floppies/" + touch "./.$1" + return 0 + fi +} + +# Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. +floppy_mass_downloader () { + printf "\n" + if [ ! -d "./floppies/" ]; then + mkdir "./floppies/" + fi + cd "./floppies/" + # KOLIBRI + if command_exists "7za" ; then + if wgetter "./latest-img.7z" "https://builds.kolibrios.org/eng/latest-img.7z" ; then + rm -f "./kolibri.img" + 7za x "./latest-img.7z" + rm -f "./latest-img.7z" + floppy_verifier "kolibri" "" # IS A ROLLING RELEASE, NO SHA256 VERIFICATION + fi + else + printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" + encontinue + fi + # FREEDOS + if wgetter "./FD12FLOPPY.zip" "https://www.freedos.org/download/download/FD12FLOPPY.zip" ; then + unzipper "./FD12FLOPPY.zip" "FLOPPY.img" + mover "./FLOPPY.img" "./freedos.img" + floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" + fi + # MICHALOS + printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" + if wgetter "./MichalOS 2.0 Source.zip" "https://sourceforge.net/p/michalos/tickets/_discuss/thread/69ab1508c3/39cd/4..." "--content-disposition" ; then + unzipper "./MichalOS 2.0 Source.zip" "disk_images/michalos.img" + floppy_verifier "michalos" "139e9d08881f646156971a0a061972ddca77057b8acf4164e36366271ab3658c" + fi + # SNOWDROP + if wgetter "./snowdrop.img" "http://sebastianmihai.com/downloads/snowdrop/snowdrop.img" ; then + floppy_verifier "snowdrop" "" # IS A ROLLING RELEASE, NO SHA256 VERIFICATION + fi + # FIWIX + if wgetter "./fiwix.img" "https://www.fiwix.org/fiwix-1.0.1-i386-initrd.img" "--output-document=fiwix.img" ; then + floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" + fi + # MEMTEST + if wgetter "./memtest86+-5.01.floppy.zip" "https://www.memtest.org/download/5.01/memtest86+-5.01.floppy.zip" ; then + unzipper "./memtest86+-5.01.floppy.zip" "floppy/memtestp.bin" + expander "./memtestp.bin" "1474560" + mover "./memtestp.bin" "./memtest.img" + floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" + fi + # TATOS + if wgetter "./tatos.img" "https://github.com/tatimmer/tatOS/raw/master/tatOS.img" "--output-document=tatos.img" ; then + expander "./tatos.img" "1474560" + floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" + fi + # PLOP + if wgetter "./plpbt-5.0.15.zip" "https://download.plop.at/files/bootmngr/plpbt-5.0.15.zip" ; then + unzipper "./plpbt-5.0.15.zip" "plpbt-5.0.15/plpbt.img" + mover "./plpbt.img" "./plop.img" + floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" + fi + # FLOPPYBIRD + if wgetter "./floppybird.img" "https://github.com/mikebdp2/floparchive/raw/master/floppies_extra/floppybird..." ; then + floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" + fi + # Some floppies have the weird permissions after their extraction + floppy_mass_downloader_floppies=$( find . -name "*.img" ) + if [ ! -z "$floppy_mass_downloader_floppies" ] ; then + chmod 755 "./"*".img" + fi + # Return back to ./coreboot/ + cd ".." + return 0 +} + +# Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. +atombios_adder () { + if file_exists "$2" && file_exists "$3" ; then + if [ -f "./pci1002,$1.rom" ] ; then + atombios_adder_cbfs=$( "$2" "$3" print ) + if checker "$atombios_adder_cbfs" "pci1002,$1.rom" ; then + printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" + else + if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then + "$2" "$3" add -f "./pci1002,$1.rom" -n "pci1002,$1.rom" -t optionrom + else + printf "\n${bold}You can add it later by running:${bend}" + printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" + fi + fi + return 0 + else + printf "\n${byellow}WARNING${bend}: cannot find ./${bold}pci1002,$1.rom${bend} ," + printf "\n please re-apply ${bold}AMD atombios${bend} patch.\n" + encontinue + return 1 + fi + else + return 1 + fi +} + +# Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. +floppy_adder () { + if file_exists "$2" && file_exists "$3" ; then + if [ -f "./floppies/$1.img" ] ; then + if [ -f "./floppies/.$1" ] ; then + floppy_adder_cbfs=$( "$2" "$3" print ) + if checker "$floppy_adder_cbfs" "floppyimg/$1.lzma" ; then + printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" + else + if checker "$1" "plop" ; then + printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" + printf "\n Add it only if you really need it and trust the author of $1 project.\n" + encontinue + fi + if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then + "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma + else + printf "\n${bold}You can add it later by running:${bend}" + printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" + fi + fi + return 0 + else + printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" + printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" + encontinue + return 1 + fi + else + printf "\n${byellow}WARNING${bend}: cannot find ./floppies/${bold}$1.img${bend} !\n" + printf "\n Please re-download a set of floppies.\n" + encontinue + return 1 + fi + else + return 1 + fi +} + +# Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. +cbfs_mass_adder () { + if ! grepcheck "how to submit coreboot changes" ./MAINTAINERS ; then + printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," + printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" + fi + if file_exists "$2" && file_exists "$3" ; then + if checker "$1" "atom" || checker "$1" "flop" ; then + copier "$3" "$4" + printf "\n${bold}=== $4 - initial memory map${bend}\n\n" + "$2" "$4" print + printf "\n" + if checker "$1" "atom" ; then +### +### https://review.coreboot.org/c/coreboot/+/31944 +### G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 +### + csb_patcher "atombios" "31944" "6" "78a8454" "9a8efff284bbdb81d5b912ccc8279162553e04673bde53e5288ba4bed0e4bc3d" "$1" "AMD " + atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" + atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" + atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" + atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" + atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" + fi + if checker "$1" "flop" ; then + if [ ! -d "./floppies/" ] ; then + printf "\n" + floppy_mass_downloader + fi + # Default boot order: the last floppy added - is the first floppy to boot! + floppy_adder "floppybird" "$2" "$4" "2K" + floppy_adder "plop" "$2" "$4" "74K" + floppy_adder "tatos" "$2" "$4" "60K" + floppy_adder "memtest" "$2" "$4" "44K" + floppy_adder "fiwix" "$2" "$4" "458K" + floppy_adder "snowdrop" "$2" "$4" "126K" + floppy_adder "michalos" "$2" "$4" "256K" + floppy_adder "freedos" "$2" "$4" "698K" + floppy_adder "kolibri" "$2" "$4" "1264K" + fi + printf "\n${bold}=== $4 - final memory map${bend}\n\n" + "$2" "$4" print + printf "\nYou can use ./build/${bold}coreflop.rom${bend} now !\n\n" + return 0 + else + return 1 + fi + else + return 1 + fi +} + +# Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. +csb_finder () { + csb_finder_files=$( find . -name "*.$1" ) + if [ ! -z "$csb_finder_files" ] ; then + printf "%25s\n" "*.$1 - YES" >> "$2" + printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" + printf "$csb_finder_files" + printf "\n That means - Some patches $3\n" + encontinue + return 0 + else + printf "%24s\n" "*.$1 - NO" >> "$2" + return 1 + fi +} + +# Prints a csb_patcher_log '$1' with a custom highlighting. +csb_printer () { + if ! file_exists "$1" ; then + return 1 + fi + while IFS= read -r csb_printer_line + do + case "$csb_printer_line" in + *"orig - YES"*) + printf "${csb_printer_line%???}${byellow}YES" # YELLOW + ;; + *"rej - YES"*) + printf "${csb_printer_line%???}${bred}YES" # RED + ;; + *"YES"*) + printf "${csb_printer_line%???}${bgreen}YES" # GREEN + ;; + *"orig - NO"*|*"rej - NO"*) + printf "${csb_printer_line%??}${bgreen}NO" # GREEN + ;; + *"NO"*) + printf "${csb_printer_line%??}${byellow}NO" # YELLOW + ;; + *"FAILURE_1"*) + printf "${csb_printer_line%?????????}${bred}FAILURE_1" # RED + ;; + *"FAILURE_2"*) + printf "${csb_printer_line%?????????}${bred}FAILURE_2" # RED + ;; + *"FAILURE_3"*) + printf "${csb_printer_line%?????????}${bred}FAILURE_3" # RED + ;; + *"\\"*) + printf "${bold}${csb_printer_line%?????}\\!//" # ALIEN HAIR + ;; + *) + printf "${bold}$csb_printer_line" + ;; + esac + printf "${bend}\n" + done < "$1" + return 0 +} + +# Configure some popular options of a config file '$1'. +csb_configurer () { + if file_exists "$1" ; then + csb_configurer_tmp="./.csb_configurer" + rm -f "$csb_configurer_tmp" + grepper "CONFIG_BOARD_" "$1" > "$csb_configurer_tmp" + if grepcheck "_LENOVO_G505S=y" "$csb_configurer_tmp" ; then + printf "\n\n${bgreen}[CONFIG]${bend} Questions about your Lenovo G505S\n\n" + sedder "$1" "### CSB_CONFIGURER OPTIONS" "" + printf "### CSB_CONFIGURER OPTIONS\n" >> "$1" + sedder "$1" "# CONFIG_DRIVERS_INTEL_WIFI is not set" "" + if ! yesno "Do you have an Intel WiFi adapter?" "" ; then + printf "# CONFIG_DRIVERS_INTEL_WIFI is not set\n" >> "$1" + fi + sedder "$1" "CONFIG_MULTIPLE_VGA_ADAPTERS=y" "" + sedder "$1" "CONFIG_VGA_BIOS_DGPU=y" "" + sedder "$1" "CONFIG_VGA_BIOS_DGPU_FILE="pci1002,6663.rom"" "" + sedder "$1" "CONFIG_VGA_BIOS_DGPU_ID="1002,6663"" "" + sedder "$1" "CONFIG_VGA_BIOS_DGPU_FILE="pci1002,6665.rom"" "" + sedder "$1" "CONFIG_VGA_BIOS_DGPU_ID="1002,6665"" "" + if yesno "Do you have a Discrete GPU?" "" ; then + printf "CONFIG_MULTIPLE_VGA_ADAPTERS=y\n" >> "$1" + printf "CONFIG_VGA_BIOS_DGPU=y\n" >> "$1" + if yesno "No for HD-8570M, Yes for R5-M230" "" ; then + printf "CONFIG_VGA_BIOS_DGPU_FILE="pci1002,6665.rom"\n" >> "$1" + printf "CONFIG_VGA_BIOS_DGPU_ID="1002,6665"\n" >> "$1" + else + printf "CONFIG_VGA_BIOS_DGPU_FILE="pci1002,6663.rom"\n" >> "$1" + printf "CONFIG_VGA_BIOS_DGPU_ID="1002,6663"\n" >> "$1" + fi + fi + + sedder "$1" "# NATIVE" "" + sedder "$1" "CONFIG_HUDSON_SATA_MODE=0" "" + + sedder "$1" "# RAID" "" + sedder "$1" "CONFIG_HUDSON_SATA_MODE=1" "" + sedder "$1" "CONFIG_RAID_ROM_ID="1022,7802"" "" + sedder "$1" "CONFIG_RAID_ROM_FILE="src/southbridge/amd/agesa/hudson/raid.bin"" "" + sedder "$1" "CONFIG_RAID_MISC_ROM_FILE="src/southbridge/amd/agesa/hudson/misc.bin"" "" + sedder "$1" "CONFIG_RAID_MISC_ROM_POSITION=0xFFF00000" "" + + sedder "$1" "# AHCI" "" + sedder "$1" "CONFIG_HUDSON_SATA_MODE=2" "" + sedder "$1" "CONFIG_AHCI_ROM_ID="1022,7801"" "" + sedder "$1" "# CONFIG_HUDSON_AHCI_ROM is not set" "" + + sedder "$1" "# LEGACY IDE" "" + sedder "$1" "CONFIG_HUDSON_SATA_MODE=3" "" + + sedder "$1" "# IDE to AHCI" "" + sedder "$1" "CONFIG_HUDSON_SATA_MODE=4" "" + + sedder "$1" "# AHCI7804" "" + sedder "$1" "CONFIG_HUDSON_SATA_MODE=5" "" + sedder "$1" "CONFIG_AHCI_ROM_ID="1022,7804"" "" + + sedder "$1" "# IDE to AHCI7804" "" + sedder "$1" "CONFIG_HUDSON_SATA_MODE=6" "" + sedder "$1" "# CONFIG_HUDSON_AHCI_ROM is not set" "" + + if yesno "Do you have a SSD? (enable AHCI if Y)" "" ; then + printf "# AHCI\n" >> "$1" + printf "CONFIG_HUDSON_SATA_MODE=2\n" >> "$1" + printf "CONFIG_AHCI_ROM_ID="1022,7801"\n" >> "$1" + printf "# CONFIG_HUDSON_AHCI_ROM is not set\n" >> "$1" + else + printf "# NATIVE\n" >> "$1" + printf "CONFIG_HUDSON_SATA_MODE=0\n" >> "$1" + fi + rm -f "$csb_configurer_tmp" + return 0 + else + printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" + encontinue + return 1 + fi + else + return 1 + fi +} + +# +# Conveniently and securely gets, checks SHA256 and installs a patch. +# Arguments are the patch properties: +# $1 - new diff name, could be also a part of extracted scripts' filename +# $2 - change ID number, part of download link to review.coreboot.org +# $3 - change revision number, part of download link to review.coreboot.org +# $4 - diff filename inside the downloaded archive, will be renamed to $1 +# $5 - diff known good SHA256 checksum, will be used for SHA256 verification +# $6 - filepath where to save a csb_patcher_log which will be printed later +# $7 - info about the target of a patch, if not specified ("") it is common +# +csb_patcher () { + if ! wgetter "./patch?zip" "https://review.coreboot.org/changes/$2/revisions/$3/patch?zip" ; then + printf "${bold}^^^ ! Can't download a $7$1 patch ! Check your Internet.${bend}\n" + printf "%31s\n" "$7$1 - FAILURE_1" >> "$6" + csb_printer "$6" + exit 1 + fi + unzipper "./patch?zip" + mover "./$4.diff" "./$1.diff" + csb_patcher_sha256sum_correct="$5 ./$1.diff" + csb_patcher_sha256sum_my=$( sha256sum "./$1.diff" ) + printf "\n=== sha256sum should be:\n${bold}$csb_patcher_sha256sum_correct${bend}\n" + if [ "$csb_patcher_sha256sum_my" = "$csb_patcher_sha256sum_correct" ] ; then + printf "^^^ this is correct, " + csb_patcher_patch_title=$( grepper "Subject" "./$1.diff" ) + csb_patcher_patch_title=${csb_patcher_patch_title#?????????????????} + if [ "$1" = "dgpu" ] ; then + printf "will extract a ${bold}$7$1${bend} patch now...\n" + rm -f "./sha256sums_$1_correct.txt" + rm -f "./"*"_$1_patches.sh" + patch -p1 < "./$1.diff" + chmod +x "./"*"_$1_patches.sh" + "./get_$1_patches.sh" + if ! "./check_$1_patches.sh" ; then + printf "%31s\n" "$7$1 - FAILURE_3" >> "$6" + csb_printer "$6" + exit 1 + fi + else + printf "${bold}$7$1${bend} patch could be applied now...\n" + fi + if [ "$1" = "dgpu" ] || [ "$1" = "atombios" ] || \ + [ "$1" = "tint" ] || [ "$1" = "seabios" ] ; then + printf "\n\n${bgreen}[PATCH]${bend} $csb_patcher_patch_title\n\n" + if ! grepcheck "how to submit coreboot changes" ./MAINTAINERS ; then + printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," + printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" + fi + if [ -f "./.$1" ] ; then + printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," + printf "\n maybe you have applied this patch already.\n\n" + fi + if yesno "Apply a ${bold}$7$1${bend} patch now?" "" ; then + if [ "$1" = "dgpu" ] ; then + "./apply_$1_patches.sh" + else + if [ "$1" = "atombios" ] ; then + rm -f "./sha256sums_$1_correct.txt" + rm -f "./"*"_$1_roms.sh" + rm -f "./pci1002,"*".rom" + rm -f "./pci1002,"*".rom.txt" + fi + if [ "$1" = "tint" ] ; then + rm -f "./payloads/external/tint/tint.sh" + rm -f "./payloads/external/tint/"*"_core.sh" + rm -f "./payloads/external/tint/tint-0.04-nmu1_libpayload.patch" + fi + if [ "$1" = "seabios" ] ; then + rm -f "./payloads/external/SeaBIOS/"*".patch" + fi + patch -p1 < "./$1.diff" + if [ "$1" = "atombios" ] ; then + chmod +x "./"*"_$1_roms.sh" + "./extract_$1_roms.sh" + printf "\n" + if ! "./check_$1_roms.sh" ; then + printf "%31s\n" "$7$1 - FAILURE_3" >> "$6" + csb_printer "$6" + exit 1 + fi + fi + if [ "$1" = "tint" ] ; then + chmod +x "./payloads/external/tint/"*"_core.sh" + fi + fi + touch ".$1" + printf "%25s\n" "$7$1 - YES" >> "$6" + if [ "$1" = "atombios" ] ; then + encontinue + fi + else + printf "%24s\n" "$7$1 - NO" >> "$6" + printf "\n${bold}You can apply it later by running:${bend}" + if [ "$1" = "dgpu" ] ; then + printf "\n${bold} ./apply_$1_patches.sh${bend}\n" + else + printf "\n${bold} patch -p1 < ./$1.diff${bend}\n" + fi + encontinue + fi + fi + if checker "$1" "config" ; then + rm -f "./configs/$1_"* + patch -p1 < "./$1.diff" + printf "\n\n${bgreen}[PATCH]${bend} $csb_patcher_patch_title\n\n" + ls "./configs" > "./.csb_configs" + csb_patcher_config_name=$( grepper "$1" "./.csb_configs" ) + rm -f "./.csb_configs" + printf "\n${bold}$csb_patcher_config_name could now be found at ./configs/${bend}" + printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" + if [ -f "./.config" ] ; then + printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" + fi + if yesno "Copy it to ./.config now?" "" ; then + copier "./configs/$csb_patcher_config_name" "./.config" + printf "\n" + printf "%25s\n" "$7$1 - YES" >> "$6" + if yesno "Configure this ./.config now?" "" ; then + csb_configurer "./.config" + else + printf "\n${bold}You can configure it later by running:${bend}" + printf "\n${bold} ./csb_patcher.sh config${bend}\n\n" + fi + else + printf "%24s\n" "$7$1 - NO" >> "$6" + printf "\n${bold}You can copy it later by running:${bend}" + printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" + fi + printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" + encontinue + fi + printf "\n\n" + return 0 + else + printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" + printf "%31s\n" "$7$1 - FAILURE_2" >> "$6" + csb_printer "$6" + exit 1 + fi +} + +# +# Conveniently and securely gets, checks SHA256 and applies my collection of unofficial patches. +# $1 - filepath where to save a csb_patcher_log which will be printed later +# +csb_mass_patcher () { +### +### https://review.coreboot.org/c/coreboot/+/31929 +### G505S dGPU support: scripts for applying the unofficial (not-merged-yet) patches +### + csb_patcher "dgpu" "31929" "13" "ed0c44f" "eb461931a1f34a8263405138eb1bf8d32a1f460026449c9ec1a9b9e7d8383f1c" "$1" "G505S " +### +### https://review.coreboot.org/c/coreboot/+/31944 +### G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 +### + csb_patcher "atombios" "31944" "6" "78a8454" "9a8efff284bbdb81d5b912ccc8279162553e04673bde53e5288ba4bed0e4bc3d" "$1" "AMD " +### +### https://review.coreboot.org/c/coreboot/+/23856 +### tint: introduce the new tint build system with checksum verification +### + csb_patcher "tint" "23856" "15" "14630b6" "7b9719f675d83750c7d4fb21b3abcbf1758ac6d1db20a9e8ef0db22f15761317" "$1" "" +### +### https://review.coreboot.org/c/coreboot/+/32351 +### SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb +### + csb_patcher "seabios" "32351" "5" "4a9c3cd" "58348b0514446856d07078af443ac8a24cd3be8178290e7361a48a86d213a43b" "$1" "" +### +### https://review.coreboot.org/c/coreboot/+/32352 +### configs: add Lenovo G505S sample configuration (use with dGPU patches) +### +csb_patcher "config.lenovo_g505s" "32352" "12" "348d8ce" "5b3b663b3afe3fe5729be2632201f3665e75ed3848996901322d3528ed6dd897" "$1" "" + + return 0 +} + +# Prints a usage info for this ./csb_patcher.sh script. +csb_usage () { + printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" + printf "${bold}./csb_patcher.sh${bend}\n" + printf " patch your coreboot source code\n\n" + printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" + printf " print this usage info\n\n" + printf "${bold}==================== Before building :${bend}\n\n" + printf "${bold}./csb_patcher.sh ${byellow}config${bend}\n" + printf " configure some popular options\n\n" + printf "${bold}==================== After building :${bend}\n\n" + printf "${bold}./csb_patcher.sh ${byellow}atom${bend}\n" + printf " add the AtomBIOS to coreboot.rom\n\n" + printf "${bold}./csb_patcher.sh ${byellow}flop${bend}\n" + printf " add the floppies to coreboot.rom\n\n" + printf "${bold}./csb_patcher.sh ${byellow}atomflop${bend}\n" + printf " both AtomBIOS VGA ROMs and floppies\n\n" + printf "${bold}./csb_patcher.sh${bend} ${byellow}print${bend}\n" + printf " print a ./.csb_patcher log\n\n" + return 0 +} + +# +# MAIN PART OF A CSB_PATCHER SCRIPT +# + +if [ -z "$1" ] ; then + csb_patcher_log="./.csb_patcher" + rm -f "$csb_patcher_log" + if ! command_exists "wget" || \ + ! command_exists "unzip" || \ + ! command_exists "sha256sum" || \ + ! command_exists "patch" ; then + exit 1 + fi + printf '\n\n' >> "$csb_patcher_log" + printf ' \\!//\n' >> "$csb_patcher_log" + printf ' (o o)\n' >> "$csb_patcher_log" + printf ' oOOo-(_)-oOOo\n' >> "$csb_patcher_log" + printf 'Hi! I am coreboot and SeaBIOS patcher\n' >> "$csb_patcher_log" + printf 'Please send your feedback to\n' >> "$csb_patcher_log" + printf ' Mike Banon mikebdp2@gmail.com\n' >> "$csb_patcher_log" + csb_printer "$csb_patcher_log" + encontinue + printf '\n=== CSB_PATCHER LOG. Patches applied?\n' >> "$csb_patcher_log" + + csb_mass_patcher "$csb_patcher_log" + + if yesno "Download a ${bold}floppies${bend} collection?" "" ; then + floppy_mass_downloader + printf "%25s\n" "floppies - YES" >> "$csb_patcher_log" + else + printf "\n" + printf "%24s\n" "floppies - NO" >> "$csb_patcher_log" + fi + + printf '==================== Bad files found?\n' >> "$csb_patcher_log" + csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." + csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" + + printf '\n' >> "$csb_patcher_log" + csb_printer "$csb_patcher_log" + csb_usage +else + case "$1" in + *"print"*) + csb_patcher_log="./.csb_patcher" + csb_printer "$csb_patcher_log" + ;; + *"config"*) + csb_configurer "./.config" + ;; + *"atom"*|*"flop"*) + if ! command_exists "wget" || \ + ! command_exists "unzip" || \ + ! command_exists "sha256sum" ; then + exit 1 + fi + cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" + ;; + *"help"*|*"usage"*) + printf "\n" + csb_usage + ;; + *) + printf "\n${bred}ERROR${bend}: unknown argument ${bold}$1${bend} !\n\n" + csb_usage + exit 1 + ;; + esac +fi + +exit 0 +
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 1:
(62 comments)
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@24 PS1, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@188 PS1, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@212 PS1, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@227 PS1, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@240 PS1, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@248 PS1, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@250 PS1, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@255 PS1, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@267 PS1, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@268 PS1, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@276 PS1, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@292 PS1, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@299 PS1, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@302 PS1, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@305 PS1, Line 305: floppy_verifier "michalos" "139e9d08881f646156971a0a061972ddca77057b8acf4164e36366271ab3658c" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@313 PS1, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@320 PS1, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@325 PS1, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@331 PS1, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@335 PS1, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@347 PS1, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@353 PS1, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@355 PS1, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@359 PS1, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@374 PS1, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@381 PS1, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@384 PS1, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@385 PS1, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@388 PS1, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@389 PS1, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@392 PS1, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@397 PS1, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@398 PS1, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@413 PS1, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@430 PS1, Line 430: csb_patcher "atombios" "31944" "6" "78a8454" "9a8efff284bbdb81d5b912ccc8279162553e04673bde53e5288ba4bed0e4bc3d" "$1" "AMD " line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@431 PS1, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@432 PS1, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@433 PS1, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@434 PS1, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@435 PS1, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@465 PS1, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@470 PS1, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@564 PS1, Line 564: sedder "$1" "CONFIG_RAID_MISC_ROM_FILE="src/southbridge/amd/agesa/hudson/misc.bin"" "" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@598 PS1, Line 598: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@653 PS1, Line 653: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@654 PS1, Line 654: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@657 PS1, Line 657: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@717 PS1, Line 717: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@719 PS1, Line 719: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@734 PS1, Line 734: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@736 PS1, Line 736: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@742 PS1, Line 742: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@758 PS1, Line 758: csb_patcher "dgpu" "31929" "13" "ed0c44f" "eb461931a1f34a8263405138eb1bf8d32a1f460026449c9ec1a9b9e7d8383f1c" "$1" "G505S " line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@763 PS1, Line 763: csb_patcher "atombios" "31944" "6" "78a8454" "9a8efff284bbdb81d5b912ccc8279162553e04673bde53e5288ba4bed0e4bc3d" "$1" "AMD " line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@768 PS1, Line 768: csb_patcher "tint" "23856" "15" "14630b6" "7b9719f675d83750c7d4fb21b3abcbf1758ac6d1db20a9e8ef0db22f15761317" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@773 PS1, Line 773: csb_patcher "seabios" "32351" "5" "4a9c3cd" "58348b0514446856d07078af443ac8a24cd3be8178290e7361a48a86d213a43b" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@778 PS1, Line 778: csb_patcher "config.lenovo_g505s" "32352" "12" "348d8ce" "5b3b663b3afe3fe5729be2632201f3665e75ed3848996901322d3528ed6dd897" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@785 PS1, Line 785: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@788 PS1, Line 788: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@840 PS1, Line 840: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@841 PS1, Line 841: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/#/c/33509/1/csb_patcher.sh@861 PS1, Line 861: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#2).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 893 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 2:
(62 comments)
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@24 PS2, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@188 PS2, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@212 PS2, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@227 PS2, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@240 PS2, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@248 PS2, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@250 PS2, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@255 PS2, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@267 PS2, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@268 PS2, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@276 PS2, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@292 PS2, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@299 PS2, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@302 PS2, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@305 PS2, Line 305: floppy_verifier "michalos" "139e9d08881f646156971a0a061972ddca77057b8acf4164e36366271ab3658c" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@313 PS2, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@320 PS2, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@325 PS2, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@331 PS2, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@335 PS2, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@347 PS2, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@353 PS2, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@355 PS2, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@359 PS2, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@374 PS2, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@381 PS2, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@384 PS2, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@385 PS2, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@388 PS2, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@389 PS2, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@392 PS2, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@397 PS2, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@398 PS2, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@413 PS2, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@430 PS2, Line 430: csb_patcher "atombios" "31944" "6" "78a8454" "9a8efff284bbdb81d5b912ccc8279162553e04673bde53e5288ba4bed0e4bc3d" "$1" "AMD " line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@431 PS2, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@432 PS2, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@433 PS2, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@434 PS2, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@435 PS2, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@465 PS2, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@470 PS2, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@538 PS2, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@665 PS2, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@666 PS2, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@669 PS2, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@729 PS2, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@731 PS2, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@746 PS2, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@748 PS2, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@754 PS2, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@770 PS2, Line 770: csb_patcher "dgpu" "31929" "13" "ed0c44f" "eb461931a1f34a8263405138eb1bf8d32a1f460026449c9ec1a9b9e7d8383f1c" "$1" "G505S " line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@775 PS2, Line 775: csb_patcher "atombios" "31944" "6" "78a8454" "9a8efff284bbdb81d5b912ccc8279162553e04673bde53e5288ba4bed0e4bc3d" "$1" "AMD " line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@780 PS2, Line 780: csb_patcher "tint" "23856" "15" "14630b6" "7b9719f675d83750c7d4fb21b3abcbf1758ac6d1db20a9e8ef0db22f15761317" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@785 PS2, Line 785: csb_patcher "seabios" "32351" "5" "4a9c3cd" "58348b0514446856d07078af443ac8a24cd3be8178290e7361a48a86d213a43b" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@790 PS2, Line 790: csb_patcher "config.lenovo_g505s" "32352" "14" "1cd80c9" "2b2393532cde2754c957d287a72d4bfdd572e8893204130202a77db58f995465" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@795 PS2, Line 795: csb_patcher "config.asus_am1i-a" "33800" "1" "84dc520" "b77ca71f3c40d7ab17424d12e892d4deeda133e8f4b5a32a57132a7c0de94df5" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@802 PS2, Line 802: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@805 PS2, Line 805: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@857 PS2, Line 857: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@858 PS2, Line 858: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/#/c/33509/2/csb_patcher.sh@878 PS2, Line 878: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#3).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 893 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/3
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 3:
(62 comments)
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@24 PS3, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@188 PS3, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@212 PS3, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@227 PS3, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@240 PS3, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@248 PS3, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@250 PS3, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@255 PS3, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@267 PS3, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@268 PS3, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@276 PS3, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@292 PS3, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@299 PS3, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@302 PS3, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@305 PS3, Line 305: floppy_verifier "michalos" "139e9d08881f646156971a0a061972ddca77057b8acf4164e36366271ab3658c" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@313 PS3, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@320 PS3, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@325 PS3, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@331 PS3, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@335 PS3, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@347 PS3, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@353 PS3, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@355 PS3, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@359 PS3, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@374 PS3, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@381 PS3, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@384 PS3, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@385 PS3, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@388 PS3, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@389 PS3, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@392 PS3, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@397 PS3, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@398 PS3, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@413 PS3, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@430 PS3, Line 430: csb_patcher "atombios" "31944" "6" "78a8454" "9a8efff284bbdb81d5b912ccc8279162553e04673bde53e5288ba4bed0e4bc3d" "$1" "AMD " line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@431 PS3, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@432 PS3, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@433 PS3, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@434 PS3, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@435 PS3, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@465 PS3, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@470 PS3, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@538 PS3, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@665 PS3, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@666 PS3, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@669 PS3, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@729 PS3, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@731 PS3, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@746 PS3, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@748 PS3, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@754 PS3, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@770 PS3, Line 770: csb_patcher "dgpu" "31929" "13" "ed0c44f" "eb461931a1f34a8263405138eb1bf8d32a1f460026449c9ec1a9b9e7d8383f1c" "$1" "G505S " line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@775 PS3, Line 775: csb_patcher "atombios" "31944" "6" "78a8454" "9a8efff284bbdb81d5b912ccc8279162553e04673bde53e5288ba4bed0e4bc3d" "$1" "AMD " line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@780 PS3, Line 780: csb_patcher "tint" "23856" "15" "14630b6" "7b9719f675d83750c7d4fb21b3abcbf1758ac6d1db20a9e8ef0db22f15761317" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@785 PS3, Line 785: csb_patcher "seabios" "32351" "5" "4a9c3cd" "58348b0514446856d07078af443ac8a24cd3be8178290e7361a48a86d213a43b" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@790 PS3, Line 790: csb_patcher "config.lenovo_g505s" "32352" "15" "823097e" "490383f694b736cd371b32d65f53014ebe5ac9f2f265bffbe1a5ede7607aa476" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@795 PS3, Line 795: csb_patcher "config.asus_am1i-a" "33800" "2" "881b7bb" "6e8a14ebdce055ab81cb28affbcebda94c47c2cee26e5166690699d4f6a99052" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@802 PS3, Line 802: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@805 PS3, Line 805: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@857 PS3, Line 857: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@858 PS3, Line 858: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/#/c/33509/3/csb_patcher.sh@878 PS3, Line 878: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#4).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 898 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/4
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 4:
(63 comments)
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@24 PS4, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@188 PS4, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@212 PS4, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@227 PS4, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@240 PS4, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@248 PS4, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@250 PS4, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@255 PS4, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@267 PS4, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@268 PS4, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@276 PS4, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@292 PS4, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@299 PS4, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@302 PS4, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@305 PS4, Line 305: floppy_verifier "michalos" "139e9d08881f646156971a0a061972ddca77057b8acf4164e36366271ab3658c" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@313 PS4, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@320 PS4, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@325 PS4, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@331 PS4, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@335 PS4, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@347 PS4, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@353 PS4, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@355 PS4, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@359 PS4, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@374 PS4, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@381 PS4, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@384 PS4, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@385 PS4, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@388 PS4, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@389 PS4, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@392 PS4, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@397 PS4, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@398 PS4, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@413 PS4, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@430 PS4, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@431 PS4, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@432 PS4, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@433 PS4, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@434 PS4, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@435 PS4, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@465 PS4, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@470 PS4, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@538 PS4, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@665 PS4, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@666 PS4, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@669 PS4, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@729 PS4, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@731 PS4, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@746 PS4, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@748 PS4, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@754 PS4, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@770 PS4, Line 770: csb_patcher "dgpu" "33874" "1" "890eb4d" "4d653376488804262210e9fdd6f9e300a4c86c3b0084ee8fab2e0e2f6afec057" "$1" "G505S " line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@775 PS4, Line 775: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@780 PS4, Line 780: csb_patcher "tint" "33887" "1" "66aec99" "928a5bd51c3731368b1ce7b65e759caf50316ab3fa0da8c336c9aae13736399f" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@785 PS4, Line 785: csb_patcher "seabios" "32351" "6" "a2ceeaf" "728e934b2fb040d20862dcb74b532931cdded28f00fd130a0d5af92617ab880a" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@790 PS4, Line 790: csb_patcher "cfgsb" "33885" "1" "2c8f496" "67a7717376d529c8156b65de873009bc82a4a8732694466622ee3caabf8bd6d4" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@795 PS4, Line 795: csb_patcher "config.lenovo_g505s" "32352" "15" "823097e" "490383f694b736cd371b32d65f53014ebe5ac9f2f265bffbe1a5ede7607aa476" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@800 PS4, Line 800: csb_patcher "config.asus_am1i-a" "33800" "2" "881b7bb" "6e8a14ebdce055ab81cb28affbcebda94c47c2cee26e5166690699d4f6a99052" "$1" "" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@807 PS4, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@810 PS4, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@862 PS4, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@863 PS4, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/#/c/33509/4/csb_patcher.sh@883 PS4, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 5:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@24 PS5, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@188 PS5, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@212 PS5, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@227 PS5, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@240 PS5, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@248 PS5, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@250 PS5, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@255 PS5, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@267 PS5, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@268 PS5, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@276 PS5, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@292 PS5, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@299 PS5, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@302 PS5, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@305 PS5, Line 305: floppy_verifier "michalos" "139e9d08881f646156971a0a061972ddca77057b8acf4164e36366271ab3658c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@313 PS5, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@320 PS5, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@325 PS5, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@331 PS5, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@335 PS5, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@347 PS5, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@353 PS5, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@355 PS5, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@359 PS5, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@374 PS5, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@381 PS5, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@384 PS5, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@385 PS5, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@388 PS5, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@389 PS5, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@392 PS5, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@397 PS5, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@398 PS5, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@413 PS5, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@430 PS5, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@431 PS5, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@432 PS5, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@433 PS5, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@434 PS5, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@435 PS5, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@465 PS5, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@470 PS5, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@538 PS5, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@665 PS5, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@666 PS5, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@669 PS5, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@729 PS5, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@731 PS5, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@746 PS5, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@748 PS5, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@754 PS5, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@770 PS5, Line 770: csb_patcher "dgpu" "33874" "1" "890eb4d" "4d653376488804262210e9fdd6f9e300a4c86c3b0084ee8fab2e0e2f6afec057" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@775 PS5, Line 775: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@780 PS5, Line 780: csb_patcher "tint" "33887" "1" "66aec99" "928a5bd51c3731368b1ce7b65e759caf50316ab3fa0da8c336c9aae13736399f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@785 PS5, Line 785: csb_patcher "seabios" "32351" "6" "a2ceeaf" "728e934b2fb040d20862dcb74b532931cdded28f00fd130a0d5af92617ab880a" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@790 PS5, Line 790: csb_patcher "cfgsb" "33885" "1" "2c8f496" "67a7717376d529c8156b65de873009bc82a4a8732694466622ee3caabf8bd6d4" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@795 PS5, Line 795: csb_patcher "config.lenovo_g505s" "32352" "15" "823097e" "490383f694b736cd371b32d65f53014ebe5ac9f2f265bffbe1a5ede7607aa476" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@800 PS5, Line 800: csb_patcher "config.asus_am1i-a" "33800" "2" "881b7bb" "6e8a14ebdce055ab81cb28affbcebda94c47c2cee26e5166690699d4f6a99052" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@807 PS5, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@810 PS5, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@862 PS5, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@863 PS5, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/5/csb_patcher.sh@883 PS5, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#6).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 898 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/6
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 6:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@24 PS6, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@188 PS6, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@212 PS6, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@227 PS6, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@240 PS6, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@248 PS6, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@250 PS6, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@255 PS6, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@267 PS6, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@268 PS6, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@276 PS6, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@292 PS6, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@299 PS6, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@302 PS6, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@305 PS6, Line 305: floppy_verifier "michalos" "139e9d08881f646156971a0a061972ddca77057b8acf4164e36366271ab3658c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@313 PS6, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@320 PS6, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@325 PS6, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@331 PS6, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@335 PS6, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@347 PS6, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@353 PS6, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@355 PS6, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@359 PS6, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@374 PS6, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@381 PS6, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@384 PS6, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@385 PS6, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@388 PS6, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@389 PS6, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@392 PS6, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@397 PS6, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@398 PS6, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@413 PS6, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@430 PS6, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@431 PS6, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@432 PS6, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@433 PS6, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@434 PS6, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@435 PS6, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@465 PS6, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@470 PS6, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@538 PS6, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@665 PS6, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@666 PS6, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@669 PS6, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@729 PS6, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@731 PS6, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@746 PS6, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@748 PS6, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@754 PS6, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@770 PS6, Line 770: csb_patcher "dgpu" "33874" "1" "890eb4d" "4d653376488804262210e9fdd6f9e300a4c86c3b0084ee8fab2e0e2f6afec057" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@775 PS6, Line 775: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@780 PS6, Line 780: csb_patcher "tint" "33887" "1" "66aec99" "928a5bd51c3731368b1ce7b65e759caf50316ab3fa0da8c336c9aae13736399f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@785 PS6, Line 785: csb_patcher "seabios" "32351" "6" "a2ceeaf" "728e934b2fb040d20862dcb74b532931cdded28f00fd130a0d5af92617ab880a" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@790 PS6, Line 790: csb_patcher "cfgsb" "33885" "1" "2c8f496" "67a7717376d529c8156b65de873009bc82a4a8732694466622ee3caabf8bd6d4" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@795 PS6, Line 795: csb_patcher "config.lenovo_g505s" "32352" "15" "823097e" "490383f694b736cd371b32d65f53014ebe5ac9f2f265bffbe1a5ede7607aa476" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@800 PS6, Line 800: csb_patcher "config.asus_am1i-a" "33800" "2" "881b7bb" "6e8a14ebdce055ab81cb28affbcebda94c47c2cee26e5166690699d4f6a99052" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@807 PS6, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@810 PS6, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@862 PS6, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@863 PS6, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/6/csb_patcher.sh@883 PS6, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#7).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 899 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/7
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 7:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@24 PS7, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@188 PS7, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@212 PS7, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@227 PS7, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@240 PS7, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@248 PS7, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@250 PS7, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@255 PS7, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@267 PS7, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@268 PS7, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@276 PS7, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@292 PS7, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@299 PS7, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@302 PS7, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@305 PS7, Line 305: floppy_verifier "michalos" "749b12bfb9e93db2061097eafd6f3e5e83072cfaa943c10b74680dd62d5a589f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@313 PS7, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@320 PS7, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@325 PS7, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@331 PS7, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@335 PS7, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@347 PS7, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@353 PS7, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@355 PS7, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@359 PS7, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@374 PS7, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@381 PS7, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@384 PS7, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@385 PS7, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@388 PS7, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@389 PS7, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@392 PS7, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@397 PS7, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@398 PS7, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@413 PS7, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@430 PS7, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@431 PS7, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@432 PS7, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@433 PS7, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@434 PS7, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@435 PS7, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@465 PS7, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@470 PS7, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@538 PS7, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@665 PS7, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@666 PS7, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@669 PS7, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@729 PS7, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@731 PS7, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@746 PS7, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@748 PS7, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@754 PS7, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@770 PS7, Line 770: csb_patcher "dgpu" "33874" "3" "d2408e6" "749989156590010e79174c8256f8b9d82254d5f16f538f3a9fae09da55b6d163" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@775 PS7, Line 775: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@780 PS7, Line 780: csb_patcher "tint" "33887" "1" "66aec99" "928a5bd51c3731368b1ce7b65e759caf50316ab3fa0da8c336c9aae13736399f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@785 PS7, Line 785: csb_patcher "seabios" "32351" "6" "a2ceeaf" "728e934b2fb040d20862dcb74b532931cdded28f00fd130a0d5af92617ab880a" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@790 PS7, Line 790: csb_patcher "cfgsb" "33885" "3" "2b2052d" "2313a21b83367f2640275339b4ccb8f93407f01bf6da3fd0cb6b2ec2c47fd237" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@795 PS7, Line 795: csb_patcher "config.lenovo_g505s" "32352" "17" "4e8ce39" "d96b8a7110bf914e2abfac237aeca8299b773ce2d2e2d037ef7c8f4fef1bcc70" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@800 PS7, Line 800: csb_patcher "config.asus_am1i-a" "33800" "4" "6a7ce97" "cb112b5f572ef509e2b89f222f094adfeb0224cd2ddabe0f783bc8ed5d645ca5" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@807 PS7, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@810 PS7, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@862 PS7, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@863 PS7, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@883 PS7, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 7:
(8 comments)
https://review.coreboot.org/c/coreboot/+/33509/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33509/7//COMMIT_MSG@29 PS7, Line 29: ./csb_patcher.sh Maybe move it into util/scripts or make a new directory under util for it? It won't get merged into the coreboot root directory.
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@10 PS7, Line 10: Add a license?
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@34 PS7, Line 34: printf "${bred}TERMINATED${bend}\n" Here's what I'm using in my scripts. This avoids all the shellcheck warnings.
_echo_color() { local color if [[ -z ${NOCOLOR} ]]; then color="$1" else unset NC fi local text=$2 local cr=$3
if [[ -z ${cr} ]]; then printf "${color}%s${NC}\n" "${text}" else printf "${color}%s${NC}" "${text}" fi }
_echo_debug() { if [[ -z ${VERBOSE} ]]; then return fi printf "${ORANGERED}%s${NC}\n" "$2" >&2 }
_echo_error() { (_echo_color >&2 "${RED}" "$*") }
then just:
_echo_color "${bred}" "TERMINATED"
I have a command line argument to run the scripts without color codes - that's where the ${NOCOLOR} gets set. obviously my ${NC} is the same as your ${bend}.
Feel free to use this or ignore it. I'll give you under whatever license you prefer.
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@79 PS7, Line 79: else : return 0 : fi Get rid of the else? This does the same thing. Same pattern below.
fi return 0
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@172 PS7, Line 172: ! -z -n?
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@277 PS7, Line 277: floppy_mass_downloader () Move to a separate script? This isn't really related to doing patches, and would be useful by itself.
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@279 PS7, Line 279: "./floppies/" payloads/floppies? 3rdparty/flopppies?
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@765 PS7, Line 765: csb_mass_patcher Instead of hardcoding these, it would be good to maybe pull them from a patch. It would be nice to be able to supply that patch on the command line, although defaulting something that points to your patchlist is fine, IMO.
That way this script would be useful other people's patch sets as well.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 7:
(2 comments)
Martin, thank you very much for your great ideas and suggestions - I'll try my best to implement them after I'll return from a vacation. Wish you to have a great time as well ;-)
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@277 PS7, Line 277: floppy_mass_downloader ()
Move to a separate script? This isn't really related to doing patches, and would be useful by itsel […]
After my return I'm going to work more on SeaBIOS "multiple_floppies" patch, and - after it gets merged successfully - could integrate this floppy part into coreboot's configuration menu, similar to "Secondary payloads". Until this time I'm a bit hesitant about moving, although could copy it (with its' dependencies) into a separate script.
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@765 PS7, Line 765: csb_mass_patcher
Instead of hardcoding these, it would be good to maybe pull them from a patch. […]
Although some things can't be pulled (i.e. SHA256), things like a diff filename - definitely could. Hope it can be done efficiently without adding many code lines (to keep this script smaller than 1k). I'll also try to create some interface for using this script with a different patches / patch sets, to make it more useful for the fellow coreboot'ers.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 8:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@24 PS8, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@188 PS8, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@212 PS8, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@227 PS8, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@240 PS8, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@248 PS8, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@250 PS8, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@255 PS8, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@267 PS8, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@268 PS8, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@276 PS8, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@292 PS8, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@299 PS8, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@302 PS8, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@305 PS8, Line 305: floppy_verifier "michalos" "749b12bfb9e93db2061097eafd6f3e5e83072cfaa943c10b74680dd62d5a589f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@313 PS8, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@320 PS8, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@325 PS8, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@331 PS8, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@335 PS8, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@347 PS8, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@353 PS8, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@355 PS8, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@359 PS8, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@374 PS8, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@381 PS8, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@384 PS8, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@385 PS8, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@388 PS8, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@389 PS8, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@392 PS8, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@397 PS8, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@398 PS8, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@413 PS8, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@430 PS8, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@431 PS8, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@432 PS8, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@433 PS8, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@434 PS8, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@435 PS8, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@465 PS8, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@470 PS8, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@538 PS8, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@665 PS8, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@666 PS8, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@669 PS8, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@729 PS8, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@731 PS8, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@746 PS8, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@748 PS8, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@754 PS8, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@770 PS8, Line 770: csb_patcher "dgpu" "33874" "3" "d2408e6" "749989156590010e79174c8256f8b9d82254d5f16f538f3a9fae09da55b6d163" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@775 PS8, Line 775: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@780 PS8, Line 780: csb_patcher "tint" "33887" "1" "66aec99" "928a5bd51c3731368b1ce7b65e759caf50316ab3fa0da8c336c9aae13736399f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@785 PS8, Line 785: csb_patcher "seabios" "32351" "6" "a2ceeaf" "728e934b2fb040d20862dcb74b532931cdded28f00fd130a0d5af92617ab880a" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@790 PS8, Line 790: csb_patcher "cfgsb" "33885" "3" "2b2052d" "2313a21b83367f2640275339b4ccb8f93407f01bf6da3fd0cb6b2ec2c47fd237" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@795 PS8, Line 795: csb_patcher "config.lenovo_g505s" "32352" "17" "4e8ce39" "d96b8a7110bf914e2abfac237aeca8299b773ce2d2e2d037ef7c8f4fef1bcc70" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@800 PS8, Line 800: csb_patcher "config.asus_am1i-a" "33800" "4" "6a7ce97" "cb112b5f572ef509e2b89f222f094adfeb0224cd2ddabe0f783bc8ed5d645ca5" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@807 PS8, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@810 PS8, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@862 PS8, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@863 PS8, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/8/csb_patcher.sh@883 PS8, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#9).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 899 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/9
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 9:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@24 PS9, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@188 PS9, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@212 PS9, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@227 PS9, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@240 PS9, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@248 PS9, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@250 PS9, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@255 PS9, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@267 PS9, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@268 PS9, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@276 PS9, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@292 PS9, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@299 PS9, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@302 PS9, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@305 PS9, Line 305: floppy_verifier "michalos" "749b12bfb9e93db2061097eafd6f3e5e83072cfaa943c10b74680dd62d5a589f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@313 PS9, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@320 PS9, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@325 PS9, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@331 PS9, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@335 PS9, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@347 PS9, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@353 PS9, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@355 PS9, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@359 PS9, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@374 PS9, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@381 PS9, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@384 PS9, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@385 PS9, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@388 PS9, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@389 PS9, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@392 PS9, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@397 PS9, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@398 PS9, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@413 PS9, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@430 PS9, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@431 PS9, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@432 PS9, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@433 PS9, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@434 PS9, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@435 PS9, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@465 PS9, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@470 PS9, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@538 PS9, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@665 PS9, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@666 PS9, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@669 PS9, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@729 PS9, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@731 PS9, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@746 PS9, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@748 PS9, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@754 PS9, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@770 PS9, Line 770: csb_patcher "dgpu" "33874" "5" "56e0323" "d59b8e295caf35a27a6f7d52250b16be030eae629ddd300bfd27875e83724666" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@775 PS9, Line 775: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@780 PS9, Line 780: csb_patcher "tint" "33887" "1" "66aec99" "928a5bd51c3731368b1ce7b65e759caf50316ab3fa0da8c336c9aae13736399f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@785 PS9, Line 785: csb_patcher "seabios" "32351" "6" "a2ceeaf" "728e934b2fb040d20862dcb74b532931cdded28f00fd130a0d5af92617ab880a" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@790 PS9, Line 790: csb_patcher "cfgsb" "33885" "3" "2b2052d" "2313a21b83367f2640275339b4ccb8f93407f01bf6da3fd0cb6b2ec2c47fd237" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@795 PS9, Line 795: csb_patcher "config.lenovo_g505s" "32352" "17" "4e8ce39" "d96b8a7110bf914e2abfac237aeca8299b773ce2d2e2d037ef7c8f4fef1bcc70" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@800 PS9, Line 800: csb_patcher "config.asus_am1i-a" "33800" "4" "6a7ce97" "cb112b5f572ef509e2b89f222f094adfeb0224cd2ddabe0f783bc8ed5d645ca5" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@807 PS9, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@810 PS9, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@862 PS9, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@863 PS9, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/9/csb_patcher.sh@883 PS9, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 10:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@24 PS10, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@188 PS10, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@212 PS10, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@227 PS10, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@240 PS10, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@248 PS10, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@250 PS10, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@255 PS10, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@267 PS10, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@268 PS10, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@276 PS10, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@292 PS10, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@299 PS10, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@302 PS10, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@305 PS10, Line 305: floppy_verifier "michalos" "749b12bfb9e93db2061097eafd6f3e5e83072cfaa943c10b74680dd62d5a589f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@313 PS10, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@320 PS10, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@325 PS10, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@331 PS10, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@335 PS10, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@347 PS10, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@353 PS10, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@355 PS10, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@359 PS10, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@374 PS10, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@381 PS10, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@384 PS10, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@385 PS10, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@388 PS10, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@389 PS10, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@392 PS10, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@397 PS10, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@398 PS10, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@413 PS10, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@430 PS10, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@431 PS10, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@432 PS10, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@433 PS10, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@434 PS10, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@435 PS10, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@465 PS10, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@470 PS10, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@538 PS10, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@665 PS10, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@666 PS10, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@669 PS10, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@729 PS10, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@731 PS10, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@746 PS10, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@748 PS10, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@754 PS10, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@770 PS10, Line 770: csb_patcher "dgpu" "33874" "5" "56e0323" "d59b8e295caf35a27a6f7d52250b16be030eae629ddd300bfd27875e83724666" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@775 PS10, Line 775: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@780 PS10, Line 780: csb_patcher "tint" "33887" "1" "66aec99" "928a5bd51c3731368b1ce7b65e759caf50316ab3fa0da8c336c9aae13736399f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@785 PS10, Line 785: csb_patcher "seabios" "32351" "6" "a2ceeaf" "728e934b2fb040d20862dcb74b532931cdded28f00fd130a0d5af92617ab880a" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@790 PS10, Line 790: csb_patcher "cfgsb" "33885" "3" "2b2052d" "2313a21b83367f2640275339b4ccb8f93407f01bf6da3fd0cb6b2ec2c47fd237" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@795 PS10, Line 795: csb_patcher "config.lenovo_g505s" "32352" "17" "4e8ce39" "d96b8a7110bf914e2abfac237aeca8299b773ce2d2e2d037ef7c8f4fef1bcc70" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@800 PS10, Line 800: csb_patcher "config.asus_am1i-a" "33800" "4" "6a7ce97" "cb112b5f572ef509e2b89f222f094adfeb0224cd2ddabe0f783bc8ed5d645ca5" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@807 PS10, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@810 PS10, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@862 PS10, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@863 PS10, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/10/csb_patcher.sh@883 PS10, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#11).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 899 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/11
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 11:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@24 PS11, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@188 PS11, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@212 PS11, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@227 PS11, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@240 PS11, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@248 PS11, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@250 PS11, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@255 PS11, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@267 PS11, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@268 PS11, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@276 PS11, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@292 PS11, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@299 PS11, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@302 PS11, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@305 PS11, Line 305: floppy_verifier "michalos" "3e072552bcb39fffc4ed8c2e144cfecb6b98f90046e82a3690801a1bd3befcf9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@313 PS11, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@320 PS11, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@325 PS11, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@331 PS11, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@335 PS11, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@347 PS11, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@353 PS11, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@355 PS11, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@359 PS11, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@374 PS11, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@381 PS11, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@384 PS11, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@385 PS11, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@388 PS11, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@389 PS11, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@392 PS11, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@397 PS11, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@398 PS11, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@413 PS11, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@430 PS11, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@431 PS11, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@432 PS11, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@433 PS11, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@434 PS11, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@435 PS11, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@465 PS11, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@470 PS11, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@538 PS11, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@665 PS11, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@666 PS11, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@669 PS11, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@729 PS11, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@731 PS11, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@746 PS11, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@748 PS11, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@754 PS11, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@770 PS11, Line 770: csb_patcher "dgpu" "33874" "7" "7dedf37" "9f681dfa7874a9bd34778749f2405c14ea786e8a515957557536f11f0fbb2ba3" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@775 PS11, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@780 PS11, Line 780: csb_patcher "tint" "33887" "2" "9c8151d" "6a389277d4d741ea09186f4fbb1960f0a39e40385192a3dadc244d1c590d5733" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@785 PS11, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@790 PS11, Line 790: csb_patcher "cfgsb" "33885" "4" "bae2957" "1da3da1d963e6c39dcc210787102919cb72752ac51065e41a176adc2980bdcb1" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@795 PS11, Line 795: csb_patcher "config.lenovo_g505s" "32352" "19" "7ceb7d3" "5995047bc87ea430ecfd62f1c47f5b9aada88030284f357b21cc2124a727d6da" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@800 PS11, Line 800: csb_patcher "config.asus_am1i-a" "33800" "6" "2a5b377" "c59aa95c54f1e6f17d48d0751049a242015e46d2a66b3c995849639ba8bbb750" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@807 PS11, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@810 PS11, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@862 PS11, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@863 PS11, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/11/csb_patcher.sh@883 PS11, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 11:
This is a small (but urgent) maintenance update: although without your good proposals yet, I haven't forgot about them...
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 12:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@24 PS12, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@188 PS12, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@212 PS12, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@227 PS12, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@240 PS12, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@248 PS12, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@250 PS12, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@255 PS12, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@267 PS12, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@268 PS12, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@276 PS12, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@292 PS12, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@299 PS12, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@302 PS12, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@305 PS12, Line 305: floppy_verifier "michalos" "3e072552bcb39fffc4ed8c2e144cfecb6b98f90046e82a3690801a1bd3befcf9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@313 PS12, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@320 PS12, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@325 PS12, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@331 PS12, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@335 PS12, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@347 PS12, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@353 PS12, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@355 PS12, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@359 PS12, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@374 PS12, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@381 PS12, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@384 PS12, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@385 PS12, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@388 PS12, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@389 PS12, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@392 PS12, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@397 PS12, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@398 PS12, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@413 PS12, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@430 PS12, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@431 PS12, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@432 PS12, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@433 PS12, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@434 PS12, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@435 PS12, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@465 PS12, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@470 PS12, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@538 PS12, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@665 PS12, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@666 PS12, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@669 PS12, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@729 PS12, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@731 PS12, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@746 PS12, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@748 PS12, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@754 PS12, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@770 PS12, Line 770: csb_patcher "dgpu" "33874" "7" "7dedf37" "9f681dfa7874a9bd34778749f2405c14ea786e8a515957557536f11f0fbb2ba3" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@775 PS12, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@780 PS12, Line 780: csb_patcher "tint" "33887" "2" "9c8151d" "6a389277d4d741ea09186f4fbb1960f0a39e40385192a3dadc244d1c590d5733" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@785 PS12, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@790 PS12, Line 790: csb_patcher "cfgsb" "33885" "4" "bae2957" "1da3da1d963e6c39dcc210787102919cb72752ac51065e41a176adc2980bdcb1" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@795 PS12, Line 795: csb_patcher "config.lenovo_g505s" "32352" "19" "7ceb7d3" "5995047bc87ea430ecfd62f1c47f5b9aada88030284f357b21cc2124a727d6da" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@800 PS12, Line 800: csb_patcher "config.asus_am1i-a" "33800" "6" "2a5b377" "c59aa95c54f1e6f17d48d0751049a242015e46d2a66b3c995849639ba8bbb750" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@807 PS12, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@810 PS12, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@862 PS12, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@863 PS12, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/12/csb_patcher.sh@883 PS12, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#13).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 899 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/13
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 13:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@24 PS13, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@188 PS13, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@212 PS13, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@227 PS13, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@240 PS13, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@248 PS13, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@250 PS13, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@255 PS13, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@267 PS13, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@268 PS13, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@276 PS13, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@292 PS13, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@299 PS13, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@302 PS13, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@305 PS13, Line 305: floppy_verifier "michalos" "3e072552bcb39fffc4ed8c2e144cfecb6b98f90046e82a3690801a1bd3befcf9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@313 PS13, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@320 PS13, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@325 PS13, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@331 PS13, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@335 PS13, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@347 PS13, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@353 PS13, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@355 PS13, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@359 PS13, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@374 PS13, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@381 PS13, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@384 PS13, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@385 PS13, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@388 PS13, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@389 PS13, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@392 PS13, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@397 PS13, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@398 PS13, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@413 PS13, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@430 PS13, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@431 PS13, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@432 PS13, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@433 PS13, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@434 PS13, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@435 PS13, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@465 PS13, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@470 PS13, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@538 PS13, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@665 PS13, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@666 PS13, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@669 PS13, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@729 PS13, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@731 PS13, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@746 PS13, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@748 PS13, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@754 PS13, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@770 PS13, Line 770: csb_patcher "dgpu" "33874" "9" "f2c9c43" "2678af3d581fd11bc425baa10db3052ce21a925f87afae1b4c5416793e71135c" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@775 PS13, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@780 PS13, Line 780: csb_patcher "tint" "33887" "2" "9c8151d" "6a389277d4d741ea09186f4fbb1960f0a39e40385192a3dadc244d1c590d5733" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@785 PS13, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@790 PS13, Line 790: csb_patcher "cfgsb" "33885" "4" "bae2957" "1da3da1d963e6c39dcc210787102919cb72752ac51065e41a176adc2980bdcb1" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@795 PS13, Line 795: csb_patcher "config.lenovo_g505s" "32352" "21" "aa0fb53" "4187a0529aa61298ea0a4955f6781a9ca8387b47e5cd2864a68c0d60d51ceb13" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@800 PS13, Line 800: csb_patcher "config.asus_am1i-a" "33800" "8" "8cb58f0" "a305be7c5b0485cb1255e714253b3adb3c937d070d6d853e5881d48fb82bfe70" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@807 PS13, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@810 PS13, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@862 PS13, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@863 PS13, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/13/csb_patcher.sh@883 PS13, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 14:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@24 PS14, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@188 PS14, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@212 PS14, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@227 PS14, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@240 PS14, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@248 PS14, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@250 PS14, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@255 PS14, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@267 PS14, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@268 PS14, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@276 PS14, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@292 PS14, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@299 PS14, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@302 PS14, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@305 PS14, Line 305: floppy_verifier "michalos" "3e072552bcb39fffc4ed8c2e144cfecb6b98f90046e82a3690801a1bd3befcf9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@313 PS14, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@320 PS14, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@325 PS14, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@331 PS14, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@335 PS14, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@347 PS14, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@353 PS14, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@355 PS14, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@359 PS14, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@374 PS14, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@381 PS14, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@384 PS14, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@385 PS14, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@388 PS14, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@389 PS14, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@392 PS14, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@397 PS14, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@398 PS14, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@413 PS14, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@430 PS14, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@431 PS14, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@432 PS14, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@433 PS14, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@434 PS14, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@435 PS14, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@465 PS14, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@470 PS14, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@538 PS14, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@665 PS14, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@666 PS14, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@669 PS14, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@729 PS14, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@731 PS14, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@746 PS14, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@748 PS14, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@754 PS14, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@770 PS14, Line 770: csb_patcher "dgpu" "33874" "9" "f2c9c43" "2678af3d581fd11bc425baa10db3052ce21a925f87afae1b4c5416793e71135c" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@775 PS14, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@780 PS14, Line 780: csb_patcher "tint" "33887" "2" "9c8151d" "6a389277d4d741ea09186f4fbb1960f0a39e40385192a3dadc244d1c590d5733" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@785 PS14, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@790 PS14, Line 790: csb_patcher "cfgsb" "33885" "4" "bae2957" "1da3da1d963e6c39dcc210787102919cb72752ac51065e41a176adc2980bdcb1" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@795 PS14, Line 795: csb_patcher "config.lenovo_g505s" "32352" "21" "aa0fb53" "4187a0529aa61298ea0a4955f6781a9ca8387b47e5cd2864a68c0d60d51ceb13" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@800 PS14, Line 800: csb_patcher "config.asus_am1i-a" "33800" "8" "8cb58f0" "a305be7c5b0485cb1255e714253b3adb3c937d070d6d853e5881d48fb82bfe70" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@807 PS14, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@810 PS14, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@862 PS14, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@863 PS14, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/14/csb_patcher.sh@883 PS14, Line 883: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#15).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 900 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/15
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 15:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@24 PS15, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@188 PS15, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@212 PS15, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@227 PS15, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@240 PS15, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@248 PS15, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@250 PS15, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@255 PS15, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@267 PS15, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@268 PS15, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@276 PS15, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@292 PS15, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@299 PS15, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@302 PS15, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@305 PS15, Line 305: floppy_verifier "michalos" "3e072552bcb39fffc4ed8c2e144cfecb6b98f90046e82a3690801a1bd3befcf9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@313 PS15, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@320 PS15, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@325 PS15, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@331 PS15, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@335 PS15, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@347 PS15, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@353 PS15, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@355 PS15, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@359 PS15, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@374 PS15, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@381 PS15, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@384 PS15, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@385 PS15, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@388 PS15, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@389 PS15, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@392 PS15, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@397 PS15, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@398 PS15, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@413 PS15, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@430 PS15, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@431 PS15, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@432 PS15, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@433 PS15, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@434 PS15, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@435 PS15, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@465 PS15, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@470 PS15, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@538 PS15, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@665 PS15, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@666 PS15, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@669 PS15, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@729 PS15, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@731 PS15, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@746 PS15, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@748 PS15, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@754 PS15, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@770 PS15, Line 770: csb_patcher "dgpu" "33874" "9" "f2c9c43" "2678af3d581fd11bc425baa10db3052ce21a925f87afae1b4c5416793e71135c" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@775 PS15, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@780 PS15, Line 780: csb_patcher "tint" "33887" "2" "9c8151d" "6a389277d4d741ea09186f4fbb1960f0a39e40385192a3dadc244d1c590d5733" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@785 PS15, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@790 PS15, Line 790: csb_patcher "cfgsb" "33885" "4" "bae2957" "1da3da1d963e6c39dcc210787102919cb72752ac51065e41a176adc2980bdcb1" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@795 PS15, Line 795: csb_patcher "config.lenovo_g505s" "32352" "23" "f3c8d2f" "f0e9356e5a9a53b21d0c9d1eb02b1d77c3df1f3dd8fe53a20f8c705174dc4e08" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@800 PS15, Line 800: csb_patcher "config.asus_am1i-a" "33800" "10" "4e30e79" "6448388921b8171d163a0a0d8fd4b4cd824325934ceae9a9dde2123538de6466" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@807 PS15, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@810 PS15, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@862 PS15, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@863 PS15, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/15/csb_patcher.sh@884 PS15, Line 884: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 16:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@24 PS16, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@188 PS16, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@212 PS16, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@227 PS16, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@240 PS16, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@248 PS16, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@250 PS16, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@255 PS16, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@267 PS16, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@268 PS16, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@276 PS16, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@292 PS16, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@299 PS16, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@302 PS16, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@305 PS16, Line 305: floppy_verifier "michalos" "3e072552bcb39fffc4ed8c2e144cfecb6b98f90046e82a3690801a1bd3befcf9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@313 PS16, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@320 PS16, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@325 PS16, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@331 PS16, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@335 PS16, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@347 PS16, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@353 PS16, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@355 PS16, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@359 PS16, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@374 PS16, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@381 PS16, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@384 PS16, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@385 PS16, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@388 PS16, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@389 PS16, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@392 PS16, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@397 PS16, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@398 PS16, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@413 PS16, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@430 PS16, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@431 PS16, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@432 PS16, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@433 PS16, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@434 PS16, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@435 PS16, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@465 PS16, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@470 PS16, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@538 PS16, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@665 PS16, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@666 PS16, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@669 PS16, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@729 PS16, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@731 PS16, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@746 PS16, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@748 PS16, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@754 PS16, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@770 PS16, Line 770: csb_patcher "dgpu" "33874" "9" "f2c9c43" "2678af3d581fd11bc425baa10db3052ce21a925f87afae1b4c5416793e71135c" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@775 PS16, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@780 PS16, Line 780: csb_patcher "tint" "33887" "2" "9c8151d" "6a389277d4d741ea09186f4fbb1960f0a39e40385192a3dadc244d1c590d5733" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@785 PS16, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@790 PS16, Line 790: csb_patcher "cfgsb" "33885" "4" "bae2957" "1da3da1d963e6c39dcc210787102919cb72752ac51065e41a176adc2980bdcb1" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@795 PS16, Line 795: csb_patcher "config.lenovo_g505s" "32352" "23" "f3c8d2f" "f0e9356e5a9a53b21d0c9d1eb02b1d77c3df1f3dd8fe53a20f8c705174dc4e08" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@800 PS16, Line 800: csb_patcher "config.asus_am1i-a" "33800" "10" "4e30e79" "6448388921b8171d163a0a0d8fd4b4cd824325934ceae9a9dde2123538de6466" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@807 PS16, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@810 PS16, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@862 PS16, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@863 PS16, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/16/csb_patcher.sh@884 PS16, Line 884: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#17).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 900 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/17
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 17:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@24 PS17, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@188 PS17, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@212 PS17, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@227 PS17, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@240 PS17, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@248 PS17, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@250 PS17, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@255 PS17, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@267 PS17, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@268 PS17, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@276 PS17, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@292 PS17, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@299 PS17, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@302 PS17, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@305 PS17, Line 305: floppy_verifier "michalos" "3e072552bcb39fffc4ed8c2e144cfecb6b98f90046e82a3690801a1bd3befcf9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@313 PS17, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@320 PS17, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@325 PS17, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@331 PS17, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@335 PS17, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@347 PS17, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@353 PS17, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@355 PS17, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@359 PS17, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@374 PS17, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@381 PS17, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@384 PS17, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@385 PS17, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@388 PS17, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@389 PS17, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@392 PS17, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@397 PS17, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@398 PS17, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@413 PS17, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@430 PS17, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@431 PS17, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@432 PS17, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@433 PS17, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@434 PS17, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@435 PS17, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@465 PS17, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@470 PS17, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@538 PS17, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@665 PS17, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@666 PS17, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@669 PS17, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@729 PS17, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@731 PS17, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@746 PS17, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@748 PS17, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@754 PS17, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@770 PS17, Line 770: csb_patcher "dgpu" "33874" "11" "913e43b" "030c808a8406ebbf39fc9385aa4f1165daa117a7e20a3edc71c4173664a4a83c" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@775 PS17, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@780 PS17, Line 780: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@785 PS17, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@790 PS17, Line 790: csb_patcher "cfgsb" "33885" "6" "1b99901" "366733cbcf4f5afc4c3528152cef48c41ec2a36d6dc0799162e9e7c6539f9803" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@795 PS17, Line 795: csb_patcher "config.lenovo_g505s" "32352" "25" "a8356ee" "fc7f674f1d295b6d6120accdeb95336240ef287f8eb428a9c3e90bc52c4751ad" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@800 PS17, Line 800: csb_patcher "config.asus_am1i-a" "33800" "12" "82d20e3" "426d7c6e3412a2040b4fb093c52d8cd97a42886640d43e838cdeb9debcb3ec82" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@807 PS17, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@810 PS17, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@862 PS17, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@863 PS17, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/17/csb_patcher.sh@884 PS17, Line 884: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 18:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@24 PS18, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@188 PS18, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@212 PS18, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@227 PS18, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@240 PS18, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@248 PS18, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@250 PS18, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@255 PS18, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@267 PS18, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@268 PS18, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@276 PS18, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@292 PS18, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@299 PS18, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@302 PS18, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@305 PS18, Line 305: floppy_verifier "michalos" "3e072552bcb39fffc4ed8c2e144cfecb6b98f90046e82a3690801a1bd3befcf9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@313 PS18, Line 313: floppy_verifier "fiwix" "dbec2994ec619c9954327ab0b983ab24cd362406a2e515c35c79c79bd6417cfd" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@320 PS18, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@325 PS18, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@331 PS18, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@335 PS18, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@347 PS18, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@353 PS18, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@355 PS18, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@359 PS18, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@374 PS18, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@381 PS18, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@384 PS18, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@385 PS18, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@388 PS18, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@389 PS18, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@392 PS18, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@397 PS18, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@398 PS18, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@413 PS18, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@430 PS18, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@431 PS18, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@432 PS18, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@433 PS18, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@434 PS18, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@435 PS18, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@465 PS18, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@470 PS18, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@538 PS18, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@665 PS18, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@666 PS18, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@669 PS18, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@729 PS18, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@731 PS18, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@746 PS18, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@748 PS18, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@754 PS18, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@770 PS18, Line 770: csb_patcher "dgpu" "33874" "11" "913e43b" "030c808a8406ebbf39fc9385aa4f1165daa117a7e20a3edc71c4173664a4a83c" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@775 PS18, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@780 PS18, Line 780: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@785 PS18, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@790 PS18, Line 790: csb_patcher "cfgsb" "33885" "6" "1b99901" "366733cbcf4f5afc4c3528152cef48c41ec2a36d6dc0799162e9e7c6539f9803" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@795 PS18, Line 795: csb_patcher "config.lenovo_g505s" "32352" "25" "a8356ee" "fc7f674f1d295b6d6120accdeb95336240ef287f8eb428a9c3e90bc52c4751ad" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@800 PS18, Line 800: csb_patcher "config.asus_am1i-a" "33800" "12" "82d20e3" "426d7c6e3412a2040b4fb093c52d8cd97a42886640d43e838cdeb9debcb3ec82" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@807 PS18, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@810 PS18, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@862 PS18, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@863 PS18, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/18/csb_patcher.sh@884 PS18, Line 884: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#19).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 900 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/19
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 19:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@24 PS19, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@188 PS19, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@212 PS19, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@227 PS19, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@240 PS19, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@248 PS19, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@250 PS19, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@255 PS19, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@267 PS19, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@268 PS19, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@276 PS19, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@292 PS19, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@299 PS19, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@302 PS19, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@305 PS19, Line 305: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@313 PS19, Line 313: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@320 PS19, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@325 PS19, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@331 PS19, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@335 PS19, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@347 PS19, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@353 PS19, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@355 PS19, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@359 PS19, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@374 PS19, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@381 PS19, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@384 PS19, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@385 PS19, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@388 PS19, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@389 PS19, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@392 PS19, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@397 PS19, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@398 PS19, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@413 PS19, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@430 PS19, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@431 PS19, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@432 PS19, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@433 PS19, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@434 PS19, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@435 PS19, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@465 PS19, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@470 PS19, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@538 PS19, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@665 PS19, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@666 PS19, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@669 PS19, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@729 PS19, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@731 PS19, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@746 PS19, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@748 PS19, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@754 PS19, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@770 PS19, Line 770: csb_patcher "dgpu" "39873" "1" "5d02314" "a2777ad60b3654e85f807b69cdefa34edecd83a8231e79aeb575fbb98d43876b" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@775 PS19, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@780 PS19, Line 780: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@785 PS19, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@790 PS19, Line 790: csb_patcher "cfgsb" "33885" "6" "1b99901" "366733cbcf4f5afc4c3528152cef48c41ec2a36d6dc0799162e9e7c6539f9803" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@795 PS19, Line 795: csb_patcher "config.lenovo_g505s" "32352" "25" "a8356ee" "fc7f674f1d295b6d6120accdeb95336240ef287f8eb428a9c3e90bc52c4751ad" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@800 PS19, Line 800: csb_patcher "config.asus_am1i-a" "33800" "12" "82d20e3" "426d7c6e3412a2040b4fb093c52d8cd97a42886640d43e838cdeb9debcb3ec82" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@807 PS19, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@810 PS19, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@862 PS19, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@863 PS19, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/19/csb_patcher.sh@884 PS19, Line 884: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#20).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 900 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/20
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 20:
(63 comments)
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@24 PS20, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@188 PS20, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@212 PS20, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@227 PS20, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@240 PS20, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@248 PS20, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@250 PS20, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@255 PS20, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@267 PS20, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@268 PS20, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@276 PS20, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@292 PS20, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@299 PS20, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@302 PS20, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@305 PS20, Line 305: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@313 PS20, Line 313: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@320 PS20, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@325 PS20, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@331 PS20, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@335 PS20, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@347 PS20, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@353 PS20, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@355 PS20, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@359 PS20, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@374 PS20, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@381 PS20, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@384 PS20, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@385 PS20, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@388 PS20, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@389 PS20, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@392 PS20, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@397 PS20, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@398 PS20, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@413 PS20, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@430 PS20, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@431 PS20, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@432 PS20, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@433 PS20, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@434 PS20, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@435 PS20, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@465 PS20, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@470 PS20, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@538 PS20, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@665 PS20, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@666 PS20, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@669 PS20, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@729 PS20, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@731 PS20, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@746 PS20, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@748 PS20, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@754 PS20, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@770 PS20, Line 770: csb_patcher "dgpu" "39873" "1" "5d02314" "a2777ad60b3654e85f807b69cdefa34edecd83a8231e79aeb575fbb98d43876b" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@775 PS20, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@780 PS20, Line 780: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@785 PS20, Line 785: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@790 PS20, Line 790: csb_patcher "cfgsb" "33885" "6" "1b99901" "366733cbcf4f5afc4c3528152cef48c41ec2a36d6dc0799162e9e7c6539f9803" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@795 PS20, Line 795: csb_patcher "config.lenovo_g505s" "32352" "27" "702719a" "602e2af959fc4fc8118011da015f822d652d35e3f7247bf071ad62681e8748f9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@800 PS20, Line 800: csb_patcher "config.asus_am1i-a" "33800" "14" "6005dc8" "42721152756649d6f30b1e7a0e6a169a322cc2df808ea6cd8e90b53c8f46c4eb" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@807 PS20, Line 807: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@810 PS20, Line 810: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@862 PS20, Line 862: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@863 PS20, Line 863: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/20/csb_patcher.sh@884 PS20, Line 884: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#21).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 910 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/21
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 21:
(65 comments)
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@24 PS21, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@188 PS21, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@212 PS21, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@227 PS21, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@240 PS21, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@248 PS21, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@250 PS21, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@255 PS21, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@267 PS21, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@268 PS21, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@276 PS21, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@292 PS21, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@299 PS21, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@302 PS21, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@305 PS21, Line 305: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@313 PS21, Line 313: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@320 PS21, Line 320: floppy_verifier "memtest" "364535abd0d105da9396df6015e480c4d4c52b07dcc4e1d4756bde8ef87a30f1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@325 PS21, Line 325: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@331 PS21, Line 331: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@335 PS21, Line 335: floppy_verifier "floppybird" "5db1b469e25e9eda7b8c0f666d6b655bab083c85618a9453ee72f1201cca840f" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@347 PS21, Line 347: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@353 PS21, Line 353: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@355 PS21, Line 355: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@359 PS21, Line 359: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@374 PS21, Line 374: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@381 PS21, Line 381: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@384 PS21, Line 384: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@385 PS21, Line 385: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@388 PS21, Line 388: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@389 PS21, Line 389: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@392 PS21, Line 392: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@397 PS21, Line 397: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@398 PS21, Line 398: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@413 PS21, Line 413: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@430 PS21, Line 430: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@431 PS21, Line 431: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@432 PS21, Line 432: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@433 PS21, Line 433: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@434 PS21, Line 434: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@435 PS21, Line 435: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@465 PS21, Line 465: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@470 PS21, Line 470: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@538 PS21, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@665 PS21, Line 665: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@666 PS21, Line 666: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@669 PS21, Line 669: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@729 PS21, Line 729: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@731 PS21, Line 731: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@746 PS21, Line 746: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@748 PS21, Line 748: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@754 PS21, Line 754: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@770 PS21, Line 770: csb_patcher "dgpu" "39873" "1" "5d02314" "a2777ad60b3654e85f807b69cdefa34edecd83a8231e79aeb575fbb98d43876b" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@775 PS21, Line 775: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@780 PS21, Line 780: csb_patcher "A88XM-E" "30987" "47" "e392063" "c9cd4361e9894f1efca28fbd6848f4a913a9d24ace980bbf70d7dcd002aa4faf" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@785 PS21, Line 785: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@790 PS21, Line 790: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@795 PS21, Line 795: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@800 PS21, Line 800: csb_patcher "config.lenovo_g505s" "32352" "27" "702719a" "602e2af959fc4fc8118011da015f822d652d35e3f7247bf071ad62681e8748f9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@805 PS21, Line 805: csb_patcher "config.asus_am1i-a" "33800" "14" "6005dc8" "42721152756649d6f30b1e7a0e6a169a322cc2df808ea6cd8e90b53c8f46c4eb" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@810 PS21, Line 810: csb_patcher "config.asus_a88xm-e" "39900" "1" "61c9d6d" "e45e25227e38389bebea12b975657689b5e1cf74b5d1907d7223355d4455130b" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@817 PS21, Line 817: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@820 PS21, Line 820: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@872 PS21, Line 872: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@873 PS21, Line 873: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/21/csb_patcher.sh@894 PS21, Line 894: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#22).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": G505S dGPU support, G505S and AM1I-A configs, AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 921 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/22
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 22:
(65 comments)
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@24 PS22, Line 24: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@188 PS22, Line 188: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@212 PS22, Line 212: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@227 PS22, Line 227: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@240 PS22, Line 240: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@248 PS22, Line 248: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@250 PS22, Line 250: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@255 PS22, Line 255: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@267 PS22, Line 267: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@268 PS22, Line 268: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@276 PS22, Line 276: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@292 PS22, Line 292: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@299 PS22, Line 299: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@302 PS22, Line 302: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@305 PS22, Line 305: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@313 PS22, Line 313: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@317 PS22, Line 317: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@322 PS22, Line 322: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@328 PS22, Line 328: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@332 PS22, Line 332: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@344 PS22, Line 344: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@350 PS22, Line 350: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@352 PS22, Line 352: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@356 PS22, Line 356: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@371 PS22, Line 371: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@378 PS22, Line 378: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@381 PS22, Line 381: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@382 PS22, Line 382: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@385 PS22, Line 385: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@386 PS22, Line 386: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@389 PS22, Line 389: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@394 PS22, Line 394: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@395 PS22, Line 395: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@410 PS22, Line 410: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@427 PS22, Line 427: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@428 PS22, Line 428: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@429 PS22, Line 429: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@430 PS22, Line 430: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@431 PS22, Line 431: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@432 PS22, Line 432: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@462 PS22, Line 462: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@467 PS22, Line 467: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@538 PS22, Line 538: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@674 PS22, Line 674: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@675 PS22, Line 675: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@678 PS22, Line 678: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@738 PS22, Line 738: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@740 PS22, Line 740: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@755 PS22, Line 755: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@757 PS22, Line 757: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@763 PS22, Line 763: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@779 PS22, Line 779: csb_patcher "dgpu" "39873" "1" "5d02314" "a2777ad60b3654e85f807b69cdefa34edecd83a8231e79aeb575fbb98d43876b" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@784 PS22, Line 784: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@789 PS22, Line 789: csb_patcher "A88XM-E" "30987" "47" "e392063" "c9cd4361e9894f1efca28fbd6848f4a913a9d24ace980bbf70d7dcd002aa4faf" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@794 PS22, Line 794: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@799 PS22, Line 799: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@804 PS22, Line 804: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@809 PS22, Line 809: csb_patcher "config.lenovo_g505s" "32352" "27" "702719a" "602e2af959fc4fc8118011da015f822d652d35e3f7247bf071ad62681e8748f9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@814 PS22, Line 814: csb_patcher "config.asus_am1i-a" "33800" "14" "6005dc8" "42721152756649d6f30b1e7a0e6a169a322cc2df808ea6cd8e90b53c8f46c4eb" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@819 PS22, Line 819: csb_patcher "config.asus_a88xm-e" "39900" "1" "61c9d6d" "e45e25227e38389bebea12b975657689b5e1cf74b5d1907d7223355d4455130b" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@826 PS22, Line 826: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@829 PS22, Line 829: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@882 PS22, Line 882: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@883 PS22, Line 883: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/22/csb_patcher.sh@905 PS22, Line 905: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#23).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S dGPU support, ASUS A88XM-E board support, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/23
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 23:
(65 comments)
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@26 PS23, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@190 PS23, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@214 PS23, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@229 PS23, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@242 PS23, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@250 PS23, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@252 PS23, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@257 PS23, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@269 PS23, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@270 PS23, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@278 PS23, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@294 PS23, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@301 PS23, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@304 PS23, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@307 PS23, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@315 PS23, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@319 PS23, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@324 PS23, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@330 PS23, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@334 PS23, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@346 PS23, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@352 PS23, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@354 PS23, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@358 PS23, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@373 PS23, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@380 PS23, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@383 PS23, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@384 PS23, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@387 PS23, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@388 PS23, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@391 PS23, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@396 PS23, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@397 PS23, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@412 PS23, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@429 PS23, Line 429: csb_patcher "atombios" "33886" "1" "0687d68" "c4cc7de2ee48ed28fe6d1067aa5151f579f9ea7b58213b8e45da17720dc8e1e7" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@430 PS23, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@431 PS23, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@432 PS23, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@433 PS23, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@434 PS23, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@464 PS23, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@469 PS23, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@540 PS23, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@676 PS23, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@677 PS23, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@680 PS23, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@740 PS23, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@742 PS23, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@757 PS23, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@759 PS23, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@765 PS23, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@781 PS23, Line 781: csb_patcher "dgpu" "39873" "1" "5d02314" "a2777ad60b3654e85f807b69cdefa34edecd83a8231e79aeb575fbb98d43876b" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@786 PS23, Line 786: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@791 PS23, Line 791: csb_patcher "A88XM-E" "30987" "47" "e392063" "c9cd4361e9894f1efca28fbd6848f4a913a9d24ace980bbf70d7dcd002aa4faf" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@796 PS23, Line 796: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@801 PS23, Line 801: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@806 PS23, Line 806: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@811 PS23, Line 811: csb_patcher "config.lenovo_g505s" "32352" "27" "702719a" "602e2af959fc4fc8118011da015f822d652d35e3f7247bf071ad62681e8748f9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@816 PS23, Line 816: csb_patcher "config.asus_am1i-a" "33800" "14" "6005dc8" "42721152756649d6f30b1e7a0e6a169a322cc2df808ea6cd8e90b53c8f46c4eb" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@821 PS23, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "1" "61c9d6d" "e45e25227e38389bebea12b975657689b5e1cf74b5d1907d7223355d4455130b" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@828 PS23, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@831 PS23, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@884 PS23, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@885 PS23, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/23/csb_patcher.sh@907 PS23, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 23:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@10 PS7, Line 10:
Add a license?
Done.
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@34 PS7, Line 34: printf "${bred}TERMINATED${bend}\n"
Here's what I'm using in my scripts. This avoids all the shellcheck warnings. […]
Thank you for your alternative variant. However I have some doubts about its' portability - [[ ]] is a bash'ism if I recall it correctly - and I'm trying to write this script as portable as possible, to work at max number of different shells. At the same time, I like the idea of a custom function encapsulating the ${NC} etc., I would borrow it if will need more colored and different prints.
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@79 PS7, Line 79: else : return 0 : fi
Get rid of the else? This does the same thing. Same pattern below. […]
else is just in case I need to quickly insert a custom code to it, also like that both return lines are at the same offset.
https://review.coreboot.org/c/coreboot/+/33509/7/csb_patcher.sh@172 PS7, Line 172: ! -z
-n?
From one hand, -n is indeed better (it's a good idea to avoid ! if possible), but from the other hand: it's easy to memorize that -z means zero, while -n is a bit ambiguous: it means "not null" but easy to confuse with "null" if you don't spend much time in bash for a while.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#24).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S dGPU support, ASUS A88XM-E board support, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 928 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/24
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 24:
(67 comments)
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@26 PS24, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@190 PS24, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@214 PS24, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@229 PS24, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@242 PS24, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@250 PS24, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@252 PS24, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@257 PS24, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@269 PS24, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@270 PS24, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@278 PS24, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@294 PS24, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@301 PS24, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@304 PS24, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@307 PS24, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@315 PS24, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@319 PS24, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@324 PS24, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@330 PS24, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@334 PS24, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@346 PS24, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@352 PS24, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@354 PS24, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@358 PS24, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@373 PS24, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@380 PS24, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@383 PS24, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@384 PS24, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@387 PS24, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@388 PS24, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@391 PS24, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@396 PS24, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@397 PS24, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@412 PS24, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@429 PS24, Line 429: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@430 PS24, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@431 PS24, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@432 PS24, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@433 PS24, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@434 PS24, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@464 PS24, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@469 PS24, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@540 PS24, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@673 PS24, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@676 PS24, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@677 PS24, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@680 PS24, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@740 PS24, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@742 PS24, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@757 PS24, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@759 PS24, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@765 PS24, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@781 PS24, Line 781: csb_patcher "dgpu" "39873" "1" "5d02314" "a2777ad60b3654e85f807b69cdefa34edecd83a8231e79aeb575fbb98d43876b" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@786 PS24, Line 786: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@791 PS24, Line 791: csb_patcher "BottomIo" "38472" "5" "bfbf646" "cf2b402e23bf1169c1245e05d97b14897bc8106c37d3c45577530639245593ae" "$1" "forAMDdGPU " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@796 PS24, Line 796: csb_patcher "A88XM-E" "30987" "47" "e392063" "c9cd4361e9894f1efca28fbd6848f4a913a9d24ace980bbf70d7dcd002aa4faf" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@801 PS24, Line 801: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@806 PS24, Line 806: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@811 PS24, Line 811: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@816 PS24, Line 816: csb_patcher "config.lenovo_g505s" "32352" "27" "702719a" "602e2af959fc4fc8118011da015f822d652d35e3f7247bf071ad62681e8748f9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@821 PS24, Line 821: csb_patcher "config.asus_am1i-a" "33800" "14" "6005dc8" "42721152756649d6f30b1e7a0e6a169a322cc2df808ea6cd8e90b53c8f46c4eb" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@826 PS24, Line 826: csb_patcher "config.asus_a88xm-e" "39900" "1" "61c9d6d" "e45e25227e38389bebea12b975657689b5e1cf74b5d1907d7223355d4455130b" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@833 PS24, Line 833: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@836 PS24, Line 836: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@889 PS24, Line 889: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@890 PS24, Line 890: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/24/csb_patcher.sh@912 PS24, Line 912: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#25).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S dGPU support, ASUS A88XM-E board support, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 933 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/25
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 25:
(69 comments)
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@26 PS25, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@190 PS25, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@214 PS25, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@229 PS25, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@242 PS25, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@250 PS25, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@252 PS25, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@257 PS25, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@269 PS25, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@270 PS25, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@278 PS25, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@294 PS25, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@301 PS25, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@304 PS25, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@307 PS25, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@315 PS25, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@319 PS25, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@324 PS25, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@330 PS25, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@334 PS25, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@346 PS25, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@352 PS25, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@354 PS25, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@358 PS25, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@373 PS25, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@380 PS25, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@383 PS25, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@384 PS25, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@387 PS25, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@388 PS25, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@391 PS25, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@396 PS25, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@397 PS25, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@412 PS25, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@429 PS25, Line 429: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@430 PS25, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@431 PS25, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@432 PS25, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@433 PS25, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@434 PS25, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@464 PS25, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@469 PS25, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@540 PS25, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@672 PS25, Line 672: if [ "$1" = "dgpu" ] || [ "$1" = "atombios" ] || [ "$1" = "BottomIo" ] || [ "$1" = "xmp" ] || \ line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@673 PS25, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@676 PS25, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@677 PS25, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@680 PS25, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@740 PS25, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@742 PS25, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@757 PS25, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@759 PS25, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@765 PS25, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@781 PS25, Line 781: csb_patcher "dgpu" "39873" "1" "5d02314" "a2777ad60b3654e85f807b69cdefa34edecd83a8231e79aeb575fbb98d43876b" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@786 PS25, Line 786: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@791 PS25, Line 791: csb_patcher "BottomIo" "38472" "5" "bfbf646" "cf2b402e23bf1169c1245e05d97b14897bc8106c37d3c45577530639245593ae" "$1" "forAMDdGPU " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@796 PS25, Line 796: csb_patcher "xmp" "40495" "1" "bccd9bd" "6ee3807f08f3f904fef31b75219bca6e28f4cf5d29e79c17abe30a5b61741dc6" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@801 PS25, Line 801: csb_patcher "A88XM-E" "30987" "47" "e392063" "c9cd4361e9894f1efca28fbd6848f4a913a9d24ace980bbf70d7dcd002aa4faf" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@806 PS25, Line 806: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@811 PS25, Line 811: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@816 PS25, Line 816: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@821 PS25, Line 821: csb_patcher "config.lenovo_g505s" "32352" "27" "702719a" "602e2af959fc4fc8118011da015f822d652d35e3f7247bf071ad62681e8748f9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@826 PS25, Line 826: csb_patcher "config.asus_am1i-a" "33800" "14" "6005dc8" "42721152756649d6f30b1e7a0e6a169a322cc2df808ea6cd8e90b53c8f46c4eb" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@831 PS25, Line 831: csb_patcher "config.asus_a88xm-e" "39900" "1" "61c9d6d" "e45e25227e38389bebea12b975657689b5e1cf74b5d1907d7223355d4455130b" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@838 PS25, Line 838: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@841 PS25, Line 841: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@894 PS25, Line 894: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@895 PS25, Line 895: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@917 PS25, Line 917: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#26).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S dGPU support, ASUS A88XM-E board support, example configs for G505S / AM1I-A / A88XM-E, known good AtomBIOS ROMs and XMP / custom timings support for all the AMD boards with opensource AGESA
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 928 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/26
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 26:
(67 comments)
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@26 PS26, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@190 PS26, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@214 PS26, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@229 PS26, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@242 PS26, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@250 PS26, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@252 PS26, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@257 PS26, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@269 PS26, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@270 PS26, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@278 PS26, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@294 PS26, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@301 PS26, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@304 PS26, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@307 PS26, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@315 PS26, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@319 PS26, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@324 PS26, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@330 PS26, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@334 PS26, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@346 PS26, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@352 PS26, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@354 PS26, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@358 PS26, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@373 PS26, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@380 PS26, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@383 PS26, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@384 PS26, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@387 PS26, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@388 PS26, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@391 PS26, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@396 PS26, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@397 PS26, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@412 PS26, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@429 PS26, Line 429: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@430 PS26, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@431 PS26, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@432 PS26, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@433 PS26, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@434 PS26, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@464 PS26, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@469 PS26, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@540 PS26, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@673 PS26, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@676 PS26, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@677 PS26, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@680 PS26, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@740 PS26, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@742 PS26, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@757 PS26, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@759 PS26, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@765 PS26, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@781 PS26, Line 781: csb_patcher "dgpu" "39873" "2" "0022560" "fe21ffea4601deea958aba002e7527deabec6709057eb76d0a1f64d8e211c397" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@786 PS26, Line 786: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@791 PS26, Line 791: csb_patcher "xmp" "40495" "1" "bccd9bd" "6ee3807f08f3f904fef31b75219bca6e28f4cf5d29e79c17abe30a5b61741dc6" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@796 PS26, Line 796: csb_patcher "A88XM-E" "30987" "47" "e392063" "c9cd4361e9894f1efca28fbd6848f4a913a9d24ace980bbf70d7dcd002aa4faf" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@801 PS26, Line 801: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@806 PS26, Line 806: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@811 PS26, Line 811: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@816 PS26, Line 816: csb_patcher "config.lenovo_g505s" "32352" "27" "702719a" "602e2af959fc4fc8118011da015f822d652d35e3f7247bf071ad62681e8748f9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@821 PS26, Line 821: csb_patcher "config.asus_am1i-a" "33800" "14" "6005dc8" "42721152756649d6f30b1e7a0e6a169a322cc2df808ea6cd8e90b53c8f46c4eb" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@826 PS26, Line 826: csb_patcher "config.asus_a88xm-e" "39900" "1" "61c9d6d" "e45e25227e38389bebea12b975657689b5e1cf74b5d1907d7223355d4455130b" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@833 PS26, Line 833: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@836 PS26, Line 836: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@889 PS26, Line 889: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@890 PS26, Line 890: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/26/csb_patcher.sh@912 PS26, Line 912: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#27).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S dGPU support, ASUS A88XM-E board support, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 928 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/27
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 27:
(67 comments)
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@26 PS27, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@190 PS27, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@214 PS27, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@229 PS27, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@242 PS27, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@250 PS27, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@252 PS27, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@257 PS27, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@269 PS27, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@270 PS27, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@278 PS27, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@294 PS27, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@301 PS27, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@304 PS27, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@307 PS27, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@315 PS27, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@319 PS27, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@324 PS27, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@330 PS27, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@334 PS27, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@346 PS27, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@352 PS27, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@354 PS27, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@358 PS27, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@373 PS27, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@380 PS27, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@383 PS27, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@384 PS27, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@387 PS27, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@388 PS27, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@391 PS27, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@396 PS27, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@397 PS27, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@412 PS27, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@429 PS27, Line 429: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@430 PS27, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@431 PS27, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@432 PS27, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@433 PS27, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@434 PS27, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@464 PS27, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@469 PS27, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@540 PS27, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@673 PS27, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@676 PS27, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@677 PS27, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@680 PS27, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@740 PS27, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@742 PS27, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@757 PS27, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@759 PS27, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@765 PS27, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@781 PS27, Line 781: csb_patcher "dgpu" "39873" "2" "0022560" "fe21ffea4601deea958aba002e7527deabec6709057eb76d0a1f64d8e211c397" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@786 PS27, Line 786: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@791 PS27, Line 791: csb_patcher "xmp" "40495" "1" "bccd9bd" "6ee3807f08f3f904fef31b75219bca6e28f4cf5d29e79c17abe30a5b61741dc6" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@796 PS27, Line 796: csb_patcher "A88XM-E" "30987" "47" "e392063" "c9cd4361e9894f1efca28fbd6848f4a913a9d24ace980bbf70d7dcd002aa4faf" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@801 PS27, Line 801: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@806 PS27, Line 806: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@811 PS27, Line 811: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@816 PS27, Line 816: csb_patcher "config.lenovo_g505s" "32352" "28" "0a9b3a5" "da840b16efa8ba7b75f379715d4e71a5903d66a7f814ee27bd01acd32a605b66" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@821 PS27, Line 821: csb_patcher "config.asus_am1i-a" "33800" "15" "47d1cc8" "bae22ebb3afe862e68d1c3e14073e7b780aed054818b0c25f634619850def216" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@826 PS27, Line 826: csb_patcher "config.asus_a88xm-e" "39900" "2" "3185174" "cc66e40d46fc7f4b334f7ee9e26f778c27090aa1f7c592b5c365dec3372932de" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@833 PS27, Line 833: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@836 PS27, Line 836: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@889 PS27, Line 889: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@890 PS27, Line 890: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/27/csb_patcher.sh@912 PS27, Line 912: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#28).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S dGPU support, ASUS A88XM-E board support, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 928 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/28
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 28:
(67 comments)
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@26 PS28, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@190 PS28, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@214 PS28, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@229 PS28, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@242 PS28, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@250 PS28, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@252 PS28, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@257 PS28, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@269 PS28, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@270 PS28, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@278 PS28, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@294 PS28, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@301 PS28, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@304 PS28, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@307 PS28, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@315 PS28, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@319 PS28, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@324 PS28, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@330 PS28, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@334 PS28, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@346 PS28, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@352 PS28, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@354 PS28, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@358 PS28, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@373 PS28, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@380 PS28, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@383 PS28, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@384 PS28, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@387 PS28, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@388 PS28, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@391 PS28, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@396 PS28, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@397 PS28, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@412 PS28, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@429 PS28, Line 429: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@430 PS28, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@431 PS28, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@432 PS28, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@433 PS28, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@434 PS28, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@464 PS28, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@469 PS28, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@540 PS28, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@673 PS28, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@676 PS28, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@677 PS28, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@680 PS28, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@740 PS28, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@742 PS28, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@757 PS28, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@759 PS28, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@765 PS28, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@781 PS28, Line 781: csb_patcher "dgpu" "39873" "2" "0022560" "fe21ffea4601deea958aba002e7527deabec6709057eb76d0a1f64d8e211c397" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@786 PS28, Line 786: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@791 PS28, Line 791: csb_patcher "xmp" "40495" "1" "bccd9bd" "6ee3807f08f3f904fef31b75219bca6e28f4cf5d29e79c17abe30a5b61741dc6" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@796 PS28, Line 796: csb_patcher "A88XM-E" "30987" "52" "e5504b0" "55a07039565561921073d843709099e448a9fb9f1d3fd3f7cb1a2e68e2bbe14a" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@801 PS28, Line 801: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@806 PS28, Line 806: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@811 PS28, Line 811: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@816 PS28, Line 816: csb_patcher "config.lenovo_g505s" "32352" "28" "0a9b3a5" "da840b16efa8ba7b75f379715d4e71a5903d66a7f814ee27bd01acd32a605b66" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@821 PS28, Line 821: csb_patcher "config.asus_am1i-a" "33800" "15" "47d1cc8" "bae22ebb3afe862e68d1c3e14073e7b780aed054818b0c25f634619850def216" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@826 PS28, Line 826: csb_patcher "config.asus_a88xm-e" "39900" "2" "3185174" "cc66e40d46fc7f4b334f7ee9e26f778c27090aa1f7c592b5c365dec3372932de" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@833 PS28, Line 833: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@836 PS28, Line 836: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@889 PS28, Line 889: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@890 PS28, Line 890: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/28/csb_patcher.sh@912 PS28, Line 912: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#29).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S dGPU support, ASUS A88XM-E board support, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 928 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/29
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 29:
(67 comments)
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@26 PS29, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@190 PS29, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@214 PS29, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@229 PS29, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@242 PS29, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@250 PS29, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@252 PS29, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@257 PS29, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@269 PS29, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@270 PS29, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@278 PS29, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@294 PS29, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@301 PS29, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@304 PS29, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@307 PS29, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@315 PS29, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@319 PS29, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@324 PS29, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@330 PS29, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@334 PS29, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@346 PS29, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@352 PS29, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@354 PS29, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@358 PS29, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@373 PS29, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@380 PS29, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@383 PS29, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@384 PS29, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@387 PS29, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@388 PS29, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@391 PS29, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@396 PS29, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@397 PS29, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@412 PS29, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@429 PS29, Line 429: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@430 PS29, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@431 PS29, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@432 PS29, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@433 PS29, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@434 PS29, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@464 PS29, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@469 PS29, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@540 PS29, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@673 PS29, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@676 PS29, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@677 PS29, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@680 PS29, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@740 PS29, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@742 PS29, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@757 PS29, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@759 PS29, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@765 PS29, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@781 PS29, Line 781: csb_patcher "dgpu" "39873" "3" "7eddd64" "600f01261e9125db2fd8398d432a505b778bb8b0f5b89c0405e2d67f56739b81" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@786 PS29, Line 786: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@791 PS29, Line 791: csb_patcher "xmp" "40495" "1" "bccd9bd" "6ee3807f08f3f904fef31b75219bca6e28f4cf5d29e79c17abe30a5b61741dc6" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@796 PS29, Line 796: csb_patcher "A88XM-E" "30987" "52" "e5504b0" "55a07039565561921073d843709099e448a9fb9f1d3fd3f7cb1a2e68e2bbe14a" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@801 PS29, Line 801: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@806 PS29, Line 806: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@811 PS29, Line 811: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@816 PS29, Line 816: csb_patcher "config.lenovo_g505s" "32352" "28" "0a9b3a5" "da840b16efa8ba7b75f379715d4e71a5903d66a7f814ee27bd01acd32a605b66" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@821 PS29, Line 821: csb_patcher "config.asus_am1i-a" "33800" "15" "47d1cc8" "bae22ebb3afe862e68d1c3e14073e7b780aed054818b0c25f634619850def216" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@826 PS29, Line 826: csb_patcher "config.asus_a88xm-e" "39900" "2" "3185174" "cc66e40d46fc7f4b334f7ee9e26f778c27090aa1f7c592b5c365dec3372932de" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@833 PS29, Line 833: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@836 PS29, Line 836: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@889 PS29, Line 889: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@890 PS29, Line 890: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/29/csb_patcher.sh@912 PS29, Line 912: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 30:
(67 comments)
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@26 PS30, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@190 PS30, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@214 PS30, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@229 PS30, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@242 PS30, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@250 PS30, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@252 PS30, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@257 PS30, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@269 PS30, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@270 PS30, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@278 PS30, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@294 PS30, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@301 PS30, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@304 PS30, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@307 PS30, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@315 PS30, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@319 PS30, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@324 PS30, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@330 PS30, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@334 PS30, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@346 PS30, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@352 PS30, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@354 PS30, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@358 PS30, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@373 PS30, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@380 PS30, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@383 PS30, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@384 PS30, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@387 PS30, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@388 PS30, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@391 PS30, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@396 PS30, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@397 PS30, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@412 PS30, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@429 PS30, Line 429: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@430 PS30, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@431 PS30, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@432 PS30, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@433 PS30, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@434 PS30, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@464 PS30, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@469 PS30, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@540 PS30, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@673 PS30, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@676 PS30, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@677 PS30, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@680 PS30, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@740 PS30, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@742 PS30, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@757 PS30, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@759 PS30, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@765 PS30, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@781 PS30, Line 781: csb_patcher "dgpu" "39873" "3" "7eddd64" "600f01261e9125db2fd8398d432a505b778bb8b0f5b89c0405e2d67f56739b81" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@786 PS30, Line 786: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@791 PS30, Line 791: csb_patcher "xmp" "40495" "1" "bccd9bd" "6ee3807f08f3f904fef31b75219bca6e28f4cf5d29e79c17abe30a5b61741dc6" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@796 PS30, Line 796: csb_patcher "A88XM-E" "30987" "52" "e5504b0" "55a07039565561921073d843709099e448a9fb9f1d3fd3f7cb1a2e68e2bbe14a" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@801 PS30, Line 801: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@806 PS30, Line 806: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@811 PS30, Line 811: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@816 PS30, Line 816: csb_patcher "config.lenovo_g505s" "32352" "28" "0a9b3a5" "da840b16efa8ba7b75f379715d4e71a5903d66a7f814ee27bd01acd32a605b66" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@821 PS30, Line 821: csb_patcher "config.asus_am1i-a" "33800" "15" "47d1cc8" "bae22ebb3afe862e68d1c3e14073e7b780aed054818b0c25f634619850def216" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@826 PS30, Line 826: csb_patcher "config.asus_a88xm-e" "39900" "2" "3185174" "cc66e40d46fc7f4b334f7ee9e26f778c27090aa1f7c592b5c365dec3372932de" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@833 PS30, Line 833: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@836 PS30, Line 836: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@889 PS30, Line 889: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@890 PS30, Line 890: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/30/csb_patcher.sh@912 PS30, Line 912: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#31).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S dGPU support, ASUS A88XM-E board support, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also XMP / custom RAM timings support for all the AMD AGESA boards
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 928 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/31
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 31:
(67 comments)
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@26 PS31, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@190 PS31, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@214 PS31, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@229 PS31, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@242 PS31, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@250 PS31, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@252 PS31, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@257 PS31, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@269 PS31, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@270 PS31, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@278 PS31, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@294 PS31, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@301 PS31, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@304 PS31, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@307 PS31, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@315 PS31, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@319 PS31, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@324 PS31, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@330 PS31, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@334 PS31, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@346 PS31, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@352 PS31, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@354 PS31, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@358 PS31, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@373 PS31, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@380 PS31, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@383 PS31, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@384 PS31, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@387 PS31, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@388 PS31, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@391 PS31, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@396 PS31, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@397 PS31, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@412 PS31, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@429 PS31, Line 429: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@430 PS31, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@431 PS31, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@432 PS31, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@433 PS31, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@434 PS31, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@464 PS31, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@469 PS31, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@540 PS31, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@673 PS31, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@676 PS31, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@677 PS31, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@680 PS31, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@740 PS31, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@742 PS31, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@757 PS31, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@759 PS31, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@765 PS31, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@781 PS31, Line 781: csb_patcher "dgpu" "39873" "3" "7eddd64" "600f01261e9125db2fd8398d432a505b778bb8b0f5b89c0405e2d67f56739b81" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@786 PS31, Line 786: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@791 PS31, Line 791: csb_patcher "xmp" "40495" "1" "bccd9bd" "6ee3807f08f3f904fef31b75219bca6e28f4cf5d29e79c17abe30a5b61741dc6" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@796 PS31, Line 796: csb_patcher "A88XM-E" "30987" "80" "84b273a" "4508ba562c1e76e61c3e0c1673e172a24c2eebe92eb8b353ac0ed9d3e1458d38" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@801 PS31, Line 801: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@806 PS31, Line 806: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@811 PS31, Line 811: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@816 PS31, Line 816: csb_patcher "config.lenovo_g505s" "32352" "30" "f6fb93c" "b3a40483e5b8d13feafc96485ab8db8702d4087f1bee531d8f90c68857b76374" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@821 PS31, Line 821: csb_patcher "config.asus_am1i-a" "33800" "17" "8c6dbab" "e7d1d2b6a329161660542954c856f7b54b8db4520994b3450a47cd8fb00abb26" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@826 PS31, Line 826: csb_patcher "config.asus_a88xm-e" "39900" "4" "7c3332b" "6318af01827e01a235e82aecfdb5346655ff5af4d01f308dadc81c065646549f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@833 PS31, Line 833: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@836 PS31, Line 836: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@889 PS31, Line 889: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@890 PS31, Line 890: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/31/csb_patcher.sh@912 PS31, Line 912: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 32:
(67 comments)
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@26 PS32, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@190 PS32, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@214 PS32, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@229 PS32, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@242 PS32, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@250 PS32, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@252 PS32, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@257 PS32, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@269 PS32, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@270 PS32, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@278 PS32, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@294 PS32, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@301 PS32, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@304 PS32, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@307 PS32, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@315 PS32, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@319 PS32, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@324 PS32, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@330 PS32, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@334 PS32, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@346 PS32, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@352 PS32, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@354 PS32, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@358 PS32, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@373 PS32, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@380 PS32, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@383 PS32, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@384 PS32, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@387 PS32, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@388 PS32, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@391 PS32, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@396 PS32, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@397 PS32, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@412 PS32, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@429 PS32, Line 429: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@430 PS32, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@431 PS32, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@432 PS32, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@433 PS32, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@434 PS32, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@464 PS32, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@469 PS32, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@540 PS32, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@673 PS32, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@676 PS32, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@677 PS32, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@680 PS32, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@740 PS32, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@742 PS32, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@757 PS32, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@759 PS32, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@765 PS32, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@781 PS32, Line 781: csb_patcher "dgpu" "39873" "3" "7eddd64" "600f01261e9125db2fd8398d432a505b778bb8b0f5b89c0405e2d67f56739b81" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@786 PS32, Line 786: csb_patcher "atombios" "33886" "2" "6339853" "5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@791 PS32, Line 791: csb_patcher "xmp" "40495" "1" "bccd9bd" "6ee3807f08f3f904fef31b75219bca6e28f4cf5d29e79c17abe30a5b61741dc6" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@796 PS32, Line 796: csb_patcher "A88XM-E" "30987" "80" "84b273a" "4508ba562c1e76e61c3e0c1673e172a24c2eebe92eb8b353ac0ed9d3e1458d38" "$1" "Asus " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@801 PS32, Line 801: csb_patcher "tint" "33887" "3" "d11508d" "f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@806 PS32, Line 806: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@811 PS32, Line 811: csb_patcher "cfgsb" "39899" "1" "39e9bde" "16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@816 PS32, Line 816: csb_patcher "config.lenovo_g505s" "32352" "30" "f6fb93c" "b3a40483e5b8d13feafc96485ab8db8702d4087f1bee531d8f90c68857b76374" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@821 PS32, Line 821: csb_patcher "config.asus_am1i-a" "33800" "17" "8c6dbab" "e7d1d2b6a329161660542954c856f7b54b8db4520994b3450a47cd8fb00abb26" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@826 PS32, Line 826: csb_patcher "config.asus_a88xm-e" "39900" "4" "7c3332b" "6318af01827e01a235e82aecfdb5346655ff5af4d01f308dadc81c065646549f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@833 PS32, Line 833: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@836 PS32, Line 836: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@889 PS32, Line 889: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@890 PS32, Line 890: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/32/csb_patcher.sh@912 PS32, Line 912: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#33).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S dGPU support, ASUS A88XM-E board support, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also XMP / custom RAM timings support for all the AMD AGESA boards
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/33
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 33:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@26 PS33, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@190 PS33, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@214 PS33, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@229 PS33, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@242 PS33, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@250 PS33, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@252 PS33, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@257 PS33, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@269 PS33, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@270 PS33, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@278 PS33, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@294 PS33, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@301 PS33, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@304 PS33, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@307 PS33, Line 307: floppy_verifier "michalos" "dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@315 PS33, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@319 PS33, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@324 PS33, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@330 PS33, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@334 PS33, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@346 PS33, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@352 PS33, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@354 PS33, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@358 PS33, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@373 PS33, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@380 PS33, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@383 PS33, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@384 PS33, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@387 PS33, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@388 PS33, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@391 PS33, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@396 PS33, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@397 PS33, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@412 PS33, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@429 PS33, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@430 PS33, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@431 PS33, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@432 PS33, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@433 PS33, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@434 PS33, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@464 PS33, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@469 PS33, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@540 PS33, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@673 PS33, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@676 PS33, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@677 PS33, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@680 PS33, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@740 PS33, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@742 PS33, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@757 PS33, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@759 PS33, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@765 PS33, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@781 PS33, Line 781: csb_patcher "dgpu" "39873" "5" "760e2ac" "26ba303f88935d1cc3e70374972389663ab3930987ddcea0c05f37bc1ecdcba9" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@786 PS33, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@791 PS33, Line 791: csb_patcher "xmp" "40495" "3" "7ddcecd" "27e711f0fed2912e24d7cd0dbe7f865d2ef75e1b068d985b7b8a181e61d3865f" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@796 PS33, Line 796: csb_patcher "tint" "44582" "1" "e4ab099" "495392b76f40c1f19cc3f99606c8ab042b1c901ddcefc7ee40362ce6fca3adef" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@801 PS33, Line 801: csb_patcher "seabios" "32351" "7" "ff6f8a6" "d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@806 PS33, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@811 PS33, Line 811: csb_patcher "config.lenovo_g505s" "32352" "30" "f6fb93c" "b3a40483e5b8d13feafc96485ab8db8702d4087f1bee531d8f90c68857b76374" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@816 PS33, Line 816: csb_patcher "config.asus_am1i-a" "33800" "17" "8c6dbab" "e7d1d2b6a329161660542954c856f7b54b8db4520994b3450a47cd8fb00abb26" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@821 PS33, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "4" "7c3332b" "6318af01827e01a235e82aecfdb5346655ff5af4d01f308dadc81c065646549f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@828 PS33, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@831 PS33, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@884 PS33, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@885 PS33, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/33/csb_patcher.sh@907 PS33, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#34).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also XMP / custom RAM timings support for all the AMD AGESA boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/34
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 34:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@26 PS34, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@190 PS34, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@214 PS34, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@229 PS34, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@242 PS34, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@250 PS34, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@252 PS34, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@257 PS34, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@269 PS34, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@270 PS34, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@278 PS34, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@294 PS34, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@301 PS34, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@304 PS34, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@307 PS34, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@315 PS34, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@319 PS34, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@324 PS34, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@330 PS34, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@334 PS34, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@346 PS34, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@352 PS34, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@354 PS34, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@358 PS34, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@373 PS34, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@380 PS34, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@383 PS34, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@384 PS34, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@387 PS34, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@388 PS34, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@391 PS34, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@396 PS34, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@397 PS34, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@412 PS34, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@429 PS34, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@430 PS34, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@431 PS34, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@432 PS34, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@433 PS34, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@434 PS34, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@464 PS34, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@469 PS34, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@540 PS34, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@673 PS34, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@676 PS34, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@677 PS34, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@680 PS34, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@740 PS34, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@742 PS34, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@757 PS34, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@759 PS34, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@765 PS34, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@781 PS34, Line 781: csb_patcher "dgpu" "39873" "5" "760e2ac" "26ba303f88935d1cc3e70374972389663ab3930987ddcea0c05f37bc1ecdcba9" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@786 PS34, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@791 PS34, Line 791: csb_patcher "xmp" "40495" "3" "7ddcecd" "27e711f0fed2912e24d7cd0dbe7f865d2ef75e1b068d985b7b8a181e61d3865f" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@796 PS34, Line 796: csb_patcher "tint" "44582" "1" "e4ab099" "495392b76f40c1f19cc3f99606c8ab042b1c901ddcefc7ee40362ce6fca3adef" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@801 PS34, Line 801: csb_patcher "seabios" "32351" "9" "772fa76" "2e4a553693feb212ff920645f2a082123e3bd86b1edefe52236934177d097171" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@806 PS34, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@811 PS34, Line 811: csb_patcher "config.lenovo_g505s" "32352" "30" "f6fb93c" "b3a40483e5b8d13feafc96485ab8db8702d4087f1bee531d8f90c68857b76374" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@816 PS34, Line 816: csb_patcher "config.asus_am1i-a" "33800" "17" "8c6dbab" "e7d1d2b6a329161660542954c856f7b54b8db4520994b3450a47cd8fb00abb26" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@821 PS34, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "4" "7c3332b" "6318af01827e01a235e82aecfdb5346655ff5af4d01f308dadc81c065646549f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@828 PS34, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@831 PS34, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@884 PS34, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@885 PS34, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/34/csb_patcher.sh@907 PS34, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#35).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also DDR3 XMP/custom_profile support for all the AMD AGESA boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/35
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 35:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@26 PS35, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@190 PS35, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@214 PS35, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@229 PS35, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@242 PS35, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@250 PS35, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@252 PS35, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@257 PS35, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@269 PS35, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@270 PS35, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@278 PS35, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@294 PS35, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@301 PS35, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@304 PS35, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@307 PS35, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@315 PS35, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@319 PS35, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@324 PS35, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@330 PS35, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@334 PS35, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@346 PS35, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@352 PS35, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@354 PS35, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@358 PS35, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@373 PS35, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@380 PS35, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@383 PS35, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@384 PS35, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@387 PS35, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@388 PS35, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@391 PS35, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@396 PS35, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@397 PS35, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@412 PS35, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@429 PS35, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@430 PS35, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@431 PS35, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@432 PS35, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@433 PS35, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@434 PS35, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@464 PS35, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@469 PS35, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@540 PS35, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@673 PS35, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@676 PS35, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@677 PS35, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@680 PS35, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@740 PS35, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@742 PS35, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@757 PS35, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@759 PS35, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@765 PS35, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@781 PS35, Line 781: csb_patcher "dgpu" "39873" "5" "760e2ac" "26ba303f88935d1cc3e70374972389663ab3930987ddcea0c05f37bc1ecdcba9" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@786 PS35, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@791 PS35, Line 791: csb_patcher "xmp" "40495" "4" "87051b2" "2fcbee1d6bc68107935a6ca0122852b2fe05a209cf9b5d4f065bf9281314dca1" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@796 PS35, Line 796: csb_patcher "tint" "44582" "1" "e4ab099" "495392b76f40c1f19cc3f99606c8ab042b1c901ddcefc7ee40362ce6fca3adef" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@801 PS35, Line 801: csb_patcher "seabios" "32351" "9" "772fa76" "2e4a553693feb212ff920645f2a082123e3bd86b1edefe52236934177d097171" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@806 PS35, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@811 PS35, Line 811: csb_patcher "config.lenovo_g505s" "32352" "30" "f6fb93c" "b3a40483e5b8d13feafc96485ab8db8702d4087f1bee531d8f90c68857b76374" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@816 PS35, Line 816: csb_patcher "config.asus_am1i-a" "33800" "17" "8c6dbab" "e7d1d2b6a329161660542954c856f7b54b8db4520994b3450a47cd8fb00abb26" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@821 PS35, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "4" "7c3332b" "6318af01827e01a235e82aecfdb5346655ff5af4d01f308dadc81c065646549f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@828 PS35, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@831 PS35, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@884 PS35, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@885 PS35, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/35/csb_patcher.sh@907 PS35, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 36:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@26 PS36, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@190 PS36, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@214 PS36, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@229 PS36, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@242 PS36, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@250 PS36, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@252 PS36, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@257 PS36, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@269 PS36, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@270 PS36, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@278 PS36, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@294 PS36, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@301 PS36, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@304 PS36, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@307 PS36, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@315 PS36, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@319 PS36, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@324 PS36, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@330 PS36, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@334 PS36, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@346 PS36, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@352 PS36, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@354 PS36, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@358 PS36, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@373 PS36, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@380 PS36, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@383 PS36, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@384 PS36, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@387 PS36, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@388 PS36, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@391 PS36, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@396 PS36, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@397 PS36, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@412 PS36, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@429 PS36, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@430 PS36, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@431 PS36, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@432 PS36, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@433 PS36, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@434 PS36, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@464 PS36, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@469 PS36, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@540 PS36, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@673 PS36, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@676 PS36, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@677 PS36, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@680 PS36, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@740 PS36, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@742 PS36, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@757 PS36, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@759 PS36, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@765 PS36, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@781 PS36, Line 781: csb_patcher "dgpu" "39873" "5" "760e2ac" "26ba303f88935d1cc3e70374972389663ab3930987ddcea0c05f37bc1ecdcba9" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@786 PS36, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@791 PS36, Line 791: csb_patcher "xmp" "40495" "4" "87051b2" "2fcbee1d6bc68107935a6ca0122852b2fe05a209cf9b5d4f065bf9281314dca1" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@796 PS36, Line 796: csb_patcher "tint" "44582" "1" "e4ab099" "495392b76f40c1f19cc3f99606c8ab042b1c901ddcefc7ee40362ce6fca3adef" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@801 PS36, Line 801: csb_patcher "seabios" "32351" "9" "772fa76" "2e4a553693feb212ff920645f2a082123e3bd86b1edefe52236934177d097171" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@806 PS36, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@811 PS36, Line 811: csb_patcher "config.lenovo_g505s" "32352" "30" "f6fb93c" "b3a40483e5b8d13feafc96485ab8db8702d4087f1bee531d8f90c68857b76374" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@816 PS36, Line 816: csb_patcher "config.asus_am1i-a" "33800" "17" "8c6dbab" "e7d1d2b6a329161660542954c856f7b54b8db4520994b3450a47cd8fb00abb26" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@821 PS36, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "4" "7c3332b" "6318af01827e01a235e82aecfdb5346655ff5af4d01f308dadc81c065646549f" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@828 PS36, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@831 PS36, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@884 PS36, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@885 PS36, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/36/csb_patcher.sh@907 PS36, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#37).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also DDR3 XMP/custom_profile support for all the AMD AGESA boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/37
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 37:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@26 PS37, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@190 PS37, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@214 PS37, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@229 PS37, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@242 PS37, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@250 PS37, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@252 PS37, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@257 PS37, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@269 PS37, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@270 PS37, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@278 PS37, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@294 PS37, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@301 PS37, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@304 PS37, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@307 PS37, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@315 PS37, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@319 PS37, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@324 PS37, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@330 PS37, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@334 PS37, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@346 PS37, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@352 PS37, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@354 PS37, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@358 PS37, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@373 PS37, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@380 PS37, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@383 PS37, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@384 PS37, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@387 PS37, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@388 PS37, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@391 PS37, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@396 PS37, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@397 PS37, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@412 PS37, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@429 PS37, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@430 PS37, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@431 PS37, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@432 PS37, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@433 PS37, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@434 PS37, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@464 PS37, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@469 PS37, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@540 PS37, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@673 PS37, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@676 PS37, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@677 PS37, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@680 PS37, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@740 PS37, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@742 PS37, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@757 PS37, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@759 PS37, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@765 PS37, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@781 PS37, Line 781: csb_patcher "dgpu" "39873" "5" "760e2ac" "26ba303f88935d1cc3e70374972389663ab3930987ddcea0c05f37bc1ecdcba9" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@786 PS37, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@791 PS37, Line 791: csb_patcher "xmp" "40495" "4" "87051b2" "2fcbee1d6bc68107935a6ca0122852b2fe05a209cf9b5d4f065bf9281314dca1" "$1" "support " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@796 PS37, Line 796: csb_patcher "tint" "44582" "1" "e4ab099" "495392b76f40c1f19cc3f99606c8ab042b1c901ddcefc7ee40362ce6fca3adef" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@801 PS37, Line 801: csb_patcher "seabios" "32351" "9" "772fa76" "2e4a553693feb212ff920645f2a082123e3bd86b1edefe52236934177d097171" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@806 PS37, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@811 PS37, Line 811: csb_patcher "config.lenovo_g505s" "32352" "33" "7a80fb9" "01b0d02621f9cc0f3680e85c592d92908c378546f0328fb9d496b95bdbb19b51" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@816 PS37, Line 816: csb_patcher "config.asus_am1i-a" "33800" "20" "d3a3753" "74efb02df68237d809df0ab0fc503d13ee05ade70b2e816b67fee046afb298f4" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@821 PS37, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "7" "7efa12f" "6a75f6dd3e49fbf80e7dc69a8478abc7284bbbc0afde889e3d5719a742e42db1" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@828 PS37, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@831 PS37, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@884 PS37, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@885 PS37, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@907 PS37, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 37:
(1 comment)
I’d be really great, if adding the floppy images part could be integrated into the Kconfig payload section. That way, more people could use it, and your script would just select the appropriate Kconfig options.
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@347 PS37, Line 347: atombios_adder The Video BIOS option ROM contains more than just ATOMBIOS, right? Update the function name?
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 37:
(1 comment)
Patch Set 37:
(1 comment)
I’d be really great, if adding the floppy images part could be integrated into the Kconfig payload section. That way, more people could use it, and your script would just select the appropriate Kconfig options.
Thank you for a great suggestion. The only thing stopping me from implementing it - is that a SeaBIOS multiple floppies patch from https://review.coreboot.org/c/coreboot/+/32351 still isn't merged yet, and without it only one floppy could be added - the others are not visible. If you're familiar with SeaBIOS code, feel free to take over my SeaBIOS patches if you'd like.
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@347 PS37, Line 347: atombios_adder
The Video BIOS option ROM contains more than just ATOMBIOS, right? Update the function name?
For the AMD cards, I think the whole ROM is occupied by AtomBIOS and its' function/data tables. Or is it wrong? I like a current name and hope its' not far from truth
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#39).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also DDR3 XMP/custom_profile support for all the AMD AGESA boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/39
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 39:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@26 PS39, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@190 PS39, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@214 PS39, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@229 PS39, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@242 PS39, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@250 PS39, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@252 PS39, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@257 PS39, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@269 PS39, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@270 PS39, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@278 PS39, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@294 PS39, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@301 PS39, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@304 PS39, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@307 PS39, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@315 PS39, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@319 PS39, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@324 PS39, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@330 PS39, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@334 PS39, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@346 PS39, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@352 PS39, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@354 PS39, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@358 PS39, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@373 PS39, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@380 PS39, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@383 PS39, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@384 PS39, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@387 PS39, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@388 PS39, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@391 PS39, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@396 PS39, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@397 PS39, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@412 PS39, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@429 PS39, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@430 PS39, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@431 PS39, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@432 PS39, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@433 PS39, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@434 PS39, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@464 PS39, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@469 PS39, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@540 PS39, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@673 PS39, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@676 PS39, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@677 PS39, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@680 PS39, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@740 PS39, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@742 PS39, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@757 PS39, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@759 PS39, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@765 PS39, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@781 PS39, Line 781: csb_patcher "dgpu" "39873" "7" "4c4aaf8" "461ffa6134cee13cdf7afcfd81bd42ccd39db4f835cf32950143e9f96e829869" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@786 PS39, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@791 PS39, Line 791: csb_patcher "irq" "48266" "2" "e626b56" "b9e06537b3c3a7ffdc2d6f657b38daa2411e364077e4581eba76e43a4cb7125f" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@796 PS39, Line 796: csb_patcher "tint" "44582" "4" "0d7309e" "dfc6dd532ff6de79fc62f79eb042810f64c446c02d85e3323431a10859b7f455" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@801 PS39, Line 801: csb_patcher "seabios" "32351" "11" "02b4028" "2c712fa64430afc836504bd6c9ee4c785d09ef5c282e7a55c52e71a5e26d24e3" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@806 PS39, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@811 PS39, Line 811: csb_patcher "config.lenovo_g505s" "32352" "35" "6bdd8e7" "2f9090d1a7d9b6bc6515ab4aa9dbbe2bb9f195474aa5ec85e0aceda5305f7993" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@816 PS39, Line 816: csb_patcher "config.asus_am1i-a" "33800" "22" "2731fd9" "e3da0a38f78f441350939ea1f7acb7b249c915be7a2d3bf55dc49ab86a6cc855" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@821 PS39, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "9" "daac703" "b653fad480d914759160000e42c6e8c766524f83dfa5154c1ae7c2b458daee02" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@828 PS39, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@831 PS39, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@884 PS39, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@885 PS39, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/39/csb_patcher.sh@907 PS39, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#40).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also good IRQ routing for AMD Lenovo G505S laptop.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/40
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 40:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@26 PS40, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@190 PS40, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@214 PS40, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@229 PS40, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@242 PS40, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@250 PS40, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@252 PS40, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@257 PS40, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@269 PS40, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@270 PS40, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@278 PS40, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@294 PS40, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@301 PS40, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@304 PS40, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@307 PS40, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@315 PS40, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@319 PS40, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@324 PS40, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@330 PS40, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@334 PS40, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@346 PS40, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@352 PS40, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@354 PS40, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@358 PS40, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@373 PS40, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@380 PS40, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@383 PS40, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@384 PS40, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@387 PS40, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@388 PS40, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@391 PS40, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@396 PS40, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@397 PS40, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@412 PS40, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@429 PS40, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@430 PS40, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@431 PS40, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@432 PS40, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@433 PS40, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@434 PS40, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@464 PS40, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@469 PS40, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@540 PS40, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@673 PS40, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@676 PS40, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@677 PS40, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@680 PS40, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@740 PS40, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@742 PS40, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@757 PS40, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@759 PS40, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@765 PS40, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@781 PS40, Line 781: csb_patcher "dgpu" "39873" "7" "4c4aaf8" "461ffa6134cee13cdf7afcfd81bd42ccd39db4f835cf32950143e9f96e829869" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@786 PS40, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@791 PS40, Line 791: csb_patcher "irq" "48266" "4" "8d2458e" "0ef406c9525a48f4dc352c3415027e5702d304fb9d9683e44444a5fb88a7a0a2" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@796 PS40, Line 796: csb_patcher "tint" "44582" "4" "0d7309e" "dfc6dd532ff6de79fc62f79eb042810f64c446c02d85e3323431a10859b7f455" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@801 PS40, Line 801: csb_patcher "seabios" "32351" "11" "02b4028" "2c712fa64430afc836504bd6c9ee4c785d09ef5c282e7a55c52e71a5e26d24e3" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@806 PS40, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@811 PS40, Line 811: csb_patcher "config.lenovo_g505s" "32352" "35" "6bdd8e7" "2f9090d1a7d9b6bc6515ab4aa9dbbe2bb9f195474aa5ec85e0aceda5305f7993" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@816 PS40, Line 816: csb_patcher "config.asus_am1i-a" "33800" "22" "2731fd9" "e3da0a38f78f441350939ea1f7acb7b249c915be7a2d3bf55dc49ab86a6cc855" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@821 PS40, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "9" "daac703" "b653fad480d914759160000e42c6e8c766524f83dfa5154c1ae7c2b458daee02" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@828 PS40, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@831 PS40, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@884 PS40, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@885 PS40, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/40/csb_patcher.sh@907 PS40, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#41).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also good IRQ routing for AMD Lenovo G505S and ASUS A88XM-E boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/41
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 41:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@26 PS41, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@190 PS41, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@214 PS41, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@229 PS41, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@242 PS41, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@250 PS41, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@252 PS41, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@257 PS41, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@269 PS41, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@270 PS41, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@278 PS41, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@294 PS41, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@301 PS41, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@304 PS41, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@307 PS41, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@315 PS41, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@319 PS41, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@324 PS41, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@330 PS41, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@334 PS41, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@346 PS41, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@352 PS41, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@354 PS41, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@358 PS41, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@373 PS41, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@380 PS41, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@383 PS41, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@384 PS41, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@387 PS41, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@388 PS41, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@391 PS41, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@396 PS41, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@397 PS41, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@412 PS41, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@429 PS41, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@430 PS41, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@431 PS41, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@432 PS41, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@433 PS41, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@434 PS41, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@464 PS41, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@469 PS41, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@540 PS41, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@673 PS41, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@676 PS41, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@677 PS41, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@680 PS41, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@740 PS41, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@742 PS41, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@757 PS41, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@759 PS41, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@765 PS41, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@781 PS41, Line 781: csb_patcher "dgpu" "39873" "7" "4c4aaf8" "461ffa6134cee13cdf7afcfd81bd42ccd39db4f835cf32950143e9f96e829869" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@786 PS41, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@791 PS41, Line 791: csb_patcher "irq" "48427" "1" "ba4a09b" "2d45c84f7001273864dbbf5e9abcd27f48fd6e60067cb22125a70fccaef1ad76" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@796 PS41, Line 796: csb_patcher "tint" "44582" "4" "0d7309e" "dfc6dd532ff6de79fc62f79eb042810f64c446c02d85e3323431a10859b7f455" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@801 PS41, Line 801: csb_patcher "seabios" "32351" "11" "02b4028" "2c712fa64430afc836504bd6c9ee4c785d09ef5c282e7a55c52e71a5e26d24e3" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@806 PS41, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@811 PS41, Line 811: csb_patcher "config.lenovo_g505s" "32352" "35" "6bdd8e7" "2f9090d1a7d9b6bc6515ab4aa9dbbe2bb9f195474aa5ec85e0aceda5305f7993" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@816 PS41, Line 816: csb_patcher "config.asus_am1i-a" "33800" "22" "2731fd9" "e3da0a38f78f441350939ea1f7acb7b249c915be7a2d3bf55dc49ab86a6cc855" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@821 PS41, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "9" "daac703" "b653fad480d914759160000e42c6e8c766524f83dfa5154c1ae7c2b458daee02" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@828 PS41, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@831 PS41, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@884 PS41, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@885 PS41, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/41/csb_patcher.sh@907 PS41, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 42:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@26 PS42, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@190 PS42, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@214 PS42, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@229 PS42, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@242 PS42, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@250 PS42, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@252 PS42, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@257 PS42, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@269 PS42, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@270 PS42, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@278 PS42, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@294 PS42, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@301 PS42, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@304 PS42, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@307 PS42, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@315 PS42, Line 315: floppy_verifier "fiwix" "6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@319 PS42, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@324 PS42, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@330 PS42, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@334 PS42, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@346 PS42, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@352 PS42, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@354 PS42, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@358 PS42, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@373 PS42, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@380 PS42, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@383 PS42, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@384 PS42, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@387 PS42, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@388 PS42, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@391 PS42, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@396 PS42, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@397 PS42, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@412 PS42, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@429 PS42, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@430 PS42, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@431 PS42, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@432 PS42, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@433 PS42, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@434 PS42, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@464 PS42, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@469 PS42, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@540 PS42, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@673 PS42, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@676 PS42, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@677 PS42, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@680 PS42, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@740 PS42, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@742 PS42, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@757 PS42, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@759 PS42, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@765 PS42, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@781 PS42, Line 781: csb_patcher "dgpu" "39873" "7" "4c4aaf8" "461ffa6134cee13cdf7afcfd81bd42ccd39db4f835cf32950143e9f96e829869" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@786 PS42, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@791 PS42, Line 791: csb_patcher "irq" "48427" "1" "ba4a09b" "2d45c84f7001273864dbbf5e9abcd27f48fd6e60067cb22125a70fccaef1ad76" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@796 PS42, Line 796: csb_patcher "tint" "44582" "4" "0d7309e" "dfc6dd532ff6de79fc62f79eb042810f64c446c02d85e3323431a10859b7f455" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@801 PS42, Line 801: csb_patcher "seabios" "32351" "11" "02b4028" "2c712fa64430afc836504bd6c9ee4c785d09ef5c282e7a55c52e71a5e26d24e3" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@806 PS42, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@811 PS42, Line 811: csb_patcher "config.lenovo_g505s" "32352" "35" "6bdd8e7" "2f9090d1a7d9b6bc6515ab4aa9dbbe2bb9f195474aa5ec85e0aceda5305f7993" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@816 PS42, Line 816: csb_patcher "config.asus_am1i-a" "33800" "22" "2731fd9" "e3da0a38f78f441350939ea1f7acb7b249c915be7a2d3bf55dc49ab86a6cc855" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@821 PS42, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "9" "daac703" "b653fad480d914759160000e42c6e8c766524f83dfa5154c1ae7c2b458daee02" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@828 PS42, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@831 PS42, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@884 PS42, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@885 PS42, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/42/csb_patcher.sh@907 PS42, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#43).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also good IRQ routing for AMD Lenovo G505S, ASUS A88XM-E and AM1I-A boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, writeprotected_usb ; tint build system ; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/43
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 43:
(66 comments)
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@26 PS43, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@190 PS43, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@214 PS43, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@229 PS43, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@242 PS43, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@250 PS43, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@252 PS43, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@257 PS43, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@269 PS43, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@270 PS43, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@278 PS43, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@294 PS43, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@301 PS43, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@304 PS43, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@307 PS43, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@315 PS43, Line 315: floppy_verifier "fiwix" "d6c0af72afe6bf100ee2a0bf67128253fb0260bd0bbeaac707d90191f7a2c361" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@319 PS43, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@324 PS43, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@330 PS43, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@334 PS43, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@346 PS43, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@352 PS43, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@354 PS43, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@358 PS43, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@373 PS43, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@380 PS43, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@383 PS43, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@384 PS43, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@387 PS43, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@388 PS43, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@391 PS43, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@396 PS43, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@397 PS43, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@412 PS43, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@429 PS43, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@430 PS43, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@431 PS43, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@432 PS43, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@433 PS43, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@434 PS43, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@464 PS43, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@469 PS43, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@540 PS43, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@673 PS43, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@676 PS43, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@677 PS43, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@680 PS43, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@740 PS43, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@742 PS43, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@757 PS43, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@759 PS43, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@765 PS43, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@781 PS43, Line 781: csb_patcher "dgpu" "39873" "7" "4c4aaf8" "461ffa6134cee13cdf7afcfd81bd42ccd39db4f835cf32950143e9f96e829869" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@786 PS43, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@791 PS43, Line 791: csb_patcher "irq" "48427" "3" "663dfc6" "20002afd94c101b4c3385d3c1c4042653c44f9394938e004b3c36de83f556216" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@796 PS43, Line 796: csb_patcher "tint" "44582" "4" "0d7309e" "dfc6dd532ff6de79fc62f79eb042810f64c446c02d85e3323431a10859b7f455" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@801 PS43, Line 801: csb_patcher "seabios" "32351" "11" "02b4028" "2c712fa64430afc836504bd6c9ee4c785d09ef5c282e7a55c52e71a5e26d24e3" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@806 PS43, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@811 PS43, Line 811: csb_patcher "config.lenovo_g505s" "32352" "35" "6bdd8e7" "2f9090d1a7d9b6bc6515ab4aa9dbbe2bb9f195474aa5ec85e0aceda5305f7993" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@816 PS43, Line 816: csb_patcher "config.asus_am1i-a" "33800" "22" "2731fd9" "e3da0a38f78f441350939ea1f7acb7b249c915be7a2d3bf55dc49ab86a6cc855" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@821 PS43, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "9" "daac703" "b653fad480d914759160000e42c6e8c766524f83dfa5154c1ae7c2b458daee02" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@828 PS43, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@831 PS43, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@884 PS43, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@885 PS43, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@907 PS43, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 43:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/43/csb_patcher.sh@648 PS43, Line 648: unzipper "./patch?zip" : mover "./$4.diff" "./$1.diff" : csb_patcher_sha256sum_correct="$5 ./$1.diff" : csb_patcher_sha256sum_my=$( sha256sum "./$1.diff" ) Ideally the SHA256 checksums should also be verified before the unpacking.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 44:
(66 comments)
File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/comment/fc2e7905_52bd5a64 PS44, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/306e6617_aca4006f PS44, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/78c5402d_757605af PS44, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7024cc3a_b5960b6c PS44, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6ae83fe2_a5e75498 PS44, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/49d475c9_90f7fa23 PS44, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d2b270d3_85607e17 PS44, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/655ca4cd_d6825b45 PS44, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/39e95ac1_1f5c7234 PS44, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e1a5c3a7_5f2bcfa1 PS44, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b02ec634_29cbd7f7 PS44, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/8c5e7196_99caf500 PS44, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a2523d1c_a0d9dd15 PS44, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/cf86b8b4_3bf9b3a8 PS44, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/94871b02_fea25691 PS44, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e7089a92_3550e642 PS44, Line 315: floppy_verifier "fiwix" "d6c0af72afe6bf100ee2a0bf67128253fb0260bd0bbeaac707d90191f7a2c361" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a45a478e_a47bdec4 PS44, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c6e0935e_35a142fe PS44, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ccb9ef1d_ce567cce PS44, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/cc64c8c8_5c7fb99c PS44, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7a44c559_f846905f PS44, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f71ab9fe_de951ac9 PS44, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f1fabbf6_3588af09 PS44, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1b4bb2d0_48dd6f1a PS44, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/113218b5_011983fa PS44, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/880d0f8c_539bc9a8 PS44, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/015869e4_7add31db PS44, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/625ebf01_59fa890d PS44, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d758d497_28d8953b PS44, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/011e03ab_021f196b PS44, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ff83327b_b1362fe4 PS44, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0f27672b_e2493f71 PS44, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/25f06e6f_1ed34cce PS44, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/be3093fa_fea7f04a PS44, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/15b06907_cfb26e05 PS44, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/778585a1_0a07ead7 PS44, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/08191bef_03d37caf PS44, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a3b229e8_98c9e558 PS44, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b15f4f0a_94f386ef PS44, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f03daa8a_5388ff79 PS44, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/eb222225_37dde242 PS44, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/10381465_8cd52a55 PS44, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/14480265_75117d93 PS44, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/68357979_44fd752d PS44, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a16454fe_2e550079 PS44, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d3f4ff55_7b6db412 PS44, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/dd664c7b_9ec323de PS44, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/db3e7f99_bca2c49c PS44, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0c25e51a_ca698629 PS44, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a6dd3f00_91d65f94 PS44, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/96205f29_9eb91ebd PS44, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b1b8caa5_9ef4baea PS44, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a4b7bc9a_71eff43e PS44, Line 781: csb_patcher "dgpu" "39873" "7" "4c4aaf8" "461ffa6134cee13cdf7afcfd81bd42ccd39db4f835cf32950143e9f96e829869" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b0789161_1ecd9d92 PS44, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/844dfa6d_82bec572 PS44, Line 791: csb_patcher "irq" "48427" "3" "663dfc6" "20002afd94c101b4c3385d3c1c4042653c44f9394938e004b3c36de83f556216" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1401bd54_5ced6ccb PS44, Line 796: csb_patcher "tint" "44582" "4" "0d7309e" "dfc6dd532ff6de79fc62f79eb042810f64c446c02d85e3323431a10859b7f455" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/17a8f748_645d61a6 PS44, Line 801: csb_patcher "seabios" "32351" "11" "02b4028" "2c712fa64430afc836504bd6c9ee4c785d09ef5c282e7a55c52e71a5e26d24e3" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c3d2255d_1117fc89 PS44, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/4d9e6772_ef80a39e PS44, Line 811: csb_patcher "config.lenovo_g505s" "32352" "35" "6bdd8e7" "2f9090d1a7d9b6bc6515ab4aa9dbbe2bb9f195474aa5ec85e0aceda5305f7993" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/74a2835d_5fdc4b2c PS44, Line 816: csb_patcher "config.asus_am1i-a" "33800" "22" "2731fd9" "e3da0a38f78f441350939ea1f7acb7b249c915be7a2d3bf55dc49ab86a6cc855" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/dd86b3dd_7a18cafa PS44, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "9" "daac703" "b653fad480d914759160000e42c6e8c766524f83dfa5154c1ae7c2b458daee02" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/76dd0035_5d763438 PS44, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/18dbaa1a_fe973b31 PS44, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/04e25cd2_a46a007d PS44, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b1a86e40_39f3a858 PS44, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/228520b6_cc4ca591 PS44, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#45).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also good IRQ routing for AMD Lenovo G505S, ASUS A88XM-E and AM1I-A boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies; tint build system; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/45
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 45:
(66 comments)
File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/comment/3fc911af_5976b12f PS45, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6a7015d6_d0f54318 PS45, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f1820cfb_bf2cec11 PS45, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7a7aad77_eca46e0e PS45, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/08d1b50a_545226ee PS45, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fdd51412_4c0fc1eb PS45, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d62912f2_6515add0 PS45, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/95491fcb_9387c09e PS45, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/128d6cd8_5cbeb7a6 PS45, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/30d4753c_67c097af PS45, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e5fd3119_abf93048 PS45, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f7372764_35dc6572 PS45, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f1ba7121_f4745a20 PS45, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/916ace4c_d7b4e65d PS45, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/9ad7e182_dfdb47cd PS45, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5e37bc66_d706a491 PS45, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e2cd38bb_a4b8ecf3 PS45, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b4c5f258_08cd01a9 PS45, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/46ee84b5_b74872e1 PS45, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/00718023_658a99b7 PS45, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6cf3b8d3_5c8a06be PS45, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1aea5362_218f1293 PS45, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3ea4992d_91db0756 PS45, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/4c5d9052_47d435da PS45, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/cacfe78c_4cec0cfb PS45, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a1d33b0f_fc08d82e PS45, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5cbaee00_363e02e0 PS45, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3e1f6c41_5a04b0a6 PS45, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bc294e41_cfa80ee7 PS45, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/776f0c9c_5a26c2c2 PS45, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f010ad2a_850b9d83 PS45, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6eac6627_7e651d23 PS45, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a8d3d12d_b7df4515 PS45, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b531b22c_262b5855 PS45, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a215ccd6_f4b22da6 PS45, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fac4144d_5b1b3f36 PS45, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f42ddc07_77b3c849 PS45, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/43a7b96f_2aa414e0 PS45, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3c677859_aae2bf68 PS45, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3afa7259_b17695fc PS45, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/462d40cc_9b146ffe PS45, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/57526ff8_d6be2e3f PS45, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/58059ffb_8caf5a3d PS45, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/01073f60_3f4d9908 PS45, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5332a100_66ad61d5 PS45, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e68b55a8_dbfb8f1e PS45, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fc4bd1d4_98b3a7e1 PS45, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f0374df5_66a19073 PS45, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d32fdaa4_c816379f PS45, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/18c1e55d_0329e290 PS45, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/33f56835_07379d28 PS45, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/02664bfe_30d0836b PS45, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/4f08edb8_e47dd4eb PS45, Line 781: csb_patcher "dgpu" "39873" "9" "59a4e65" "5fc8584bb61a5ec1a1e19e3158150f8e63868e07196cbdb9b57facc21f40f610" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/165b0ca8_2c336481 PS45, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/67867c56_25eae513 PS45, Line 791: csb_patcher "irq" "48427" "3" "663dfc6" "20002afd94c101b4c3385d3c1c4042653c44f9394938e004b3c36de83f556216" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ef570ff9_5aa8b96c PS45, Line 796: csb_patcher "tint" "44582" "4" "0d7309e" "dfc6dd532ff6de79fc62f79eb042810f64c446c02d85e3323431a10859b7f455" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/70e05e2d_8a232f24 PS45, Line 801: csb_patcher "seabios" "32351" "13" "1cb4656" "a12db828434f0c09433682b17d99649f7518dbff8582ef83b4d523d21b75e2a0" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/90663ccd_4d6b7ec2 PS45, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a741f122_55df2cc6 PS45, Line 811: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7beace9c_017d83c0 PS45, Line 816: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1fbc5fd8_7a12e0d6 PS45, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a33baf77_903ab117 PS45, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/05a28bc9_796b453b PS45, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/dbefa530_fc4757db PS45, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fc37dd85_5758c523 PS45, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3b40342a_36ce693e PS45, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 46:
(66 comments)
File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/comment/fa83171c_462558a0 PS46, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bb3cde55_443507fe PS46, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/46b69994_9ca02a09 PS46, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/76478b31_e7180d8a PS46, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bc340858_a1b8b737 PS46, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/776d7bbf_1f259323 PS46, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7d1b7001_ceac6548 PS46, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0b44fe74_c1071388 PS46, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/92656adb_56fc47a6 PS46, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/59a267b3_cdc4bc40 PS46, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3b41814e_c8b38e62 PS46, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/01180734_ea524640 PS46, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/4b8b4cf8_ab4608ca PS46, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/01beae8f_07d9a9c0 PS46, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/8d8d3210_a9e46a76 PS46, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3a1b6232_d9f0d4b0 PS46, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5cb3293d_ccd2116d PS46, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c7e268bb_cde58a86 PS46, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1ca4a744_dfd71df9 PS46, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f3d621ec_29ac7d4c PS46, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/be05d78b_66b65046 PS46, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/26e52fb2_6ee0e650 PS46, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1c9e3ac2_f18f74e9 PS46, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f49c4bb1_ab7ccb00 PS46, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f098e9ee_328ad50b PS46, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3445201e_e2f3c3eb PS46, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/81cc7c4b_f9010d6b PS46, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ac305677_72bf2696 PS46, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ee1117ea_39fd3751 PS46, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a6c011ac_63567183 PS46, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3778d9cf_1848ac44 PS46, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/18224a26_74715dce PS46, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3bfaf1a0_015b298c PS46, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/9119aabc_de64e4bb PS46, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/378693ff_2245dea6 PS46, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/93bed2d9_0d16dfbe PS46, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/50b27db0_fe66a096 PS46, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ffe4862a_355f41c9 PS46, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ddeb49e8_bdc4e903 PS46, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e380fa86_d325482e PS46, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a67f01bc_89fbdd10 PS46, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f3bb896a_1e184873 PS46, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fe643b6f_11ab836f PS46, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1380bccb_5864f9dc PS46, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a2477b96_056c89ec PS46, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ca0d2fcd_f5b03ba5 PS46, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d50fdb1a_b7cb5625 PS46, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/9d82a1ab_cbcc0e1e PS46, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a1a71c83_76f9dd53 PS46, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3d9a1519_ce2209e6 PS46, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bb1366cb_ab47c9c1 PS46, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e2b552fc_8aba6000 PS46, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/af268ab4_ae6f4f43 PS46, Line 781: csb_patcher "dgpu" "39873" "9" "59a4e65" "5fc8584bb61a5ec1a1e19e3158150f8e63868e07196cbdb9b57facc21f40f610" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a4ccaa86_48de65e1 PS46, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7475e9d5_8c4ec045 PS46, Line 791: csb_patcher "irq" "48427" "3" "663dfc6" "20002afd94c101b4c3385d3c1c4042653c44f9394938e004b3c36de83f556216" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/458af588_ef328e9e PS46, Line 796: csb_patcher "tint" "44582" "4" "0d7309e" "dfc6dd532ff6de79fc62f79eb042810f64c446c02d85e3323431a10859b7f455" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1aa39cfe_3f766988 PS46, Line 801: csb_patcher "seabios" "32351" "13" "1cb4656" "a12db828434f0c09433682b17d99649f7518dbff8582ef83b4d523d21b75e2a0" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fec5177a_d90a4cf7 PS46, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1904dba2_2c26872f PS46, Line 811: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/22501279_ac3867b8 PS46, Line 816: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c1cdd0d1_9919f8ab PS46, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/9429480d_430ad87f PS46, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0949a792_5f924dc8 PS46, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/20d459a4_aff56804 PS46, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a27b3423_7297595c PS46, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3bb3c7a8_02760fd5 PS46, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#47).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also good IRQ routing for AMD Lenovo G505S, ASUS A88XM-E and AM1I-A boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies; tint build system; and also a floppies collection : KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/47
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 47:
(66 comments)
File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/comment/55c9a143_79ba97b2 PS47, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b63b1ce6_da201c54 PS47, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0162a49a_abd0a95d PS47, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/2a0c1b52_1a0bdfcb PS47, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/13f68bc7_c67b9a77 PS47, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/89df92c0_5a6a3a87 PS47, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d0bda687_2140fcdf PS47, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/541d8291_02e41987 PS47, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/69ba62c0_f10f77d4 PS47, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d6a1df6f_b842d06c PS47, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/88b9b466_7ef2bd7d PS47, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/37636d74_b0c4f69d PS47, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a2ef8f48_96b8711d PS47, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/efb6f973_ec7564df PS47, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/8f7327c2_734563cf PS47, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/12b09b14_722c37dc PS47, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c52095e2_f5879a97 PS47, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b28d056f_98e2733f PS47, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/30c0510b_7b655ffb PS47, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/3c025e0a_12bc91c7 PS47, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5e31f7d2_1f927469 PS47, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e697141e_6f5997e8 PS47, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/05fee027_4520a50e PS47, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e4526c1f_595a9514 PS47, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5e6c489f_98f25630 PS47, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ac4ddd13_c11d3e5a PS47, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/af5c337e_d379994d PS47, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/2ce4b6a8_ad14f62b PS47, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c9d95054_4db42a3c PS47, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5ab3bdfb_0d127737 PS47, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/edca0d5b_5718f0bd PS47, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/38cb921f_5c178f6b PS47, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7f7716ef_addf98bd PS47, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/428f916e_8d224976 PS47, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/20e87465_dd46160e PS47, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/69e5a3ec_c8b7fb0d PS47, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6b578f2b_b51cb4d9 PS47, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bf14456a_4298b8d4 PS47, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7352be93_c012dbef PS47, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/98e41cd3_c0f88a5a PS47, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6d14d22b_4232a871 PS47, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/732edecc_df21e717 PS47, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/eb6f1dab_50ffc18e PS47, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/dfc86447_f4eabbd5 PS47, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/8e07259d_584e6c06 PS47, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/23da752c_cc5092da PS47, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b93fba02_00224027 PS47, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bacb97c1_963e42b3 PS47, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e18c3bf5_c8c0ee71 PS47, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/48b7e6e6_7813e6a0 PS47, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7d684187_b18f8fd6 PS47, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7e499b41_47e76772 PS47, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a21d1009_d12a9c60 PS47, Line 781: csb_patcher "dgpu" "39873" "9" "59a4e65" "5fc8584bb61a5ec1a1e19e3158150f8e63868e07196cbdb9b57facc21f40f610" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/18e9f834_de091d68 PS47, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a348a98c_402174b0 PS47, Line 791: csb_patcher "irq" "48427" "5" "0edf9c5" "c382718ef91ba88206786ad9e06e8f72bb256856b79fb2cd617db2f81ee4b3e9" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7838be33_014ec921 PS47, Line 796: csb_patcher "tint" "50991" "1" "ae15153" "76ec0b52a926cd29774406c3ecf9bd55e27f2d35fff970dc7bbcd12b3f1e31b7" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/9bada1e4_1fbf147e PS47, Line 801: csb_patcher "seabios" "32351" "13" "1cb4656" "a12db828434f0c09433682b17d99649f7518dbff8582ef83b4d523d21b75e2a0" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/4c6aad27_f3bd8a00 PS47, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bfca46f6_b3229f7b PS47, Line 811: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/165253e1_a17bfc1a PS47, Line 816: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/44199963_33e0a455 PS47, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d020db32_bc2c0dce PS47, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/38f4b5e0_2c128309 PS47, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6a2dda9f_3e88cc64 PS47, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/30577548_ddbb8040 PS47, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/2c4ad70f_54fafbe5 PS47, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 48:
(66 comments)
File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/comment/26190aef_95bca6c6 PS48, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a4a3a648_58bb882e PS48, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/44a10654_47681a36 PS48, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e578ed05_c5b63dd5 PS48, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/95d7c809_81a75c27 PS48, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f635cfb6_cc4fd16f PS48, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/8895aad5_29eebbd5 PS48, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e9b67c31_2684253e PS48, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ade124e4_25d897d2 PS48, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/77bece2a_4b41c83f PS48, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/cec8f3cf_54a18b31 PS48, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f7d23d08_068311e8 PS48, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/12945832_b4a487fb PS48, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/62840bcf_da447f8d PS48, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e6e70995_0b810f0c PS48, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/993cbe2b_ac2c15bb PS48, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/63705aab_cfd82158 PS48, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5c9bb1ed_0eaa246c PS48, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a07a45a7_1e95c77f PS48, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f7d24b57_a8b56383 PS48, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ae32c532_ac0c69c8 PS48, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/992f79b9_de0e211c PS48, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b3e48ef0_d7cf1aa1 PS48, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c6f543ba_3f063f25 PS48, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/82734162_ac310b1b PS48, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ccfa0012_61ece01a PS48, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0e487649_65192fa0 PS48, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/2924615a_5a1eb561 PS48, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/4e037b0e_dacab5ea PS48, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/24faf2a0_708ec616 PS48, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/100cf368_3a201cbd PS48, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d09a2f01_d67d06a9 PS48, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/caca5b98_561df910 PS48, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7f0d84ff_33042981 PS48, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c3cd0135_cd96113d PS48, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/dc8b286a_ea09b788 PS48, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bb7101ab_a7b26bd4 PS48, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/2d7f746b_4b35a9f1 PS48, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0682b046_06afc1ff PS48, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ca00a52b_c10930c2 PS48, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/25829c13_3507ca01 PS48, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6930160e_32bb7067 PS48, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/126eb9ba_6c464cc7 PS48, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/216efebb_f8980da7 PS48, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1598a014_3592ffa1 PS48, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/89c6de06_f8620c9c PS48, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0d343788_b272898c PS48, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bfee4efa_4d893289 PS48, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/da34d339_61fc8e48 PS48, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ab02f6b1_1f5d93cd PS48, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/743f42cb_d0d351b6 PS48, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b62165e9_0d6519de PS48, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d0d867b5_331504a3 PS48, Line 781: csb_patcher "dgpu" "39873" "9" "59a4e65" "5fc8584bb61a5ec1a1e19e3158150f8e63868e07196cbdb9b57facc21f40f610" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/caf17913_3a756565 PS48, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/22474ae1_f345ebe0 PS48, Line 791: csb_patcher "irq" "48427" "5" "0edf9c5" "c382718ef91ba88206786ad9e06e8f72bb256856b79fb2cd617db2f81ee4b3e9" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a23f9d24_5e57dc6a PS48, Line 796: csb_patcher "tint" "50991" "1" "ae15153" "76ec0b52a926cd29774406c3ecf9bd55e27f2d35fff970dc7bbcd12b3f1e31b7" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7192e3bf_c243b47c PS48, Line 801: csb_patcher "seabios" "32351" "13" "1cb4656" "a12db828434f0c09433682b17d99649f7518dbff8582ef83b4d523d21b75e2a0" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/940f1fe9_e99f2a04 PS48, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/26662426_aacf8b5d PS48, Line 811: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/22e585f7_8948646b PS48, Line 816: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f8167212_3c50188f PS48, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5cd98064_e24c3e32 PS48, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/803de0a9_c11512e9 PS48, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/60c91526_4fd5a229 PS48, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1b15c8c5_69776aa6 PS48, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f26ca482_f77eaa3e PS48, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#49).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also good IRQ routing for AMD Lenovo G505S, ASUS A88XM-E and AM1I-A boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, smbios_mptable_768; tint build system; and also a floppies collection: KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 923 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/49
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 49:
(66 comments)
File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/comment/84794e97_3c383a0e PS49, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7bf8e303_9ebf3e40 PS49, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/cfa187d2_fcaa3c5a PS49, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b434348b_71a26d73 PS49, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/cf6836fa_3b2c64e6 PS49, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/6c2a9bde_839362d8 PS49, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/9a2fcef6_1b7f22b6 PS49, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/189fa331_c39f9c63 PS49, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1932636d_e4ce0794 PS49, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/88b02d1f_87c46d99 PS49, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/65a9a768_20dce87d PS49, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a924f367_8e4c6aef PS49, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b1fcc9f2_73f4d91a PS49, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/bc5a1e91_cad9d01b PS49, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/cc998354_bbdd115a PS49, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/28b19cf8_470337e0 PS49, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/684eca46_b41bdccf PS49, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/fa4e1fd3_ded15c96 PS49, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ef434915_e1f85562 PS49, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/15b9fa05_d2d77569 PS49, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e64bf41f_9d5c8375 PS49, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/7b581094_e67709eb PS49, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5f058122_fba5c04b PS49, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e63e5960_65131b0e PS49, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/039534f4_497b5537 PS49, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a2f0282d_416b74b0 PS49, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b974e086_721e735a PS49, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/9195ee00_9dc8794b PS49, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/d6dda0e9_c6bada74 PS49, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0270abe9_e68b5a91 PS49, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/feada344_62a442ca PS49, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/43691099_887ba2aa PS49, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/71b31733_635ae4ae PS49, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/52fc7492_d9e7bb8b PS49, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/0433bd8e_3f5ff2cc PS49, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/5744d703_83cfd8ea PS49, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/76b03552_b0ab2c2c PS49, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/79430008_b6ecb7d8 PS49, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ef85d058_1df4da45 PS49, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/e55b4751_c8a7c9e9 PS49, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b4cf76bb_eda0fdc4 PS49, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f2c03730_4dfdf0b9 PS49, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1b21a013_b12fc2cd PS49, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1f713b36_48487491 PS49, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/8fb07997_af083a8c PS49, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c5dd10fd_2146d1c8 PS49, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a8c74e35_9ed1161a PS49, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/f8651699_f6954987 PS49, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/41b19c60_cc625548 PS49, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/1cbf8075_315d7835 PS49, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/8b4aca05_c8ecb2ea PS49, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/333fc2f3_bb11fbb4 PS49, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/da887d39_f57ca72c PS49, Line 781: csb_patcher "dgpu" "39873" "9" "59a4e65" "5fc8584bb61a5ec1a1e19e3158150f8e63868e07196cbdb9b57facc21f40f610" "$1" "G505S " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b76acdbe_cc89b5ae PS49, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c8960b19_67225c1f PS49, Line 791: csb_patcher "irq" "48427" "7" "1fc5952" "eeaed646e848156ee4f59a85bf15d0bc5651352330afec260c5ad74305cc8672" "$1" "AMD good " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/2d469f50_ab4c12f4 PS49, Line 796: csb_patcher "tint" "50991" "1" "ae15153" "76ec0b52a926cd29774406c3ecf9bd55e27f2d35fff970dc7bbcd12b3f1e31b7" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/48233685_2595e586 PS49, Line 801: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/146d0a50_25250598 PS49, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/c195c185_f3f95240 PS49, Line 811: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/8b169d4e_546ecdf7 PS49, Line 816: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/a93e72f9_4631fc7d PS49, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/8710e3f5_9ffaeb84 PS49, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/997de7e2_4044bf1b PS49, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/ee289f00_19679101 PS49, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/373242d1_2193559b PS49, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/comment/b7332a7f_3729b54d PS49, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 50:
(66 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/1509538b_c9547a11 PS50, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/34cadf91_3eb691f2 PS50, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/9d7603e7_0af5c9fe PS50, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/5c2a7f0b_b35f3ae4 PS50, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/a500a03e_e9dd57d7 PS50, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/4c0a9e78_d80fccab PS50, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/95541802_eee4dfc0 PS50, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/e84dc084_622cc45f PS50, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/b8cef755_fff81529 PS50, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/3333514f_e67873ba PS50, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/e5058a63_3cfbed7e PS50, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/2d24e12e_9c35d471 PS50, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/f50382b5_cfcb55ae PS50, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/9a3b0bc0_4028f997 PS50, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/2529b2a8_8ff61d5e PS50, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/c2068d8d_d5a1db35 PS50, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/0f687ef2_073ec8f6 PS50, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/72f12896_c298c99f PS50, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/56100ac2_48c941e5 PS50, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/fe257ea1_f1262288 PS50, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/33bb6cd2_ce937d2a PS50, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/1aa7f228_edafd1da PS50, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/ca74da0f_558b302d PS50, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/7f3a5277_0f387650 PS50, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/a9270590_26bba597 PS50, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/3d10cb2a_ec9a62ce PS50, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/b3560873_14688c23 PS50, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/eb2cafad_5c639408 PS50, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/688c454e_e2fe8a81 PS50, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/ac716a08_70b73856 PS50, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/3fc4e5d3_0d1a4d1d PS50, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/78469ad1_5f9f1caf PS50, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/b4e10228_23e2021f PS50, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/4aca1c6b_42df9060 PS50, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/b4661f41_0832a6f5 PS50, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/8350cf84_2657aa7c PS50, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/d78dac02_78b682a0 PS50, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/2e9d72ae_78c0cb3f PS50, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/e6666b6b_ba99fd87 PS50, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/0a8c4c5d_3a111fb4 PS50, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/5146f063_df6a2db0 PS50, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/ea4753bb_bb72131d PS50, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/e8f53a6a_ad3fe2c9 PS50, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/3b5b4b27_2a70a9aa PS50, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" = "tint" ] || [ "$1" = "seabios" ] || [ "$1" = "cfgsb" ] ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/dce1ff86_1f7d2216 PS50, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/a35119af_2f79ed49 PS50, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/a2c794b9_619fd51a PS50, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/04029daf_8c1c4370 PS50, Line 740: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/3e46523b_c0760b69 PS50, Line 742: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/9c95732a_800cd8d8 PS50, Line 757: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/02ed9936_c6c6925e PS50, Line 759: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/91b50fd6_fc1e02ba PS50, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/4ea4219e_93dd6275 PS50, Line 781: csb_patcher "dgpu" "39873" "9" "59a4e65" "5fc8584bb61a5ec1a1e19e3158150f8e63868e07196cbdb9b57facc21f40f610" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/84e5b766_ee5e847d PS50, Line 786: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/92225b58_518e8266 PS50, Line 791: csb_patcher "irq" "48427" "7" "1fc5952" "eeaed646e848156ee4f59a85bf15d0bc5651352330afec260c5ad74305cc8672" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/4a1478fa_6759a37c PS50, Line 796: csb_patcher "tint" "50991" "1" "ae15153" "76ec0b52a926cd29774406c3ecf9bd55e27f2d35fff970dc7bbcd12b3f1e31b7" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/d5ab1979_a9433ac8 PS50, Line 801: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/9c002a4d_c380de53 PS50, Line 806: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/9ed29c67_08cdc573 PS50, Line 811: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/7672e957_e7aeb5e6 PS50, Line 816: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/a2cc0b7a_858fd77f PS50, Line 821: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/8ba5267b_c3367651 PS50, Line 828: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/05ff129c_dcaa96d4 PS50, Line 831: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/0c5eb16a_0c472766 PS50, Line 884: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/f50f2d7c_9a70e423 PS50, Line 885: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117718): https://review.coreboot.org/c/coreboot/+/33509/comment/754f3580_fa005fdc PS50, Line 907: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#51).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also good IRQ routing for AMD Lenovo G505S, ASUS A88XM-E and AM1I-A boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, smbios_mptable_768; and also a floppies collection: KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 910 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/51
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 51:
(64 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/309ede9c_3755af37 PS51, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/9983e6f2_89db6758 PS51, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/300e3ec2_3bcf1005 PS51, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/40d6493f_775b3b20 PS51, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/01f5d8a3_fc52c4df PS51, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f904410f_7e5cefa3 PS51, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/52e39fae_9b7b7b9d PS51, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/e89d6999_671416f9 PS51, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/7db234a1_56d8b67a PS51, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/9e8434ca_16edd36c PS51, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/52a84025_2d8554fe PS51, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/42e05d74_8d44d9b9 PS51, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/4090714a_bea84562 PS51, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/8e5439db_f43d276f PS51, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/6370ed24_12582d49 PS51, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/a29cda79_e8ebd146 PS51, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/761127bc_acc3cae1 PS51, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/7ec400d1_3902828a PS51, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/3c47354c_82fbff68 PS51, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/bb67c5cd_3311c815 PS51, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f092a34d_01379b38 PS51, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/2f219ec5_fdd46728 PS51, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/5c72efeb_6b6d2041 PS51, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/0e88bed4_25c8bccd PS51, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/24116d20_27fb6297 PS51, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f0c4ba74_f9c00c78 PS51, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/56443c24_fcf3608f PS51, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/82704b89_5eabf7b0 PS51, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/36e1e353_6c968a11 PS51, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/d6d88627_095ae1b0 PS51, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/ad83e878_f30209f9 PS51, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/2da1a75d_ef8a24c1 PS51, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/b9822a55_eb0b9bf1 PS51, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/0a6c23ec_2673bd22 PS51, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/ef905bbb_10d93e26 PS51, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/a4f6ef69_12c2f744 PS51, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/9dd67e53_23fe4f88 PS51, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/40ed0364_56dcd5ea PS51, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/700d608f_61133fcc PS51, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/7dc4d4de_aed318d1 PS51, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/47b241b1_2c4018a2 PS51, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f9ad1ad0_4526cc3b PS51, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/3cd36ae4_d119769f PS51, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/e7716ddd_17220ebe PS51, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/08dad579_0549e56c PS51, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/7315ad5c_64c98641 PS51, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f9bad96c_63bcda53 PS51, Line 732: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/31f27821_6bcc786c PS51, Line 734: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/21bd7c0b_f5c109a9 PS51, Line 749: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/3e4389d7_6ebcec08 PS51, Line 751: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f32765e4_1776d1e0 PS51, Line 757: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/ff1fa9a6_508332e1 PS51, Line 773: csb_patcher "dgpu" "39873" "11" "2dcdeec" "a7c72231cf29eccfcabdf286d7cdf3cff097d302b2a981d45d9fda34357bb95c" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/ac324a89_89dc76b9 PS51, Line 778: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/f9674ee0_d63947d0 PS51, Line 783: csb_patcher "irq" "48427" "9" "1bf54c4" "c5f7dd4acd75c6075a692ef7f33fcffdf65ad2dbef8eb538f10174f39d976adc" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/b8add7b4_f42d7809 PS51, Line 788: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/a4c4b60c_27b26846 PS51, Line 793: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/00b80cc0_094594e0 PS51, Line 798: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/bdbb1088_a81f65e3 PS51, Line 803: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/e85ff2f6_d736648c PS51, Line 808: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/d5717f39_0fc6c252 PS51, Line 815: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/dc460649_2ee50366 PS51, Line 818: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/7046c2af_1d207106 PS51, Line 871: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/e1cce3d5_2e7eb640 PS51, Line 872: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117719): https://review.coreboot.org/c/coreboot/+/33509/comment/c3332761_51150467 PS51, Line 894: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 52:
(64 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/1fb35ecd_3e769ab4 PS52, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/465dc6d4_dfa4db8a PS52, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/3e6bfdd5_81f7268e PS52, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/547620c9_48b5f0d6 PS52, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/86a98ad4_982c38a0 PS52, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/7f6dddba_266e09b3 PS52, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/2c64091e_4fc3b6eb PS52, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/e7957589_3baa2920 PS52, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/787ccaa2_59a9a8a2 PS52, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/6ca4aa0a_0ffc3677 PS52, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/5732e569_567a5bb1 PS52, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/a2c3d0fe_2fce8ce7 PS52, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/1f0b80d9_0def45af PS52, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/e5e3f42a_4fa28c75 PS52, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/7259c131_d1101f73 PS52, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/67157ccc_48091aa2 PS52, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/f1b61043_c2e43fdc PS52, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/49cf3891_54d52fc7 PS52, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/8f21f140_b14f8dd5 PS52, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/8065ef51_9b03e237 PS52, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/07c5a3d9_3b48b3c8 PS52, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/aaee061c_cb8f715d PS52, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/08cddba6_5c0290c2 PS52, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/23e06368_36967263 PS52, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/c7fcdbab_f9948b78 PS52, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/7d67839f_f6e9966d PS52, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/e97960b0_5a1a2a66 PS52, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/48ab7ac0_00697df6 PS52, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/dce5ff1d_92c5e95d PS52, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/f72d9c81_85d4dd4f PS52, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/e261d7a5_73c19c66 PS52, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/25fdff94_9f8b5a27 PS52, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/87369051_2eec4a99 PS52, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/2cc98383_5b2c100b PS52, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/7e79a422_4c803915 PS52, Line 429: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/e1e2bb19_f299f061 PS52, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/40b2401c_2d2a5a23 PS52, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/389107a2_54ccc727 PS52, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/a579e6aa_5f43644e PS52, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/0fa701f4_ca301247 PS52, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/3271088d_427bdd09 PS52, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/066b9242_6433e924 PS52, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/abab4b9e_f213e4d1 PS52, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/8033212e_e5cdc2fb PS52, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/064cb7e8_0ad2d3e8 PS52, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/73fbc9b9_e9d6fc5e PS52, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/128510f7_1da84f2b PS52, Line 732: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/ddfa42e9_51f8e93f PS52, Line 734: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/15341fc2_2fb1e7ef PS52, Line 749: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/4050dc04_a6023cfa PS52, Line 751: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/adf8cf83_defd88ab PS52, Line 757: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/cebe13bc_c4d9efbc PS52, Line 773: csb_patcher "dgpu" "39873" "11" "2dcdeec" "a7c72231cf29eccfcabdf286d7cdf3cff097d302b2a981d45d9fda34357bb95c" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/88609115_1ec73737 PS52, Line 778: csb_patcher "atombios" "33886" "4" "6e7c015" "fc32365abe8506a673d7a61dc16bd54561d1993304d49aa473b14a6c3d1d6201" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/807a97fe_1449014e PS52, Line 783: csb_patcher "irq" "48427" "9" "1bf54c4" "c5f7dd4acd75c6075a692ef7f33fcffdf65ad2dbef8eb538f10174f39d976adc" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/a64669a1_5004499e PS52, Line 788: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/77f36754_58b59631 PS52, Line 793: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/e1b733c1_b4b82fe4 PS52, Line 798: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/9a1decaa_ee8f0c44 PS52, Line 803: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/018f1d0f_6a711c08 PS52, Line 808: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/b22fd094_5ab96ffd PS52, Line 815: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/d546559d_7ae5cc59 PS52, Line 818: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/b658c9c2_4d0558cb PS52, Line 871: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/3aaa0dad_692f8b18 PS52, Line 872: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131824): https://review.coreboot.org/c/coreboot/+/33509/comment/840bfc03_4c3c0cce PS52, Line 894: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#53).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also good IRQ routing for AMD Lenovo G505S, ASUS A88XM-E and AM1I-A boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, smbios_mptable_768; and also a floppies collection: KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 910 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/53
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 53:
(64 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/5fb9a747_f60b5ec8 PS53, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/e4e61b2e_082b229d PS53, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/99b14bb0_630eece9 PS53, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/100889b8_c57f19e6 PS53, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/55d30152_0125cdba PS53, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/0c972ef3_337aeae9 PS53, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/b635b3a1_adbcd00a PS53, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/659f14a9_c4db83bd PS53, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/eaaf0e8e_29322386 PS53, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/57741063_2cdb25c0 PS53, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/d78456a6_ef307045 PS53, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/c4211645_612eca82 PS53, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/767248c6_8d7d1234 PS53, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/095b287a_0b962ab7 PS53, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/39f0db42_09dd90e2 PS53, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/b8ee263f_b7b75c80 PS53, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/1f73da02_d9138fa4 PS53, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/e175b41e_7d45669e PS53, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/bd5055c3_fb9f9501 PS53, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/db33781a_5edc9823 PS53, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/58d89159_412939e2 PS53, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/f0480931_9c725d8c PS53, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/cdf8d8f0_2c3c6b3a PS53, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/6395762b_0712b5bc PS53, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/5ebb5cd0_4fce0f5b PS53, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/9ce9ecdb_8a8f836e PS53, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/3b3bde68_685d242b PS53, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/5d625f14_7f9f722a PS53, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/c95144ce_4c50cd98 PS53, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/14cfd50d_1ed6a168 PS53, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/2bd6a1fa_b814cd3f PS53, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/e1c882cb_8365d36c PS53, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/a4dec9c6_b98b7894 PS53, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/8df822d0_aa860bdb PS53, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/78103ea6_d3b8bc68 PS53, Line 429: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/c1de70c7_1ee32de1 PS53, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/ed34b9ef_36391bf9 PS53, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/1a58a88b_97b262b6 PS53, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/4beecd4a_09b7a597 PS53, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/96f66e41_0f9e1260 PS53, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/331ec5fb_d6e22ceb PS53, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/22c15028_3ed62493 PS53, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/39a5b7f5_c3eb7761 PS53, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/1ddfd376_dd09f930 PS53, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/8d6a1e57_4e3cd254 PS53, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/b1877827_ffa9eec2 PS53, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/1701cc5e_7af39cdc PS53, Line 732: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/a5b3b8da_2418c550 PS53, Line 734: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/e139d78f_6e4a3b49 PS53, Line 749: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/3bf024ba_4c4d45b1 PS53, Line 751: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/1bb4d8a5_a169490b PS53, Line 757: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/b58b246b_d038d9b8 PS53, Line 773: csb_patcher "dgpu" "58745" "1" "d41dfa2" "107282101dbb021a5f24bc4bf6e0c0116f1e446b06ac8379cea6af2dae8cd398" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/80ea6a3a_c9e49c07 PS53, Line 778: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/aa4334bb_176e9e56 PS53, Line 783: csb_patcher "irq" "48427" "11" "8f2cdf1" "b82b7166377f81f16c8cebe54bb99b12efb12e3df6092a887773906196460340" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/f04d8e85_526b0c23 PS53, Line 788: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/a4791b26_8e36f4db PS53, Line 793: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/cfe71705_4080943b PS53, Line 798: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/5e0e3b0a_2bbb3e04 PS53, Line 803: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/3e4bfb39_6e10a4c3 PS53, Line 808: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/22d86baf_ac0fb35a PS53, Line 815: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/2f2fbb5b_55be2daa PS53, Line 818: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/7ac6ffd0_12255636 PS53, Line 871: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/b23b40f5_58a7b211 PS53, Line 872: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131825): https://review.coreboot.org/c/coreboot/+/33509/comment/22e106af_ffbb1f12 PS53, Line 894: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 54: Verified+1
(64 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/4cb0c4e1_122561b0 PS54, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/b9533de0_19fad39f PS54, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/460aacde_90c2f3a3 PS54, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/71096a7a_fedd278e PS54, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/2483171b_e9e6eb9f PS54, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/8393aa80_585561d5 PS54, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/a59e3a28_4d95a0b6 PS54, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/48036add_83250aa1 PS54, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/6c506364_818e925a PS54, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/3d2617e2_d2c6e0ba PS54, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/fe1dce92_8276828b PS54, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/e352dbf1_9b92f538 PS54, Line 294: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/8c3d4dc6_760f4c9b PS54, Line 301: floppy_verifier "freedos" "de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/f102ba2b_466ffbbc PS54, Line 304: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/c339c346_64d6deb5 PS54, Line 307: floppy_verifier "michalos" "8b62d508e30816b64694d99e58cfbeb8be8c4407423e3c3bdef8eefcb32f90ff" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/1ed62972_bbfea48f PS54, Line 315: floppy_verifier "fiwix" "9ec69b7b1a7554ff1aad784304c3926cad69e95abcac1f8a846a7f6251e25fd9" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/54e7326a_13df1574 PS54, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/ab9d6748_01dbc494 PS54, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/1fe04004_4fad1218 PS54, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/9c028c43_b696209b PS54, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/74eb6e97_ee5c3106 PS54, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/88772e25_2256c30f PS54, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/f18d16b6_008c575e PS54, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/21963e09_92ce36a8 PS54, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/b720382e_2307b338 PS54, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/38aeb496_12310d98 PS54, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/dfbabeec_d0ba9b28 PS54, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/651c177c_7bdbfecb PS54, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/a39a7fa3_1418fd4a PS54, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/c4ca903f_8492a788 PS54, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/b0bb0645_628263b9 PS54, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/d8b18946_b4df6265 PS54, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/0e61f00a_68a0dd59 PS54, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/5f845e6b_431b5751 PS54, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/c36d82e4_4e161ba1 PS54, Line 429: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/d2b8c479_7405336c PS54, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/15f62404_0c6ff60d PS54, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/e8a4a902_9a6f941d PS54, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/718d3223_975fb847 PS54, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/0caae45e_61d1232c PS54, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/b8afc25f_497787bd PS54, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/278dcba5_ea7e079b PS54, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/4abb18f3_00522ca2 PS54, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/85a28854_f15c883d PS54, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/fb6d3bb6_c92824c8 PS54, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/5193e748_ce550da0 PS54, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/99ba4b09_99882f56 PS54, Line 732: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/a9946300_ce7590d2 PS54, Line 734: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/eeb9ded8_30e51aa5 PS54, Line 749: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/49228bdf_158bd5f1 PS54, Line 751: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/536ec2bd_2ab2f729 PS54, Line 757: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/e89d3d50_70c8dc2d PS54, Line 773: csb_patcher "dgpu" "58745" "1" "d41dfa2" "107282101dbb021a5f24bc4bf6e0c0116f1e446b06ac8379cea6af2dae8cd398" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/43f8e76f_2a0da49a PS54, Line 778: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/2423b55c_ba5d53b0 PS54, Line 783: csb_patcher "irq" "48427" "11" "8f2cdf1" "b82b7166377f81f16c8cebe54bb99b12efb12e3df6092a887773906196460340" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/4e0b5538_69d52b57 PS54, Line 788: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/2f0ca667_95c8bcb7 PS54, Line 793: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/fc9353f8_a768aeb2 PS54, Line 798: csb_patcher "config.lenovo_g505s" "32352" "37" "a90256b" "ae7a0f2097ec71b215c421df695fc5adc021636240810b0b0a139ae41f975272" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/fec22641_aee6827c PS54, Line 803: csb_patcher "config.asus_am1i-a" "33800" "24" "7aa38bc" "f0522955c9394e58e9e10f1d7dabcc5f8c643e7af548cefe5bc4856cf754a9e9" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/10573a98_39311276 PS54, Line 808: csb_patcher "config.asus_a88xm-e" "39900" "11" "00eb676" "ab89fcd3c01e657f36c5845af0921d080209c06ce3077635bf53a56408ddb18d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/7332ecbb_752563f2 PS54, Line 815: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/4f8e8d3c_639962dd PS54, Line 818: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/82189e94_aa9b029d PS54, Line 871: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/ece52cc7_f7fff011 PS54, Line 872: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137396): https://review.coreboot.org/c/coreboot/+/33509/comment/53f5a345_6fd0a64d PS54, Line 894: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#55).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also good IRQ routing for AMD Lenovo G505S, ASUS A88XM-E and AM1I-A boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, smbios_mptable_768; and also a floppies collection: KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 926 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/55
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 55:
(67 comments)
File csb_patcher.sh:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/50ddfd22_c21d1004 PS55, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a decision - with '$2' message if Y. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/cf502ab6_127eb823 PS55, Line 190: # Downloads a file '$1' from a link '$2' using the options '$3' and checks if this was successful. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/a4b76215_79ee47bf PS55, Line 214: # Unzips the archive '$1', optional '$2' for -j path inside the archive, and then force removes it. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/16db4150_5dac3106 PS55, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size - e.g. to a standard floppy size 1474560. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/4007628d_79074db3 PS55, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2' and creates a hidden '.$1' file if matches. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/feb9a161_d318b8ec PS55, Line 250: printf "\n=== sha256sum should be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/1e21e849_a6368e14 PS55, Line 252: printf "^^^ this is correct, ./floppies/${bold}$1.img${bend} is verified and could be added.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/c396d16a_6d885976 PS55, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img ! Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/f76b5a7a_b7de0432 PS55, Line 269: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/2cd10dad_f042fd0e PS55, Line 270: printf "\n is changing constantly and not provided by $1 project, so not checked.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/fecf81ac_ec71424e PS55, Line 278: # Downloads a collection of floppies, for the purpose of adding them later to a coreboot ROM image. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/58ba9a12_7d73227b PS55, Line 295: printf "\n${byellow}WARNING${bend}: cannot get ./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/9861ddcd_e1ecb73f PS55, Line 299: printf "\n${byellow}WARNING${bend}: getting ./floppies/${bold}freedos.img${bend} could take a couple of minutes...\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/90db2891_0e81d922 PS55, Line 303: floppy_verifier "freedos" "a8c771bfc8ecc4b338a442a3278715787055b5400aa00e0c51018955092a3c86" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/949df813_cd820438 PS55, Line 307: floppy_verifier "michalos" "9e063275a4b098a4af15fffbf6d0a8ae83d11470cb170809a38512eedc035843" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/03e5bae3_c069dff2 PS55, Line 315: floppy_verifier "fiwix" "c4f919adbb95bd145238e7543fe78f2703d87ee7d79e9b57f05b09a64aaa814f" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/94c20cb4_85485c9f PS55, Line 319: floppy_verifier "memtest" "d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/69879ebf_63166d79 PS55, Line 324: floppy_verifier "tatos" "2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/93218c8c_391b5c5f PS55, Line 330: floppy_verifier "plop" "f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/89f6b510_c3c42b8a PS55, Line 334: floppy_verifier "floppybird" "249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/3f319905_4fda5388 PS55, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using '$2' cbfstool, printing '$4'/'$5'/'$6' info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/7a344b87_4578a4e1 PS55, Line 352: printf "\n${bgreen}NOTE${bend}: ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/b2f139b6_85ba9d18 PS55, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/42afcbad_d26e05f5 PS55, Line 358: printf "\n${bold} $2 $3 add -f ./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/b2c1d9ac_dae3174d PS55, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using '$2' cbfstool, printing '$4' size info. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/e2c9f702_b90ad836 PS55, Line 380: printf "\n${bgreen}NOTE${bend}: ./floppies/${bold}$1.img${bend} is already at your $3.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/318933c1_b002d9b7 PS55, Line 383: printf "\n${byellow}WARNING${bend}: ./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed !" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/93c7d6f9_0397f111 PS55, Line 384: printf "\n Add it only if you really need it and trust the author of $1 project.\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/d0d579d9_3565be76 PS55, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/0c1e321d_0c5c7575 PS55, Line 388: "$2" "$3" add -f "./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/24df0587_ce1c80a3 PS55, Line 391: printf "\n${bold} $2 $3 add -f ./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/90f37769_31b5f2cd PS55, Line 396: printf "\n${byellow}WARNING${bend}: there was a SHA256 mismatch for ./floppies/${bold}$1.img${bend} -" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/99945da5_4a7ef9dd PS55, Line 397: printf "\n check sha256sum manually: sha256sum ./floppies/${bold}$1.img${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/65c4ee2f_5621ce31 PS55, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3' ROM copied to '$4', using '$2' cbfstool. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/5ed6ecca_66b8c148 PS55, Line 429: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/f0bedee0_11cfff44 PS55, Line 430: atombios_adder "990b" "$2" "$4" "62K" "Lenovo G505S with A10-5750M" "iGPU HD-8650G" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/2d8f24c7_8da26655 PS55, Line 431: atombios_adder "6663" "$2" "$4" "33K" "Lenovo G505S with A10-5750M" "dGPU HD-8570M" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/0f481f4b_ff032734 PS55, Line 432: atombios_adder "6665" "$2" "$4" "32K" "Lenovo G505S with A10-5750M" "dGPU R5-M230" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/4eb3d694_0b034909 PS55, Line 433: atombios_adder "9830" "$2" "$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400 / R3-Series" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/08f7d823_1e8cbd83 PS55, Line 434: atombios_adder "990c" "$2" "$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU HD-8670D" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/98066bc6_4ebb3aa5 PS55, Line 464: # Finds the files of '$1' extension, saves the result to '$2' log and prints a message with '$3'. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/08e5fe4c_b67f33ea PS55, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend} files at these locations :\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/c302ed0c_aeb6e367 PS55, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I don't know how to configure a board of ${bold}$1${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/f10b9fc4_6e13268e PS55, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am inside the coreboot directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/3a629f26_b3c8da8a PS55, Line 677: printf "\n trying to add a ${bold}$1${bend} set from here - could fail.\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/735d99ee_02f5cc6f PS55, Line 680: printf "\n${byellow}WARNING${bend}: found a '.$1' hidden file at the current directory," line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/b40d3c10_f7ecb1c5 PS55, Line 732: printf "\n${bold}To use it, it should be copied to '.config' of your ./coreboot directory.${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/663ae3f9_55558103 PS55, Line 734: printf "\n${byellow}WARNING${bend}: copying it to ./.config will overwrite your current '.config'\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/c4fbdd73_94b6fd7a PS55, Line 749: printf "\n${bold} cp ./configs/$csb_patcher_config_name ./.config${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/d2f121a9_01e61b75 PS55, Line 751: printf "\n${byellow}WARNING${bend}: important README at the beginning of ./$1.diff\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/954d9556_9d0e0e9f PS55, Line 757: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check sha256sum manually: sha256sum ./$1.diff${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/5640bbb6_36e8d330 PS55, Line 764: # Prints the currently-known errata: what you might need to do to ensure a stable coreboot build. line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/cab856b7_1bd88173 PS55, Line 767: printf "\n ${bold}downgrade the GCC${bend} of a coreboot toolchain with three commands:\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/6e4fcd71_432e3258 PS55, Line 771: if yesno "This should be manually done before patching. ${bold}Continue patching?${bend}" "" ; then line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/58a9d801_48cb3670 PS55, Line 787: csb_patcher "dgpu" "58745" "1" "d41dfa2" "107282101dbb021a5f24bc4bf6e0c0116f1e446b06ac8379cea6af2dae8cd398" "$1" "G505S " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/e622caae_0d878344 PS55, Line 792: csb_patcher "atombios" "58748" "1" "d825cb8" "9dccb185ddd02ee9d6406bc157d2f5a0beace30d1efe122828f9ad51a18569ff" "$1" "AMD " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/eaa008a9_b865586a PS55, Line 797: csb_patcher "irq" "48427" "11" "8f2cdf1" "b82b7166377f81f16c8cebe54bb99b12efb12e3df6092a887773906196460340" "$1" "AMD good " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/626caa61_fab8373f PS55, Line 802: csb_patcher "seabios" "32351" "15" "c4fc787" "b15163a492215c3155e3029415bf07a4514d6c02dd393ad09148d2d4adc17657" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/e1a2821f_1c008d0e PS55, Line 807: csb_patcher "cfgsb" "44638" "1" "fc98bfa" "dae0ff00c5b3aa69d1a205b0e53f3a6c11437e24439bf5b936594506a3ed9d44" "$1" "for-configs " line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/44b12b36_e5379905 PS55, Line 812: csb_patcher "config.lenovo_g505s" "32352" "39" "c1f8e19" "4b8bb1cce5407035cd80286ca643678c2c0cf5bf3c51575d0ac960a666e0f8e2" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/329f18b0_c18f4cb4 PS55, Line 817: csb_patcher "config.asus_am1i-a" "33800" "26" "f84dd87" "d50768e47b997efe37d01dc772463f22f6d0c9c6d2e8b955e3d6d1f619421461" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/51ccb3a0_c9dde68d PS55, Line 822: csb_patcher "config.asus_a88xm-e" "39900" "13" "91a488a" "a198c56a91d08838b384c1cd9ee857ec81930159b6002093e42cb713f9b8ba9d" "$1" "" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/1fd34aa4_4a0c990b PS55, Line 829: printf "${bold}===============${bend} ${bgreen}USAGE${bend} ${bold}================${bend}\n\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/6de72aca_a3e1462d PS55, Line 832: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend} ${bold}|${bend} ${byellow}usage${bend}\n" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/4de68d13_8502ad66 PS55, Line 887: csb_finder "orig" "$csb_patcher_log" "applied correctly although at slightly different lines, can ignore it." line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/af4f8c9e_31c297e3 PS55, Line 888: csb_finder "rej" "$csb_patcher_log" "perhaps failed to apply, could result in a broken build! ${bred}Please report${bend}" line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-137399): https://review.coreboot.org/c/coreboot/+/33509/comment/9a879e65_42b72835 PS55, Line 910: cbfs_mass_adder "$1" "./build/cbfstool" "./build/coreboot.rom" "./build/coreflop.rom" line over 96 characters
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33509
to look at the new patch set (#57).
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my patches from this page - https://review.coreboot.org/q/status:open+banon - and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some "universal" patches as well as great floppies, you may still want to run this script - even if your board is not Lenovo G505S or not AMD.
Please share your feedback/suggestions and tell about other useful patches, preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, custom SeaBIOS options, example configs for G505S / AM1I-A / A88XM-E and known good AtomBIOS ROMs, and also good IRQ routing for AMD Lenovo G505S, ASUS A88XM-E and AM1I-A boards.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies, smbios_mptable_768; and also a floppies collection: KolibriOS, FreeDOS, MichalOS, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more information.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49 --- A csb_patcher.sh 1 file changed, 927 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/33509/57
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 57:
(1 comment)
Patchset:
PS57: Reuploading as CB:64873 because this page takes way too long to load. Thank you very much for your comments, those not-addressed-yet will be copied to a new change.
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Abandoned