Patch Set 37:

(1 comment)

I’d be really great, if adding the floppy images part could be integrated into the Kconfig payload section. That way, more people could use it, and your script would just select the appropriate Kconfig options.

Thank you for a great suggestion. The only thing stopping me from implementing it - is that a SeaBIOS multiple floppies patch from https://review.coreboot.org/c/coreboot/+/32351 still isn't merged yet, and without it only one floppy could be added - the others are not visible. If you're familiar with SeaBIOS code, feel free to take over my SeaBIOS patches if you'd like.

View Change

1 comment:

To view, visit change 33509. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49
Gerrit-Change-Number: 33509
Gerrit-PatchSet: 37
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martinroth@google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 19 Oct 2020 18:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment