Change in coreboot[master]: soc/intel/common/timer: Fix cosmetic errors as per CB:35148 review
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35234 )
Change subject: soc/intel/common/timer: Fix cosmetic errors as per CB:35148 review ......................................................................
soc/intel/common/timer: Fix cosmetic errors as per CB:35148 review
BUG=b:139798422, b:129839774 TEST=Able to build and boot KBL/CML/ICL.
Change-Id: I341eec13d275504545511904db0acd23ad34e940 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/timer/timer.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/35234/1
diff --git a/src/soc/intel/common/block/timer/timer.c b/src/soc/intel/common/block/timer/timer.c index 8fde541..70072cc 100644 --- a/src/soc/intel/common/block/timer/timer.c +++ b/src/soc/intel/common/block/timer/timer.c @@ -38,7 +38,7 @@
static unsigned long get_hardcoded_crystal_freq(void) { - unsigned int core_crystal_nominal_freq_khz; + unsigned long core_crystal_nominal_freq_khz = 0;
/* * Denverton SoCs don't report crystal clock, and also don't support @@ -70,7 +70,7 @@ */ static unsigned long calculate_tsc_freq_from_core_crystal(void) { - unsigned int core_crystal_nominal_freq_khz; + unsigned long core_crystal_nominal_freq_khz; struct cpuid_result cpuidr_15h;
if (get_max_cpuid_func() < 0x15)
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35234 )
Change subject: soc/intel/common/timer: Fix cosmetic errors as per CB:35148 review ......................................................................
Patch Set 1: Code-Review+2
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35234 )
Change subject: soc/intel/common/timer: Fix cosmetic errors as per CB:35148 review ......................................................................
Patch Set 1: Code-Review+2
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35234 )
Change subject: soc/intel/common/timer: Fix cosmetic errors as per CB:35148 review ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35234 )
Change subject: soc/intel/common/timer: Fix cosmetic errors as per CB:35148 review ......................................................................
soc/intel/common/timer: Fix cosmetic errors as per CB:35148 review
BUG=b:139798422, b:129839774 TEST=Able to build and boot KBL/CML/ICL.
Change-Id: I341eec13d275504545511904db0acd23ad34e940 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35234 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: V Sowmya v.sowmya@intel.com Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/timer/timer.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved V Sowmya: Looks good to me, approved Maulik V Vaghela: Looks good to me, approved
diff --git a/src/soc/intel/common/block/timer/timer.c b/src/soc/intel/common/block/timer/timer.c index 8fde541..70072cc 100644 --- a/src/soc/intel/common/block/timer/timer.c +++ b/src/soc/intel/common/block/timer/timer.c @@ -38,7 +38,7 @@
static unsigned long get_hardcoded_crystal_freq(void) { - unsigned int core_crystal_nominal_freq_khz; + unsigned long core_crystal_nominal_freq_khz = 0;
/* * Denverton SoCs don't report crystal clock, and also don't support @@ -70,7 +70,7 @@ */ static unsigned long calculate_tsc_freq_from_core_crystal(void) { - unsigned int core_crystal_nominal_freq_khz; + unsigned long core_crystal_nominal_freq_khz; struct cpuid_result cpuidr_15h;
if (get_max_cpuid_func() < 0x15)
-
Furquan Shaikh (Code Review) -
Maulik V Vaghela (Code Review)
-
Subrata Banik (Code Review)
-
V Sowmya (Code Review)