Subrata Banik submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved V Sowmya: Looks good to me, approved Maulik V Vaghela: Looks good to me, approved
soc/intel/common/timer: Fix cosmetic errors as per CB:35148 review

BUG=b:139798422, b:129839774
TEST=Able to build and boot KBL/CML/ICL.

Change-Id: I341eec13d275504545511904db0acd23ad34e940
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35234
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: V Sowmya <v.sowmya@intel.com>
Reviewed-by: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/soc/intel/common/block/timer/timer.c
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/common/block/timer/timer.c b/src/soc/intel/common/block/timer/timer.c
index 8fde541..70072cc 100644
--- a/src/soc/intel/common/block/timer/timer.c
+++ b/src/soc/intel/common/block/timer/timer.c
@@ -38,7 +38,7 @@

static unsigned long get_hardcoded_crystal_freq(void)
{
- unsigned int core_crystal_nominal_freq_khz;
+ unsigned long core_crystal_nominal_freq_khz = 0;

/*
* Denverton SoCs don't report crystal clock, and also don't support
@@ -70,7 +70,7 @@
*/
static unsigned long calculate_tsc_freq_from_core_crystal(void)
{
- unsigned int core_crystal_nominal_freq_khz;
+ unsigned long core_crystal_nominal_freq_khz;
struct cpuid_result cpuidr_15h;

if (get_max_cpuid_func() < 0x15)

To view, visit change 35234. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I341eec13d275504545511904db0acd23ad34e940
Gerrit-Change-Number: 35234
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged