Change in coreboot[master]: soc/intel/alderlake: Implement function to map physical port to EC port
Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Patrick Rudolph. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59666 )
Change subject: soc/intel/alderlake: Implement function to map physical port to EC port ......................................................................
Patch Set 12:
(3 comments)
File src/soc/intel/alderlake/retimer.c:
https://review.coreboot.org/c/coreboot/+/59666/comment/90e9c3a6_9f8497dc PS9, Line 30: die("Couldn't find correct port mapping or Invalid input port\n");
I don't think we need to call die() here, returning some kind of error code is probably better (and […]
Ack
File src/soc/intel/alderlake/retimer.c:
https://review.coreboot.org/c/coreboot/+/59666/comment/e1070a3c_9542f88e PS11, Line 21: printk(BIOS_ERR, "USB Type-C %d mapped to EC port %d\n", typec_port, ec_port);
line over 96 characters
Please fix.
File src/soc/intel/alderlake/retimer.c:
https://review.coreboot.org/c/coreboot/+/59666/comment/ce431b6e_847940bd PS12, Line 8: uint8_t
so then maybe this should have a different return type
Ack
-
Maulik V Vaghela (Code Review)