Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.

View Change

3 comments:

• File src/soc/intel/alderlake/retimer.c:

  • Patch Set #9, Line 30: die("Couldn't find correct port mapping or Invalid input port\n");

    I don't think we need to call die() here, returning some kind of error code is probably better (and […]

    Ack

• File src/soc/intel/alderlake/retimer.c:

  • Patch Set #11, Line 21: printk(BIOS_ERR, "USB Type-C %d mapped to EC port %d\n", typec_port, ec_port);

    line over 96 characters

    Please fix.

• File src/soc/intel/alderlake/retimer.c:

  • Patch Set #12, Line 8: uint8_t

    so then maybe this should have a different return type

    Ack

To view, visit change 59666. To unsubscribe, or for help writing mail filters, visit settings.