Change in ...coreboot[master]: mb/google/hatch/variants/helios: Update Spd sources - coreboot-gerrit

2 Jul 2019


      Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33953 )
Change subject: mb/google/hatch/variants/helios: Update Spd sources
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/33953/1/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/helios/Makefile.inc:
https://review.coreboot.org/#/c/33953/1/src/mainboard/google/hatch/variants/... 
PS1, Line 18: SPD_SOURCES += LP_8G_2133		# 0b0011
            : SPD_SOURCES += LP_16G_2133		# 0b0100
Why are these required? ID 0 and 1 are exactly the same as what you are adding for 3 and 4.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cb4e46c7c4da72d8fb029f1b8e8c3b06d1ab156
Gerrit-Change-Number: 33953
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Frank Chu frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-CC: Kane Chen kane.chen@intel.corp-partner.google.com
Gerrit-CC: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Jul 2019 03:02:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment