Pavel Sayekat has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33910
Change subject: util/superiotool/nuvoton.c: Minor tag update/removal ......................................................................
util/superiotool/nuvoton.c: Minor tag update/removal
Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com Change-Id: Ic193f31b9776683849578bf9009c51bf22d1dae6 --- M util/superiotool/nuvoton.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/33910/1
diff --git a/util/superiotool/nuvoton.c b/util/superiotool/nuvoton.c index 7552244..81bff96 100644 --- a/util/superiotool/nuvoton.c +++ b/util/superiotool/nuvoton.c @@ -594,7 +594,7 @@ {0x05, "Keyboard Controller", {0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT}, {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x83,EOT}}, - {0x06, "CIR", + {0x06, "Consumer IR", {0x30,0x60,0x61,0x70,EOT}, {0x00,0x00,0x00,0x00,EOT}}, {0x07, "GPIO 7, GPIO 8", @@ -622,7 +622,7 @@ {0x00,0x00,0x00,0x00,0x7f,0x7f,0x7f,0x7f,0x7f,0xa8, 0x08,0x7f,0x00,0x81,0x00,0x00,0x00,0x00,0x87,0x47, 0x00,0x00,0x00,0x02,EOT}}, - {0x0d, "BCLK, WDT2", + {0x0d, "WDT2", {0xe7,0xe8,0xeb,0xed,0xf0,0xf3,EOT}, {0x10,0x32,0x14,0x00,0x00,0x00,EOT}}, {0x0e, "CIR Wake-Up",
Pavel Sayekat has removed Nico Huber from this change. ( https://review.coreboot.org/c/coreboot/+/33910 )
Change subject: util/superiotool/nuvoton.c: Minor tag update/removal ......................................................................
Removed reviewer Nico Huber.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33910 )
Change subject: util/superiotool/nuvoton.c: Minor tag update/removal ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33910 )
Change subject: util/superiotool/nuvoton.c: Minor tag update/removal ......................................................................
util/superiotool/nuvoton.c: Minor tag update/removal
Signed-off-by: Pavel Sayekat pavelsayekat@gmail.com Change-Id: Ic193f31b9776683849578bf9009c51bf22d1dae6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33910 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M util/superiotool/nuvoton.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/util/superiotool/nuvoton.c b/util/superiotool/nuvoton.c index 7552244..81bff96 100644 --- a/util/superiotool/nuvoton.c +++ b/util/superiotool/nuvoton.c @@ -594,7 +594,7 @@ {0x05, "Keyboard Controller", {0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT}, {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x83,EOT}}, - {0x06, "CIR", + {0x06, "Consumer IR", {0x30,0x60,0x61,0x70,EOT}, {0x00,0x00,0x00,0x00,EOT}}, {0x07, "GPIO 7, GPIO 8", @@ -622,7 +622,7 @@ {0x00,0x00,0x00,0x00,0x7f,0x7f,0x7f,0x7f,0x7f,0xa8, 0x08,0x7f,0x00,0x81,0x00,0x00,0x00,0x00,0x87,0x47, 0x00,0x00,0x00,0x02,EOT}}, - {0x0d, "BCLK, WDT2", + {0x0d, "WDT2", {0xe7,0xe8,0xeb,0xed,0xf0,0xf3,EOT}, {0x10,0x32,0x14,0x00,0x00,0x00,EOT}}, {0x0e, "CIR Wake-Up",
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33910 )
Change subject: util/superiotool/nuvoton.c: Minor tag update/removal ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33910/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33910/1//COMMIT_MSG@7 PS1, Line 7: util/superiotool/nuvoton.c: Minor tag update/removal Thank you for your contribution. Please use statements in the future by using a verb (in imperative mood).
Update/remove tags
Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33910 )
Change subject: util/superiotool/nuvoton.c: Minor tag update/removal ......................................................................
Patch Set 2:
Patch Set 2:
(1 comment)
Noted
-
Felix Held (Code Review) -
Paul Menzel (Code Review)
-
Pavel Sayekat (Code Review)