Change in ...coreboot[master]: QCS405: Added RPM support - coreboot-gerrit

6 Jun 2019


      Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29970 )
Change subject: QCS405: Added RPM support
......................................................................
Patch Set 28: Code-Review+1
(1 comment)
too much debug printing, otherwise this looks okay
https://review.coreboot.org/#/c/29970/28/src/soc/qualcomm/qcs405/rpm_load_re... 
File src/soc/qualcomm/qcs405/rpm_load_reset.c:
https://review.coreboot.org/#/c/29970/28/src/soc/qualcomm/qcs405/rpm_load_re... 
PS28, Line 42: 	printk(BIOS_DEBUG, "\nNIT:PROG_INIT for /rpm has happened.\n");
These lowlevel debugging messages can probably be removed?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29970
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17f491f0a4bd0dce7522b7e80e1bac97ec18b945
Gerrit-Change-Number: 29970
Gerrit-PatchSet: 28
Gerrit-Owner: Nitheesh Sekar nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 06 Jun 2019 12:00:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment