jitao shi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33572
Change subject: google/krane: turn off backlight before config display ......................................................................
google/krane: turn off backlight before config display
Turn off backlight before display config and then turn on backlight after display config. Avoid flash white screen when configuring display.
BUG=b:129299873 BRANCH=none
Change-Id: I91ae2fabdf1c00b0683085a03d3f48ad3b6b7879 Signed-off-by: Jitao Shi jitao.shi@mediatek.com --- M src/mainboard/google/kukui/panel_krane.c 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/33572/1
diff --git a/src/mainboard/google/kukui/panel_krane.c b/src/mainboard/google/kukui/panel_krane.c index cb6e9cf..55c7ff5 100644 --- a/src/mainboard/google/kukui/panel_krane.c +++ b/src/mainboard/google/kukui/panel_krane.c @@ -388,10 +388,11 @@ return false; };
+/* Setup backlight control pins as output pin and power-off by default */ static int krane_backlight(struct board_display_intf *intf) { - gpio_output(GPIO(PERIPHERAL_EN13), 1); - gpio_output(GPIO(DISP_PWM), 1); /* DISP_PWM0 */ + gpio_output(GPIO(PERIPHERAL_EN13), 0); + gpio_output(GPIO(DISP_PWM), 0);
return 0; };
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33572
to look at the new patch set (#2).
Change subject: google/krane: turn off backlight before config display ......................................................................
google/krane: turn off backlight before config display
Turn off backlight before display config and then turn on backlight after display config. Avoid flash white screen when configuring display.
BUG=b:129299873 BRANCH=none
Change-Id: I91ae2fabdf1c00b0683085a03d3f48ad3b6b7879 Signed-off-by: Jitao Shi jitao.shi@mediatek.com --- M src/mainboard/google/kukui/panel_krane.c 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/33572/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33572 )
Change subject: google/krane: turn off backlight before display configuration ......................................................................
Patch Set 3:
please simply merge this to https://review.coreboot.org/c/coreboot/+/32512 since that's not merged yet.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33572 )
Change subject: google/krane: turn off backlight before display configuration ......................................................................
Patch Set 3:
please abandon this. it's already implemented in the new series.
jitao shi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33572 )
Change subject: google/krane: turn off backlight before display configuration ......................................................................
Abandoned
-
Hung-Te Lin (Code Review) -
jitao shi (Code Review)