Change in coreboot[master]: soc/intel/common/cse: Add dependency on SOC_INTEL_CSE_LITE_SKU
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46905 )
Change subject: soc/intel/common/cse: Add dependency on SOC_INTEL_CSE_LITE_SKU ......................................................................
soc/intel/common/cse: Add dependency on SOC_INTEL_CSE_LITE_SKU
This change adds the dependency on SOC_INTEL_CSE_LITE_SKU for the following configs: 1. SOC_INTEL_CSE_FMAP_NAME 2. SOC_INTEL_CSE_RW_CBFS_NAME 3. SOC_INTEL_CSE_RW_FILE
These configs aren't really useful for platforms not using CSE Lite SKU.
Change-Id: Id48ab36b7e75301d50122916d153f494d755ae77 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/common/block/cse/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/46905/1
diff --git a/src/soc/intel/common/block/cse/Kconfig b/src/soc/intel/common/block/cse/Kconfig index 1cb7d35..a651198 100644 --- a/src/soc/intel/common/block/cse/Kconfig +++ b/src/soc/intel/common/block/cse/Kconfig @@ -22,18 +22,21 @@
config SOC_INTEL_CSE_FMAP_NAME string "Name of CSE Region in FMAP" + depends on SOC_INTEL_CSE_LITE_SKU default "SI_ME" help Name of CSE region in FMAP
config SOC_INTEL_CSE_RW_CBFS_NAME string "CBFS entry name for CSE RW blob" + depends on SOC_INTEL_CSE_LITE_SKU default "me_rw" help CBFS entry name for Intel CSE CBFS RW blob
config SOC_INTEL_CSE_RW_FILE string "Intel CSE CBFS RW path and filename" + depends on SOC_INTEL_CSE_LITE_SKU default "" help Intel CSE CBFS RW blob path and file name
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46905 )
Change subject: soc/intel/common/cse: Add dependency on SOC_INTEL_CSE_LITE_SKU ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46905 )
Change subject: soc/intel/common/cse: Add dependency on SOC_INTEL_CSE_LITE_SKU ......................................................................
soc/intel/common/cse: Add dependency on SOC_INTEL_CSE_LITE_SKU
This change adds the dependency on SOC_INTEL_CSE_LITE_SKU for the following configs: 1. SOC_INTEL_CSE_FMAP_NAME 2. SOC_INTEL_CSE_RW_CBFS_NAME 3. SOC_INTEL_CSE_RW_FILE
These configs aren't really useful for platforms not using CSE Lite SKU.
Change-Id: Id48ab36b7e75301d50122916d153f494d755ae77 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46905 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/cse/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cse/Kconfig b/src/soc/intel/common/block/cse/Kconfig index 1cb7d35..a651198 100644 --- a/src/soc/intel/common/block/cse/Kconfig +++ b/src/soc/intel/common/block/cse/Kconfig @@ -22,18 +22,21 @@
config SOC_INTEL_CSE_FMAP_NAME string "Name of CSE Region in FMAP" + depends on SOC_INTEL_CSE_LITE_SKU default "SI_ME" help Name of CSE region in FMAP
config SOC_INTEL_CSE_RW_CBFS_NAME string "CBFS entry name for CSE RW blob" + depends on SOC_INTEL_CSE_LITE_SKU default "me_rw" help CBFS entry name for Intel CSE CBFS RW blob
config SOC_INTEL_CSE_RW_FILE string "Intel CSE CBFS RW path and filename" + depends on SOC_INTEL_CSE_LITE_SKU default "" help Intel CSE CBFS RW blob path and file name
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)