Change in coreboot[master]: drivers/wifi/generic: Use is_dev_enabled() instead of dev->enabled
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46904 )
Change subject: drivers/wifi/generic: Use is_dev_enabled() instead of dev->enabled ......................................................................
drivers/wifi/generic: Use is_dev_enabled() instead of dev->enabled
This change replaces the checks for dev->enabled with the helper function `is_dev_enabled()`.
Change-Id: Iacceda396c9300bbfa124e76fb9c99d86313ea0f Signed-off-by: Furquan Shaikh furquan@google.com --- M src/drivers/wifi/generic/acpi.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/46904/1
diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index 33862d9..4544b46 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -222,7 +222,7 @@ { const char *path;
- if (!dev->enabled) + if (is_dev_enabled(dev)) return;
path = acpi_device_path(dev); @@ -247,7 +247,7 @@ { const char *path;
- if (!dev->enabled) + if (!is_dev_enabled(dev)) return;
path = acpi_device_path(dev->bus->dev);
Hello Duncan Laurie,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46904
to look at the new patch set (#2).
Change subject: drivers/wifi/generic: Use is_dev_enabled() instead of dev->enabled ......................................................................
drivers/wifi/generic: Use is_dev_enabled() instead of dev->enabled
This change replaces the checks for dev->enabled with the helper function `is_dev_enabled()`.
Change-Id: Iacceda396c9300bbfa124e76fb9c99d86313ea0f Signed-off-by: Furquan Shaikh furquan@google.com --- M src/drivers/wifi/generic/acpi.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/46904/2
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46904 )
Change subject: drivers/wifi/generic: Use is_dev_enabled() instead of dev->enabled ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46904 )
Change subject: drivers/wifi/generic: Use is_dev_enabled() instead of dev->enabled ......................................................................
drivers/wifi/generic: Use is_dev_enabled() instead of dev->enabled
This change replaces the checks for dev->enabled with the helper function `is_dev_enabled()`.
Change-Id: Iacceda396c9300bbfa124e76fb9c99d86313ea0f Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46904 Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/wifi/generic/acpi.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index 33862d9..ac2c5eb 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -222,7 +222,7 @@ { const char *path;
- if (!dev->enabled) + if (!is_dev_enabled(dev)) return;
path = acpi_device_path(dev); @@ -247,7 +247,7 @@ { const char *path;
- if (!dev->enabled) + if (!is_dev_enabled(dev)) return;
path = acpi_device_path(dev->bus->dev);
-
Duncan Laurie (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)