Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44354 )
Change subject: soc/amd/common/espi_util: rename espi_check_status ......................................................................
soc/amd/common/espi_util: rename espi_check_status
espi_poll_status describes better what the function actually does, since it polls the status register instead of just doing a single read to check.
Change-Id: I0feeef5504bd911e1fb0a00d4f4c546df3548db2 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/lpc/espi_util.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44354/1
diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index f1afbdb..5fbd7a3 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -406,7 +406,7 @@ * Wait up to ESPI_CMD_TIMEOUT_US for interrupt status register to update after sending a * command. */ -static int espi_check_status(uint32_t *status) +static int espi_poll_status(uint32_t *status) { struct stopwatch sw;
@@ -457,7 +457,7 @@ return -1; }
- if (espi_check_status(&status) == -1) { + if (espi_poll_status(&status) == -1) { espi_show_failure(cmd, "Error: eSPI check status failed", 0); return -1; }
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44354 )
Change subject: soc/amd/common/espi_util: rename espi_check_status ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44354/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/44354/1/src/soc/amd/common/block/lp... PS1, Line 461: check poll?
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44354
to look at the new patch set (#2).
Change subject: soc/amd/common/espi_util: rename espi_check_status ......................................................................
soc/amd/common/espi_util: rename espi_check_status
espi_poll_status describes better what the function actually does, since it polls the status register instead of just doing a single read to check.
Change-Id: I0feeef5504bd911e1fb0a00d4f4c546df3548db2 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/common/block/lpc/espi_util.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/44354/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44354 )
Change subject: soc/amd/common/espi_util: rename espi_check_status ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44354/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/44354/1/src/soc/amd/common/block/lp... PS1, Line 461: check
poll?
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44354 )
Change subject: soc/amd/common/espi_util: rename espi_check_status ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44354 )
Change subject: soc/amd/common/espi_util: rename espi_check_status ......................................................................
soc/amd/common/espi_util: rename espi_check_status
espi_poll_status describes better what the function actually does, since it polls the status register instead of just doing a single read to check.
Change-Id: I0feeef5504bd911e1fb0a00d4f4c546df3548db2 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/44354 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/amd/common/block/lpc/espi_util.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index b09d61d..1b617fc 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -406,7 +406,7 @@ * Wait up to ESPI_CMD_TIMEOUT_US for interrupt status register to update after sending a * command. */ -static int espi_check_status(uint32_t *status) +static int espi_poll_status(uint32_t *status) { struct stopwatch sw;
@@ -457,8 +457,8 @@ return -1; }
- if (espi_check_status(&status) == -1) { - espi_show_failure(cmd, "Error: eSPI check status failed", 0); + if (espi_poll_status(&status) == -1) { + espi_show_failure(cmd, "Error: eSPI poll status failed", 0); return -1; }
-
Felix Held (Code Review) -
Furquan Shaikh (Code Review)