Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
soc/amd/common/espi_util: rename espi_check_status

espi_poll_status describes better what the function actually does, since
it polls the status register instead of just doing a single read to
check.

Change-Id: I0feeef5504bd911e1fb0a00d4f4c546df3548db2
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44354
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
---
M src/soc/amd/common/block/lpc/espi_util.c
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c
index b09d61d..1b617fc 100644
--- a/src/soc/amd/common/block/lpc/espi_util.c
+++ b/src/soc/amd/common/block/lpc/espi_util.c
@@ -406,7 +406,7 @@
* Wait up to ESPI_CMD_TIMEOUT_US for interrupt status register to update after sending a
* command.
*/
-static int espi_check_status(uint32_t *status)
+static int espi_poll_status(uint32_t *status)
{
struct stopwatch sw;

@@ -457,8 +457,8 @@
return -1;
}

- if (espi_check_status(&status) == -1) {
- espi_show_failure(cmd, "Error: eSPI check status failed", 0);
+ if (espi_poll_status(&status) == -1) {
+ espi_show_failure(cmd, "Error: eSPI poll status failed", 0);
return -1;
}


To view, visit change 44354. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0feeef5504bd911e1fb0a00d4f4c546df3548db2
Gerrit-Change-Number: 44354
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged