Change in coreboot[master]: coreinfo/coreinfo.c: Support both lower and upper case alphabets

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Name of user not set (Code Review)

23 Sep 2019 23 Sep '19

11:58 a.m.

Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35538 )

Change subject: coreinfo/coreinfo.c: Support both lower and upper case alphabets ......................................................................

coreinfo/coreinfo.c: Support both lower and upper case alphabets

Modify handle_category_key to handle both upper and lower case alphabets in the coreinfo payload.

Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- M payloads/coreinfo/coreinfo.c 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/35538/1

diff --git a/payloads/coreinfo/coreinfo.c b/payloads/coreinfo/coreinfo.c index b731abf..e6b7f2e 100644 --- a/payloads/coreinfo/coreinfo.c +++ b/payloads/coreinfo/coreinfo.c @@ -198,7 +198,9 @@

static void handle_category_key(struct coreinfo_cat *cat, int key) { - if (key >= 'a' && key <= 'z') { + if ((key >= 'a' && key <= 'z') || (key >= 'A' && key <= 'Z')) { + if (key >= 'A' && key <= 'Z') + key = key + 32; int index = key - 'a'; if (index < cat->count) { cat->cur = index;

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Paul Menzel (Code Review)

24 Sep 24 Sep

3:13 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35538 )

Change subject: coreinfo/coreinfo.c: Support both lower and upper case alphabets ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/35538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Gerrit-Change-Number: 35538 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 24 Sep 2019 13:13:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Arthur Heymans (Code Review)

1 Oct 1 Oct

1:48 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35538 )

Change subject: coreinfo/coreinfo.c: Support both lower and upper case alphabets ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/35538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Gerrit-Change-Number: 35538 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 01 Oct 2019 11:48:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

1:49 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35538 )

Change subject: coreinfo/coreinfo.c: Support both lower and upper case alphabets ......................................................................

Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/c/coreboot/+/35538/1/payloads/coreinfo/coreinfo.... File payloads/coreinfo/coreinfo.c:

https://review.coreboot.org/c/coreboot/+/35538/1/payloads/coreinfo/coreinfo.... PS1, Line 203: 32 Why this magic value?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Gerrit-Change-Number: 35538 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 01 Oct 2019 11:49:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

1:53 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35538 )

Change subject: coreinfo/coreinfo.c: Support both lower and upper case alphabets ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35538/1/payloads/coreinfo/coreinfo.... File payloads/coreinfo/coreinfo.c:

https://review.coreboot.org/c/coreboot/+/35538/1/payloads/coreinfo/coreinfo.... PS1, Line 203: 32

...

Why this magic value?

Moreover, this approach would modify 'key', which is used later on.

Here's my suggested approach:

int index; if (key >= 'A' && key <= 'Z') { index = key - 'A'; } else { index = key - 'a'; }

-- To view, visit https://review.coreboot.org/c/coreboot/+/35538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Gerrit-Change-Number: 35538 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 01 Oct 2019 11:53:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Name of user not set (Code Review)

6:20 p.m.

Hello HAOUAS Elyes, Angel Pons, Arthur Heymans, Jacob Garber, Paul Menzel, Stefan Reinauer, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35538

to look at the new patch set (#2).

Change subject: coreinfo/coreinfo.c: Support both lower and upper case alphabets ......................................................................

coreinfo/coreinfo.c: Support both lower and upper case alphabets

Modify handle_category_key to handle both upper and lower case alphabets in the coreinfo payload.

Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- M payloads/coreinfo/coreinfo.c 1 file changed, 7 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/35538/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Gerrit-Change-Number: 35538 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

6:23 p.m.

Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35538 )

Change subject: coreinfo/coreinfo.c: Support both lower and upper case alphabets ......................................................................

Patch Set 2:

(1 comment)

Thanks

https://review.coreboot.org/c/coreboot/+/35538/1/payloads/coreinfo/coreinfo.... File payloads/coreinfo/coreinfo.c:

https://review.coreboot.org/c/coreboot/+/35538/1/payloads/coreinfo/coreinfo.... PS1, Line 203: 32

...

Moreover, this approach would modify 'key', which is used later on. […]

Yes, you are right! Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Gerrit-Change-Number: 35538 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 01 Oct 2019 16:23:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

2 Oct 2 Oct

2:17 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35538 )

Change subject: coreinfo/coreinfo.c: Support both lower and upper case alphabets ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Gerrit-Change-Number: 35538 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 02 Oct 2019 00:17:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

1:20 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35538 )

Change subject: coreinfo/coreinfo.c: Support both lower and upper case alphabets ......................................................................

coreinfo/coreinfo.c: Support both lower and upper case alphabets

Modify handle_category_key to handle both upper and lower case alphabets in the coreinfo payload.

Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35538 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M payloads/coreinfo/coreinfo.c 1 file changed, 7 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved

diff --git a/payloads/coreinfo/coreinfo.c b/payloads/coreinfo/coreinfo.c index b731abf..53985b2 100644 --- a/payloads/coreinfo/coreinfo.c +++ b/payloads/coreinfo/coreinfo.c @@ -198,8 +198,13 @@

static void handle_category_key(struct coreinfo_cat *cat, int key) { - if (key >= 'a' && key <= 'z') { - int index = key - 'a'; + if ((key >= 'a' && key <= 'z') || (key >= 'A' && key <= 'Z')) { + int index; + if (key >= 'A' && key <= 'Z') { + index = key - 'A'; + } else { + index = key - 'a'; + } if (index < cat->count) { cat->cur = index; redraw_module(cat);

-- To view, visit https://review.coreboot.org/c/coreboot/+/35538 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Gerrit-Change-Number: 35538 Gerrit-PatchSet: 3 Gerrit-Owner: Name of user not set #1002476 Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Name of user not set #1002476 Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1668

days inactive

1677

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Arthur Heymans (Code Review)
Name of user not set (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)