View Change

1 comment:

• File payloads/coreinfo/coreinfo.c:

  • Patch Set #1, Line 203: 32

    Why this magic value?

    Moreover, this approach would modify 'key', which is used later on.

    Here's my suggested approach:

     int index;
     if (key >= 'A' && key <= 'Z') {
     	index = key - 'A';
     } else {
     	index = key - 'a';
     }

To view, visit change 35538. To unsubscribe, or for help writing mail filters, visit settings.