Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
coreinfo/coreinfo.c: Support both lower and upper case alphabets

Modify handle_category_key to handle both upper and lower case alphabets
in the coreinfo payload.

Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006
Signed-off-by: Himanshu Sahdev <himanshusah@hcl.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35538
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
---
M payloads/coreinfo/coreinfo.c
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/payloads/coreinfo/coreinfo.c b/payloads/coreinfo/coreinfo.c
index b731abf..53985b2 100644
--- a/payloads/coreinfo/coreinfo.c
+++ b/payloads/coreinfo/coreinfo.c
@@ -198,8 +198,13 @@

static void handle_category_key(struct coreinfo_cat *cat, int key)
{
- if (key >= 'a' && key <= 'z') {
- int index = key - 'a';
+ if ((key >= 'a' && key <= 'z') || (key >= 'A' && key <= 'Z')) {
+ int index;
+ if (key >= 'A' && key <= 'Z') {
+ index = key - 'A';
+ } else {
+ index = key - 'a';
+ }
if (index < cat->count) {
cat->cur = index;
redraw_module(cat);

To view, visit change 35538. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006
Gerrit-Change-Number: 35538
Gerrit-PatchSet: 3
Gerrit-Owner: Name of user not set #1002476
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Name of user not set #1002476
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged