Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35538 )
Change subject: coreinfo/coreinfo.c: Support both lower and upper case alphabets ......................................................................
coreinfo/coreinfo.c: Support both lower and upper case alphabets
Modify handle_category_key to handle both upper and lower case alphabets in the coreinfo payload.
Change-Id: I3ccbf69e90ba7824ad6ec85d2ca59aa8f40b3006 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35538 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M payloads/coreinfo/coreinfo.c 1 file changed, 7 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/payloads/coreinfo/coreinfo.c b/payloads/coreinfo/coreinfo.c index b731abf..53985b2 100644 --- a/payloads/coreinfo/coreinfo.c +++ b/payloads/coreinfo/coreinfo.c @@ -198,8 +198,13 @@
static void handle_category_key(struct coreinfo_cat *cat, int key) { - if (key >= 'a' && key <= 'z') { - int index = key - 'a'; + if ((key >= 'a' && key <= 'z') || (key >= 'A' && key <= 'Z')) { + int index; + if (key >= 'A' && key <= 'Z') { + index = key - 'A'; + } else { + index = key - 'a'; + } if (index < cat->count) { cat->cur = index; redraw_module(cat);