Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47313 )
Change subject: mb/google/zork: Add timestamps around forced delay ......................................................................
mb/google/zork: Add timestamps around forced delay
Due to a hardware design change, early boards need an additional delay when initializing the fingerprint sensor. Add a timestamp around the delay so it can be subtracted from the timestamp calculation if desired.
BUG=b:171837716 TEST=Look at new timestamp data BRANCH=Zork
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I801f0af6ef54f92865fd627dee12bb023cef534f --- M src/mainboard/google/zork/variants/berknip/gpio.c M src/mainboard/google/zork/variants/morphius/gpio.c 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/47313/1
diff --git a/src/mainboard/google/zork/variants/berknip/gpio.c b/src/mainboard/google/zork/variants/berknip/gpio.c index a4d5a64..b91078e 100644 --- a/src/mainboard/google/zork/variants/berknip/gpio.c +++ b/src/mainboard/google/zork/variants/berknip/gpio.c @@ -7,6 +7,7 @@ #include <gpio.h> #include <soc/gpio.h> #include <ec/google/chromeec/ec.h> +#include <timestamp.h>
static const struct soc_amd_gpio berknip_bid1_gpio_set_stage_ram[] = { /* PEN_DETECT_ODL - no used */ @@ -64,7 +65,9 @@
/* Berknip board versions prior to v4 need an extra delay here */ if (board_version <= 3) { + timestamp_add_now(TS_DELAY_START); mdelay(550); + timestamp_add_now(TS_DELAY_END); } /* * Enable the FPMCU by enabling EN_PWR_FP, then bringing it out diff --git a/src/mainboard/google/zork/variants/morphius/gpio.c b/src/mainboard/google/zork/variants/morphius/gpio.c index 14211b2..4f2781c 100644 --- a/src/mainboard/google/zork/variants/morphius/gpio.c +++ b/src/mainboard/google/zork/variants/morphius/gpio.c @@ -7,6 +7,7 @@ #include <gpio.h> #include <soc/gpio.h> #include <ec/google/chromeec/ec.h> +#include <timestamp.h>
static const struct soc_amd_gpio morphius_bid1_gpio_set_stage_ram[] = { /* DMIC_SEL */ @@ -99,7 +100,9 @@
/* Morphius board versions prior to v5 need an extra delay here */ if (board_version <= 4) { + timestamp_add_now(TS_DELAY_START); mdelay(550); + timestamp_add_now(TS_DELAY_END); } /* * Enable the FPMCU by enabling EN_PWR_FP, then bringing it out
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47313 )
Change subject: mb/google/zork: Add timestamps around forced delay ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47313 )
Change subject: mb/google/zork: Add timestamps around forced delay ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47313/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/47313/2/src/mainboard/google/zork/v... PS2, Line 70: timestamp_add_now(TS_DELAY_END); An info level log would be nice to have too.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47313 )
Change subject: mb/google/zork: Add timestamps around forced delay ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47313/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/47313/2/src/mainboard/google/zork/v... PS2, Line 70: timestamp_add_now(TS_DELAY_END);
An info level log would be nice to have too.
That doesn't seem useful when stored in cbmem (we already have timestamps) while it would significantly skew boot time on serial?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47313 )
Change subject: mb/google/zork: Add timestamps around forced delay ......................................................................
Patch Set 2: Code-Review+2
I wonder if there's a generic way to measure time spent waiting
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47313 )
Change subject: mb/google/zork: Add timestamps around forced delay ......................................................................
Patch Set 2:
this seems to need a rebase
Attention is currently required from: Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47313 )
Change subject: mb/google/zork: Add timestamps around forced delay ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: this code has moved from the variant boards to gpio_baseboard_trembyle.c. not sure if this is still needed/wanted or not
Martin Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47313 )
Change subject: mb/google/zork: Add timestamps around forced delay ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Felix Held (Code Review)
-
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)