Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47019 )
Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................
mb/google/variant/elemi: config CSE LITE
Config elemi to use CSE LITE
BUG=b:170604353 TEST=emerge-volteer coreboot
Change-Id: I31c7a743645d6a34ee34e750ba92c108b306ee09 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/47019/1
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 23e27ca..908c55b 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -71,4 +71,5 @@ config BOARD_GOOGLE_ELEMI bool "-> Elemi" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU select USE_CAR_NEM_ENHANCED_V2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47019 )
Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... PS1, Line 74: SOC_INTEL_CSE_LITE_SKU Looking at the list of boards here, I think SOC_INTEL_CSE_LITE_SKU is now being selected for all boards except boldar (which I think should also be using Lite SKU).
Tim/Nick - any reason not to move this selection under BOARD_GOOGLE_BASEBOARD_VOLTEER in Kconfig instead of having each board select it?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47019 )
Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... PS1, Line 74: SOC_INTEL_CSE_LITE_SKU
Looking at the list of boards here, I think SOC_INTEL_CSE_LITE_SKU is now being selected for all boa […]
At this point, that probably makes sense.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47019 )
Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................
Patch Set 2: Code-Review+2
Let's just keep this one in Wisley's stack, and I'll come back and do the Kconfig refactor in another patch.
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47019 )
Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... PS1, Line 74: SOC_INTEL_CSE_LITE_SKU
At this point, that probably makes sense.
Ack
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47019 )
Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................
mb/google/variant/elemi: config CSE LITE
Config elemi to use CSE LITE
BUG=b:170604353 TEST=emerge-volteer coreboot
Change-Id: I31c7a743645d6a34ee34e750ba92c108b306ee09 Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47019 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 8f966ee..6c9248e 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -80,6 +80,7 @@ config BOARD_GOOGLE_ELEMI bool "-> Elemi" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU select USE_CAR_NEM_ENHANCED_V2
config BOARD_GOOGLE_VOEMA