jitao shi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
mb/google/kukui: Fix backlight flash white before show logo
Move the panel power on after backlight off.
BUG=b:155107047 TEST=make # board = kukui
Signed-off-by: Jitao Shi jitao.shi@mediatek.com Change-Id: I0f31923bd7c1dfa26d4b1bbd0a230ae400b08ca3 --- M src/mainboard/google/kukui/mainboard.c 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/41146/1
diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index bb36d90..d5a1bf4 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -139,13 +139,16 @@
static bool configure_display(void) { - struct panel_description *panel = get_active_panel(); - if (!panel) - return false; + struct panel_description *panel;
mtcmos_display_power_on(); mtcmos_protect_display_bus(); configure_panel_backlight(); + + panel = get_active_panel(); + if (!panel) + return false; + power_on_panel(panel);
struct edid *edid = &panel->s->edid;
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... PS1, Line 144: mtcmos_display_power_on(); : mtcmos_protect_display_bus(); Are these two required before configure_panel_backlight()?
If not, maybe we should just move configure_panel_backlight() to the very beginning.
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... PS1, Line 148: panel = get_active_panel(); Can you check if this enabling panel AFTER backlight won't cause unexpected flash on both Jacuzzi (w/edp bridge) and Kukui (directly MIPI) family?
Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... PS1, Line 144: mtcmos_display_power_on(); : mtcmos_protect_display_bus();
Are these two required before configure_panel_backlight()? […]
OK, i'll move configure_panel_backlight() before "struct panel_description *panel = get_active_panel();"
static bool configure_display(void) { configure_panel_backlight(); struct panel_description *panel = get_active_panel(); if (!panel) return false; ...... }
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... PS1, Line 148: panel = get_active_panel();
Can you check if this enabling panel AFTER backlight won't cause unexpected flash on both Jacuzzi (w […]
The root cause of this issue is the leaking of level-shift(1.8v to 3.3v) Kukui (directly MIPI) doesn't have this circuit, so kukui won't happen this issue.
I have tested it on kappa platform. This patch works well.
Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... PS1, Line 148: panel = get_active_panel();
The root cause of this issue is the leaking of level-shift(1.8v to 3.3v) […]
EN_LCD_BL pin's default mode is input. If the PP3300_EDP_DX_R turn on before EN_LCD_BL output low. The Q705(level shift) will leak. and EN_LCD_BL will have 0.7V. And the CON_EDP_BKLTEN_3V3 is high. So the backlight will be poweron.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... PS1, Line 148: panel = get_active_panel();
EN_LCD_BL pin's default mode is input. […]
So this is a problem specific to anx7625 or ps8640 right? I'm wondering if it'll make sense if we configure EN_LCD_BL in the power_on_anx7625 before turning on PP3300_EDP_DX_R
Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... PS1, Line 148: panel = get_active_panel();
So this is a problem specific to anx7625 or ps8640 right? […]
Yes, only happen on the platform with anx7625 or ps8640. Sure, It is right moving the backlight pin control to panel poweron. I'll update this.
Hello Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41146
to look at the new patch set (#2).
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
mb/google/kukui: Fix backlight flash white before show logo
Turn backlight off before panel poweron
BUG=b:155107047 TEST=make # board = kukui
Signed-off-by: Jitao Shi jitao.shi@mediatek.com Change-Id: I0f31923bd7c1dfa26d4b1bbd0a230ae400b08ca3 --- M src/mainboard/google/kukui/panel_ps8640.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/41146/2
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 2:
(1 comment)
I think you need to apply same changes for panel_anxXXXX as well.
https://review.coreboot.org/c/coreboot/+/41146/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_ps8640.c:
https://review.coreboot.org/c/coreboot/+/41146/2/src/mainboard/google/kukui/... PS2, Line 16: gpio_output(GPIO(PERIPHERAL_EN13), 0); : gpio_output(GPIO(DISP_PWM), 0); Please add few comments, for example
/* Disable backlight before turning on bridge. */ gpio_output(GPIO(PERIPHERAL_EN13), 0); gpio_output(GPIO(DISP_PWM), 0);
/* Turn on bridge */ gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 0);
Hello Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41146
to look at the new patch set (#3).
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
mb/google/kukui: Fix backlight flash white before show logo
Turn backlight off before panel poweron
BUG=b:155107047 TEST=make # board = kukui
Signed-off-by: Jitao Shi jitao.shi@mediatek.com Change-Id: I0f31923bd7c1dfa26d4b1bbd0a230ae400b08ca3 --- M src/mainboard/google/kukui/panel_anx7625.c M src/mainboard/google/kukui/panel_ps8640.c 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/41146/3
Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 3:
(3 comments)
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... PS1, Line 144: mtcmos_display_power_on(); : mtcmos_protect_display_bus();
OK, i'll move configure_panel_backlight() before "struct panel_description *panel = get_active_panel […]
Done
https://review.coreboot.org/c/coreboot/+/41146/1/src/mainboard/google/kukui/... PS1, Line 148: panel = get_active_panel();
Yes, only happen on the platform with anx7625 or ps8640. […]
Done
https://review.coreboot.org/c/coreboot/+/41146/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_ps8640.c:
https://review.coreboot.org/c/coreboot/+/41146/2/src/mainboard/google/kukui/... PS2, Line 16: gpio_output(GPIO(PERIPHERAL_EN13), 0); : gpio_output(GPIO(DISP_PWM), 0);
Please add few comments, for example […]
Done
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 3: Code-Review+2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41146/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41146/3//COMMIT_MSG@9 PS3, Line 9: poweron nit: missing "."
https://review.coreboot.org/c/coreboot/+/41146/3//COMMIT_MSG@10 PS3, Line 10: BRANCH=kukui
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 3: -Code-Review
Please address yuping's comments.
Hello Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41146
to look at the new patch set (#4).
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
mb/google/kukui: Fix backlight flash white before show logo
Turn backlight off before panel poweron.
BUG=b:155107047 TEST=make # board = kukui BRANCH=kukui
Signed-off-by: Jitao Shi jitao.shi@mediatek.com Change-Id: I0f31923bd7c1dfa26d4b1bbd0a230ae400b08ca3 --- M src/mainboard/google/kukui/panel_anx7625.c M src/mainboard/google/kukui/panel_ps8640.c 2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/41146/4
Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41146/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41146/3//COMMIT_MSG@9 PS3, Line 9: poweron
nit: missing ". […]
Done
https://review.coreboot.org/c/coreboot/+/41146/3//COMMIT_MSG@10 PS3, Line 10:
BRANCH=kukui
Done
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 4: Code-Review+2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 4: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
mb/google/kukui: Fix backlight flash white before show logo
Turn backlight off before panel poweron.
BUG=b:155107047 TEST=make # board = kukui BRANCH=kukui
Signed-off-by: Jitao Shi jitao.shi@mediatek.com Change-Id: I0f31923bd7c1dfa26d4b1bbd0a230ae400b08ca3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41146 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/panel_anx7625.c M src/mainboard/google/kukui/panel_ps8640.c 2 files changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kukui/panel_anx7625.c b/src/mainboard/google/kukui/panel_anx7625.c index c75f260..b900881 100644 --- a/src/mainboard/google/kukui/panel_anx7625.c +++ b/src/mainboard/google/kukui/panel_anx7625.c @@ -14,6 +14,11 @@
static void power_on_anx7625(void) { + /* Disable backlight before turning on bridge */ + gpio_output(GPIO(PERIPHERAL_EN13), 0); + gpio_output(GPIO(DISP_PWM), 0); + + /* Turn on bridge */ gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 0); gpio_output(GPIO_PP1200_MIPIBRDG_EN, 1); gpio_output(GPIO_VDDIO_MIPIBRDG_EN, 1); diff --git a/src/mainboard/google/kukui/panel_ps8640.c b/src/mainboard/google/kukui/panel_ps8640.c index 43ea68e..1f7506e 100644 --- a/src/mainboard/google/kukui/panel_ps8640.c +++ b/src/mainboard/google/kukui/panel_ps8640.c @@ -13,6 +13,11 @@
static void power_on_ps8640(void) { + /* Disable backlight before turning on bridge */ + gpio_output(GPIO(PERIPHERAL_EN13), 0); + gpio_output(GPIO(DISP_PWM), 0); + + /* Turn on bridge */ gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 0); gpio_output(GPIO_PP1200_MIPIBRDG_EN, 1); gpio_output(GPIO_VDDIO_MIPIBRDG_EN, 1);
-
Hung-Te Lin (Code Review) -
Jitao Shi (Code Review)
-
jitao shi (Code Review)
-
Patrick Georgi (Code Review)
-
Yu-Ping Wu (Code Review)