Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: update for mb/ocp/tiogapass ......................................................................
MAINTAINERS: update for mb/ocp/tiogapass
Change-Id: Ia48f20ca8c21d3c645c5566c189dddf2f8bc0308 --- M MAINTAINERS 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/40966/1
diff --git a/MAINTAINERS b/MAINTAINERS index bc1e1fc..3531292 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -362,6 +362,16 @@ S: Maintained F: src/mainboard/facebook/monolith/
+OCP TIOGAPASS MAINBOARD +M: Jonathan Zhang jonzhang@fb.com +M: Reddy Chagam anjaneya.chagam@intel.com +M: Johnny Lin Johnny_Lin@wiwynn.com +M: Morgan Jang Morgan_Jang@wiwynn.com +M: Ryback Hung <Ryback.Hung@quantatw.com +M: Bryant Ou Bryant.Ou@quantatw.com +S: Maintained +F: src/mainboard/ocp/tiogapass + PORTWELL PQ-M107 MAINBOARD M: Frans Hendriks fhendriks@eltan.com M: Wim Vervoorn wvervoorn@eltan.com
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: update for mb/ocp/tiogapass ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Signed-off-by line is missing.
https://review.coreboot.org/c/coreboot/+/40966/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40966/1//COMMIT_MSG@7 PS1, Line 7: update for Just *Update* for a verb.
Or, to be clear that it’s a new entry:
Add entry for mb/ocp/tiogapass
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: update for mb/ocp/tiogapass ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40966/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40966/1//COMMIT_MSG@7 PS1, Line 7: update for
Just *Update* for a verb. […]
Done
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40966
to look at the new patch set (#2).
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
MAINTAINERS: Add entry for mb/ocp/tiogapass
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: Ia48f20ca8c21d3c645c5566c189dddf2f8bc0308 --- M MAINTAINERS 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/40966/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
Patch Set 2: Code-Review+1
I added all the listed maintainers in CC. Would be great if they all gave +1, also to see that they are hooked up correctly in Gerrit.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40966/2/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/40966/2/MAINTAINERS@372 PS2, Line 372: Maintained Maybe this should be Supported instead?
Supported: Someone is continuously paid to look after this and a reaction to review requests can be expected within a few days, a month at most.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40966/2/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/40966/2/MAINTAINERS@372 PS2, Line 372: Maintained
Maybe this should be Supported instead? […]
We were paid to do the Proof-Of-Concept on TiogaPass, but we are not paid to support it (we are shifting focus to next generation of Xeon-SP that is not MP'ed yet). That being said, we will do our best to react to review requests within a few days, a month at most. How about us changing the status to "Supported" once there is at least one IBV signing up for it? There are activities going on, but cannot be disclosed at the moment.
Anjaneya "Reddy" Chagam has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
Patch Set 3: Code-Review+1
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40966/2/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/40966/2/MAINTAINERS@372 PS2, Line 372: Maintained
We were paid to do the Proof-Of-Concept on TiogaPass, but we are not paid to support it (we are shif […]
sounds good to me
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40966/2/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/40966/2/MAINTAINERS@372 PS2, Line 372: Maintained
sounds good to me
Ack
Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
Patch Set 3: Code-Review+1
Patch Set 2: Code-Review+1
I added all the listed maintainers in CC. Would be great if they all gave +1, also to see that they are hooked up correctly in Gerrit.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
Patch Set 3: Code-Review+1
Morgan Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40966 )
Change subject: MAINTAINERS: Add entry for mb/ocp/tiogapass ......................................................................
MAINTAINERS: Add entry for mb/ocp/tiogapass
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: Ia48f20ca8c21d3c645c5566c189dddf2f8bc0308 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40966 Reviewed-by: Anjaneya "Reddy" Chagam anjaneya.chagam@intel.com Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Bryant Ou bryant.ou.q@gmail.com Reviewed-by: Johnny Lin Reviewed-by: Morgan Jang Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M MAINTAINERS 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved Angel Pons: Looks good to me, approved Johnny Lin: Looks good to me, but someone else must approve Morgan Jang: Looks good to me, but someone else must approve Anjaneya "Reddy" Chagam: Looks good to me, but someone else must approve Bryant Ou: Looks good to me, but someone else must approve
diff --git a/MAINTAINERS b/MAINTAINERS index bc1e1fc..3531292 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -362,6 +362,16 @@ S: Maintained F: src/mainboard/facebook/monolith/
+OCP TIOGAPASS MAINBOARD +M: Jonathan Zhang jonzhang@fb.com +M: Reddy Chagam anjaneya.chagam@intel.com +M: Johnny Lin Johnny_Lin@wiwynn.com +M: Morgan Jang Morgan_Jang@wiwynn.com +M: Ryback Hung <Ryback.Hung@quantatw.com +M: Bryant Ou Bryant.Ou@quantatw.com +S: Maintained +F: src/mainboard/ocp/tiogapass + PORTWELL PQ-M107 MAINBOARD M: Frans Hendriks fhendriks@eltan.com M: Wim Vervoorn wvervoorn@eltan.com
-
Angel Pons (Code Review) -
Anjaneya "Reddy" Chagam (Code Review)
-
Bryant Ou (Code Review)
-
Felix Held (Code Review)
-
Johnny Lin (Code Review)
-
Jonathan Zhang (Code Review)
-
Morgan Jang (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)