Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41116 )
Change subject: soc/intel/xeon_sp: make CPX ramstage.h common for CPX, SKX ......................................................................
soc/intel/xeon_sp: make CPX ramstage.h common for CPX, SKX
CB:41106 revealed that mb/intel/cedarisland already sets FSP-S UPD (see CB:40735) while the required includes are still missing in CPX. Buildbot did not fail because `ramstage.c` never was (implicitly) included.
Fix this problem by making SKX/CPX share a common ramstage header for now by moving the one from SKX.
Test: Build cedarisland_crb
Change-Id: I9cd25edd167ec71ee98c7ffa4fa6f95ca73a75e9 Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/41116 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Maxim Polyakov max.senia.poliak@gmail.com --- D src/soc/intel/xeon_sp/cpx/include/soc/ramstage.h R src/soc/intel/xeon_sp/include/soc/ramstage.h 2 files changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Maxim Polyakov: Looks good to me, approved
diff --git a/src/soc/intel/xeon_sp/cpx/include/soc/ramstage.h b/src/soc/intel/xeon_sp/cpx/include/soc/ramstage.h deleted file mode 100644 index 28e8d1a..0000000 --- a/src/soc/intel/xeon_sp/cpx/include/soc/ramstage.h +++ /dev/null @@ -1,6 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* This file is part of the coreboot project. */ - -#include <device/device.h> - -extern struct pci_operations soc_pci_ops; diff --git a/src/soc/intel/xeon_sp/skx/include/soc/ramstage.h b/src/soc/intel/xeon_sp/include/soc/ramstage.h similarity index 100% rename from src/soc/intel/xeon_sp/skx/include/soc/ramstage.h rename to src/soc/intel/xeon_sp/include/soc/ramstage.h