Change in coreboot[master]: mb/google/kukui: add dsi flag MIPI_DSI_MODE_EOT_PACKET for anx7625

[Paul Ma (Code Review)]

Paul Ma has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41161 )

Change subject: mb/google/kukui: add dsi flag MIPI_DSI_MODE_EOT_PACKET for anx7625
......................................................................

mb/google/kukui: add dsi flag MIPI_DSI_MODE_EOT_PACKET for anx7625

MIPI_DSI_MODE_EOT_PACKET is required for anx7625 to work correctly.

BUG=b:144824303
TEST=boot damu board, edp panel with anx7625 as bridge boot up
     normally.

Signed-off-by: Paul Ma 
Change-Id: Iad651202bde2a40024af8c12153143ada2ce2439
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/41161/1

diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c
index bb36d90..efcd49e 100644
--- a/src/mainboard/google/kukui/mainboard.c
+++ b/src/mainboard/google/kukui/mainboard.c
@@ -154,6 +154,8 @@
    u32 mipi_dsi_flags = (MIPI_DSI_MODE_VIDEO |
    		      MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
    		      MIPI_DSI_MODE_LPM);
+	if (CONFIG(DRIVER_ANALOGIX_ANX7625))
+		mipi_dsi_flags |= MIPI_DSI_MODE_EOT_PACKET;
    if (mtk_dsi_init(mipi_dsi_flags, MIPI_DSI_FMT_RGB888, 4, edid,
    		 panel->s->init) < 0) {
    	printk(BIOS_ERR, "%s: Failed in DSI init.\n", __func__);

[Paul Ma (Code Review)]

Paul Ma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41161 )

Change subject: mb/google/kukui: add dsi flag MIPI_DSI_MODE_EOT_PACKET for anx7625
......................................................................

Patch Set 1:

Add MIPI_DSI_MODE_EOT_PACKET flag for anx7625 as kernel does. Please help review, this CL help to fix 12" panel scrolling issue. thanks,

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41161 )

Change subject: mb/google/kukui: add dsi flag MIPI_DSI_MODE_EOT_PACKET for anx7625
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/c/coreboot/+/41161/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41161/1//COMMIT_MSG@7 
PS1, Line 7: add dsi flag MIPI_DSI_MODE_EOT_PACKET for anx7625
Please explain what you're fixing instead of 'how' here.

For example "fix screen scrolling on devices using anx7625" (not sure if this is the right issue you've fixed by this flag)

https://review.coreboot.org/c/coreboot/+/41161/1//COMMIT_MSG@9 
PS1, Line 9: work correctly
maybe you can explain what may happen if the flag isn't set.

https://review.coreboot.org/c/coreboot/+/41161/1//COMMIT_MSG@11 
PS1, Line 11: BUG
Please add BRANCH=kukui so we'll know this should be cherry-picked into fw branch

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41161 )

Change subject: mb/google/kukui: add dsi flag MIPI_DSI_MODE_EOT_PACKET for anx7625
......................................................................

Patch Set 1:

if you have an equivalent change in kernel side, please also include that reference in commit message.

Change in coreboot[master]: mb/google/kukui: fix screen scrolling on devices using anx7625

[Paul Ma (Code Review)]

Hello Hung-Te Lin, build bot (Jenkins), Jitao Shi, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41161

to look at the new patch set (#2).

Change subject: mb/google/kukui: fix screen scrolling on devices using anx7625
......................................................................

mb/google/kukui: fix screen scrolling on devices using anx7625

anx7625 enable MIPI receiver to check EOTP packet as default.
If MIPI_DSI_MODE_EOT_PACKET not set in flags, soc dsi will not
send out EOTP packet and some panels will display abnormal such
as scrolling.

BUG=b:144824303
BRANCH=kukui
TEST=boot damu board, edp panel with anx7625 as bridge boot up
     normally.

Signed-off-by: Paul Ma 
Change-Id: Iad651202bde2a40024af8c12153143ada2ce2439
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/41161/2

Change in coreboot[master]: mb/google/kukui: fix screen scrolling on devices using anx7625

[Paul Ma (Code Review)]

Paul Ma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41161 )

Change subject: mb/google/kukui: fix screen scrolling on devices using anx7625
......................................................................

Patch Set 2:

(3 comments)
> Patch Set 1:
>
> if you have an equivalent change in kernel side, please also include that reference in commit message.

Kernel has had this flags set already, no kernel change this time.

https://review.coreboot.org/c/coreboot/+/41161/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41161/1//COMMIT_MSG@7 
PS1, Line 7: add dsi flag MIPI_DSI_MODE_EOT_PACKET for anx7625
> Please explain what you're fixing instead of 'how' here. […]

Done

https://review.coreboot.org/c/coreboot/+/41161/1//COMMIT_MSG@9 
PS1, Line 9: work correctly
> maybe you can explain what may happen if the flag isn't set.

Done

https://review.coreboot.org/c/coreboot/+/41161/1//COMMIT_MSG@11 
PS1, Line 11: BUG
> Please add BRANCH=kukui so we'll know this should be cherry-picked into fw branch

Done

Change in coreboot[master]: mb/google/kukui: fix screen scrolling on devices using anx7625

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41161 )

Change subject: mb/google/kukui: fix screen scrolling on devices using anx7625
......................................................................

Patch Set 2:

(5 comments)

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG@9 
PS2, Line 9: enable
enables

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG@10 
PS2, Line 10: not set
is not set

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG@11 
PS2, Line 11: some panels
Is that random, or certain production batches?

Is that a board design limitation? If it’s a general problem, can’t it be fixed in the driver, and not on a mainboard basis?

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG@12 
PS2, Line 12: as scrolling.
Only during boot-up, or the whole time, that means when the OS is running?

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG@16 
PS2, Line 16: boot
boots

Change in coreboot[master]: mb/google/kukui: fix screen scrolling on devices using anx7625

[Paul Ma (Code Review)]

Hello Hung-Te Lin, build bot (Jenkins), Jitao Shi, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41161

to look at the new patch set (#3).

Change subject: mb/google/kukui: fix screen scrolling on devices using anx7625
......................................................................

mb/google/kukui: fix screen scrolling on devices using anx7625

anx7625 enables MIPI receiver to check EOTP packet as default.
If MIPI_DSI_MODE_EOT_PACKET is not set in flags, soc dsi will not
send out EOTP packet and some panel models will display abnormal
such as scrolling all the time.

BUG=b:144824303
BRANCH=kukui
TEST=boot damu board, edp panel with anx7625 as bridge boots up
     without scrolling.

Signed-off-by: Paul Ma 
Change-Id: Iad651202bde2a40024af8c12153143ada2ce2439
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/41161/3

Change in coreboot[master]: mb/google/kukui: fix screen scrolling on devices using anx7625

[Paul Ma (Code Review)]

Paul Ma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41161 )

Change subject: mb/google/kukui: fix screen scrolling on devices using anx7625
......................................................................

Patch Set 3:

(5 comments)

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG@9 
PS2, Line 9: enable
> enables

Done

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG@10 
PS2, Line 10: not set
> is not set

Done

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG@11 
PS2, Line 11: some panels
> Is that random, or certain production batches? […]

Some panel model will have this issue. Some kukui derived projects such as tablets do not use anx7625 as bridge. projects derived from jacuzzi use anx7625 and all these project will define DRIVER_ANALOGIX_ANX7625, so referring to it should be OK.

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG@12 
PS2, Line 12: as scrolling.
> Only during boot-up, or the whole time, that means when the OS is running?

The whole time display will abnormal (scrolling), even in the process of OS booting and OS UI.

https://review.coreboot.org/c/coreboot/+/41161/2//COMMIT_MSG@16 
PS2, Line 16: boot
> boots

Done

Change in coreboot[master]: mb/google/kukui: fix screen scrolling on devices using anx7625

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41161 )

Change subject: mb/google/kukui: fix screen scrolling on devices using anx7625
......................................................................

Patch Set 3: Code-Review+1

Change in coreboot[master]: mb/google/kukui: fix screen scrolling on devices using anx7625

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41161 )

Change subject: mb/google/kukui: fix screen scrolling on devices using anx7625
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: mb/google/kukui: fix screen scrolling on devices using anx7625

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41161 )

Change subject: mb/google/kukui: fix screen scrolling on devices using anx7625
......................................................................

mb/google/kukui: fix screen scrolling on devices using anx7625

anx7625 enables MIPI receiver to check EOTP packet as default.
If MIPI_DSI_MODE_EOT_PACKET is not set in flags, soc dsi will not
send out EOTP packet and some panel models will display abnormal
such as scrolling all the time.

BUG=b:144824303
BRANCH=kukui
TEST=boot damu board, edp panel with anx7625 as bridge boots up
     without scrolling.

Signed-off-by: Paul Ma 
Change-Id: Iad651202bde2a40024af8c12153143ada2ce2439
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41161
Reviewed-by: Yu-Ping Wu 
Reviewed-by: Hung-Te Lin 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/kukui/mainboard.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Hung-Te Lin: Looks good to me, approved
  Yu-Ping Wu: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c
index bb36d90..efcd49e 100644
--- a/src/mainboard/google/kukui/mainboard.c
+++ b/src/mainboard/google/kukui/mainboard.c
@@ -154,6 +154,8 @@
    u32 mipi_dsi_flags = (MIPI_DSI_MODE_VIDEO |
    		      MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
    		      MIPI_DSI_MODE_LPM);
+	if (CONFIG(DRIVER_ANALOGIX_ANX7625))
+		mipi_dsi_flags |= MIPI_DSI_MODE_EOT_PACKET;
    if (mtk_dsi_init(mipi_dsi_flags, MIPI_DSI_FMT_RGB888, 4, edid,
    		 panel->s->init) < 0) {
    	printk(BIOS_ERR, "%s: Failed in DSI init.\n", __func__);