Change in coreboot[master]: mb/intel/jasperlake_rvp: Add support for SMI handler

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

mb/intel/jasperlake_rvp: Add support for SMI handler

SMI handler was not present in jasperlake rvp to handle wake events
when platform goes to sleep or shutdown or s0ix.
Adding this support for board which supports chromeec.

BUG=None
BRANCH=None
TEST=Check wake event on board and platform wakes up due to events
     lid wake event or power button press.

Change-Id: I8e35955b06d6efaf9275ec03f519c9bcaa9ba345
Signed-off-by: Maulik V Vaghela 
---
M src/mainboard/intel/jasperlake_rvp/Makefile.inc
A src/mainboard/intel/jasperlake_rvp/smihandler.c
2 files changed, 33 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/40853/1

diff --git a/src/mainboard/intel/jasperlake_rvp/Makefile.inc b/src/mainboard/intel/jasperlake_rvp/Makefile.inc
index 745e0cf..18a3a6d 100644
--- a/src/mainboard/intel/jasperlake_rvp/Makefile.inc
+++ b/src/mainboard/intel/jasperlake_rvp/Makefile.inc
@@ -27,6 +27,8 @@
 ramstage-y += mainboard.c
 ramstage-y += board_id.c

+smm-$(CONFIG_EC_GOOGLE_CHROMEEC) += smihandler.c
+
 subdirs-y += ../common
 subdirs-y += variants/baseboard
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include
diff --git a/src/mainboard/intel/jasperlake_rvp/smihandler.c b/src/mainboard/intel/jasperlake_rvp/smihandler.c
new file mode 100644
index 0000000..dad6052
--- /dev/null
+++ b/src/mainboard/intel/jasperlake_rvp/smihandler.c
@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */
+
+#include <baseboard/variants.h>
+#include <cpu/x86/smm.h>
+#include <ec/google/chromeec/ec.h>
+#include <ec/google/chromeec/smm.h>
+#include <elog.h>
+#include <intelblocks/smihandler.h>
+#include <variant/ec.h>
+
+void mainboard_smi_espi_handler(void)
+{
+	chromeec_smi_process_events();
+}
+
+void mainboard_smi_sleep(u8 slp_typ)
+{
+	chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS);
+}
+
+int mainboard_smi_apmc(u8 apmc)
+{
+	chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, MAINBOARD_EC_SMI_EVENTS);
+	return 0;
+}
+
+void elog_gsmi_cb_mainboard_log_wake_source(void)
+{
+	google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S3_WAKE_EVENTS);
+}

[Maulik V Vaghela (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40853

to look at the new patch set (#2).

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

mb/intel/jasperlake_rvp: Add support for SMI handler

SMI handler was not present in jasperlake rvp to handle wake events
when platform goes to sleep or shutdown or s0ix.
Adding this support for board which supports chromeec.

BUG=None
BRANCH=None
TEST=Check wake event on board and platform wakes up due to events
     lid wake event or power button press.

Change-Id: I8e35955b06d6efaf9275ec03f519c9bcaa9ba345
Signed-off-by: Maulik V Vaghela 
---
M src/mainboard/intel/jasperlake_rvp/Makefile.inc
A src/mainboard/intel/jasperlake_rvp/smihandler.c
2 files changed, 40 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/40853/2

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/40853/2/src/mainboard/intel/jasperl... 
File src/mainboard/intel/jasperlake_rvp/smihandler.c:

https://review.coreboot.org/c/coreboot/+/40853/2/src/mainboard/intel/jasperl... 
PS2, Line 21: 		chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS,\
Avoid unnecessary line continuations

https://review.coreboot.org/c/coreboot/+/40853/2/src/mainboard/intel/jasperl... 
PS2, Line 29: 	
trailing whitespace

https://review.coreboot.org/c/coreboot/+/40853/2/src/mainboard/intel/jasperl... 
PS2, Line 36: 		google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |\
Avoid unnecessary line continuations

[Maulik V Vaghela (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40853

to look at the new patch set (#3).

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

mb/intel/jasperlake_rvp: Add support for SMI handler

SMI handler was not present in jasperlake rvp to handle wake events
when platform goes to sleep or shutdown or s0ix.
Adding this support for board which supports chromeec.

BUG=None
BRANCH=None
TEST=Check wake event on board and platform wakes up due to events
     lid wake event or power button press.

Change-Id: I8e35955b06d6efaf9275ec03f519c9bcaa9ba345
Signed-off-by: Maulik V Vaghela 
---
M src/mainboard/intel/jasperlake_rvp/Makefile.inc
A src/mainboard/intel/jasperlake_rvp/smihandler.c
2 files changed, 38 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/40853/3

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40853/3/src/mainboard/intel/jasperl... 
File src/mainboard/intel/jasperlake_rvp/smihandler.c:

https://review.coreboot.org/c/coreboot/+/40853/3/src/mainboard/intel/jasperl... 
PS3, Line 21: 		chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS);
line over 96 characters

https://review.coreboot.org/c/coreboot/+/40853/3/src/mainboard/intel/jasperl... 
PS3, Line 35: 		google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S3_WAKE_EVENTS);
line over 96 characters

[Maulik V Vaghela (Code Review)]

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40853

to look at the new patch set (#4).

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

mb/intel/jasperlake_rvp: Add support for SMI handler

SMI handler was not present in jasperlake rvp to handle wake events
when platform goes to sleep or shutdown or s0ix.
Adding this support for board which supports chromeec.

BUG=None
BRANCH=None
TEST=Check wake event on board and platform wakes up due to events
     lid wake event or power button press.

Change-Id: I8e35955b06d6efaf9275ec03f519c9bcaa9ba345
Signed-off-by: Maulik V Vaghela 
---
M src/mainboard/intel/jasperlake_rvp/Makefile.inc
A src/mainboard/intel/jasperlake_rvp/smihandler.c
2 files changed, 40 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/40853/4

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40853/4/src/mainboard/intel/jasperl... 
File src/mainboard/intel/jasperlake_rvp/smihandler.c:

https://review.coreboot.org/c/coreboot/+/40853/4/src/mainboard/intel/jasperl... 
PS4, Line 21: 		chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS,\
Avoid unnecessary line continuations

https://review.coreboot.org/c/coreboot/+/40853/4/src/mainboard/intel/jasperl... 
PS4, Line 36: 		google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |\
Avoid unnecessary line continuations

[Ronak Kanabar (Code Review)]

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

Patch Set 4: Code-Review+1

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

Patch Set 4: Code-Review+2

[Ronak Kanabar (Code Review)]

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

Patch Set 4: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40853/4/src/mainboard/intel/jasperl... 
File src/mainboard/intel/jasperlake_rvp/smihandler.c:

https://review.coreboot.org/c/coreboot/+/40853/4/src/mainboard/intel/jasperl... 
PS4, Line 21: 		chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS,\
> Avoid unnecessary line continuations

could you please take care of these? otherwise the commit looks good.

[Maulik V Vaghela (Code Review)]

Hello V Sowmya, build bot (Jenkins), Patrick Georgi, Martin Roth, Rizwan Qureshi, Subrata Banik, Meera Ravindranath, Sooraj Govindan, Ronak Kanabar, Aamir Bohra,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40853

to look at the new patch set (#5).

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

mb/intel/jasperlake_rvp: Add support for SMI handler

SMI handler was not present in jasperlake rvp to handle wake events
when platform goes to sleep or shutdown or s0ix.
Adding this support for board which supports chromeec.

BUG=None
BRANCH=None
TEST=Check wake event on board and platform wakes up due to events
     lid wake event or power button press.

Change-Id: I8e35955b06d6efaf9275ec03f519c9bcaa9ba345
Signed-off-by: Maulik V Vaghela 
---
M src/mainboard/intel/jasperlake_rvp/Makefile.inc
A src/mainboard/intel/jasperlake_rvp/smihandler.c
2 files changed, 40 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/40853/5

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40853/4/src/mainboard/intel/jasperl... 
File src/mainboard/intel/jasperlake_rvp/smihandler.c:

https://review.coreboot.org/c/coreboot/+/40853/4/src/mainboard/intel/jasperl... 
PS4, Line 21: 		chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS,\
> could you please take care of these? otherwise the commit looks good.

Done

https://review.coreboot.org/c/coreboot/+/40853/4/src/mainboard/intel/jasperl... 
PS4, Line 36: 		google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |\
> Avoid unnecessary line continuations

Done

[Ronak Kanabar (Code Review)]

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

Patch Set 5: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40853 )

Change subject: mb/intel/jasperlake_rvp: Add support for SMI handler
......................................................................

mb/intel/jasperlake_rvp: Add support for SMI handler

SMI handler was not present in jasperlake rvp to handle wake events
when platform goes to sleep or shutdown or s0ix.
Adding this support for board which supports chromeec.

BUG=None
BRANCH=None
TEST=Check wake event on board and platform wakes up due to events
     lid wake event or power button press.

Change-Id: I8e35955b06d6efaf9275ec03f519c9bcaa9ba345
Signed-off-by: Maulik V Vaghela 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40853
Tested-by: build bot (Jenkins) 
Reviewed-by: Ronak Kanabar 
---
M src/mainboard/intel/jasperlake_rvp/Makefile.inc
A src/mainboard/intel/jasperlake_rvp/smihandler.c
2 files changed, 40 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Ronak Kanabar: Looks good to me, approved

diff --git a/src/mainboard/intel/jasperlake_rvp/Makefile.inc b/src/mainboard/intel/jasperlake_rvp/Makefile.inc
index 28684e2..a8c261b 100644
--- a/src/mainboard/intel/jasperlake_rvp/Makefile.inc
+++ b/src/mainboard/intel/jasperlake_rvp/Makefile.inc
@@ -19,6 +19,8 @@
 ramstage-y += mainboard.c
 ramstage-y += board_id.c

+smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c
+
 subdirs-y += ../common
 subdirs-y += variants/baseboard
 CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include
diff --git a/src/mainboard/intel/jasperlake_rvp/smihandler.c b/src/mainboard/intel/jasperlake_rvp/smihandler.c
new file mode 100644
index 0000000..c06da29
--- /dev/null
+++ b/src/mainboard/intel/jasperlake_rvp/smihandler.c
@@ -0,0 +1,38 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */
+
+#include <baseboard/variants.h>
+#include <cpu/x86/smm.h>
+#include <ec/google/chromeec/ec.h>
+#include <ec/google/chromeec/smm.h>
+#include <elog.h>
+#include <intelblocks/smihandler.h>
+#include <baseboard/ec.h>
+
+void mainboard_smi_espi_handler(void)
+{
+	if (CONFIG(EC_GOOGLE_CHROMEEC))
+		chromeec_smi_process_events();
+}
+
+void mainboard_smi_sleep(u8 slp_typ)
+{
+	if (CONFIG(EC_GOOGLE_CHROMEEC))
+		chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS,
+					MAINBOARD_EC_S5_WAKE_EVENTS);
+}
+
+int mainboard_smi_apmc(u8 apmc)
+{
+	if (CONFIG(EC_GOOGLE_CHROMEEC))
+		chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, MAINBOARD_EC_SMI_EVENTS);
+
+	return 0;
+}
+
+void elog_gsmi_cb_mainboard_log_wake_source(void)
+{
+	if (CONFIG(EC_GOOGLE_CHROMEEC))
+		google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS |
+					MAINBOARD_EC_S3_WAKE_EVENTS);
+}