Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41146 )
Change subject: mb/google/kukui: Fix backlight flash white before show logo ......................................................................
Patch Set 2:
(1 comment)
I think you need to apply same changes for panel_anxXXXX as well.
https://review.coreboot.org/c/coreboot/+/41146/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_ps8640.c:
https://review.coreboot.org/c/coreboot/+/41146/2/src/mainboard/google/kukui/... PS2, Line 16: gpio_output(GPIO(PERIPHERAL_EN13), 0); : gpio_output(GPIO(DISP_PWM), 0); Please add few comments, for example
/* Disable backlight before turning on bridge. */ gpio_output(GPIO(PERIPHERAL_EN13), 0); gpio_output(GPIO(DISP_PWM), 0);
/* Turn on bridge */ gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 0);