Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46231 )
Change subject: soc/intel/xeon_sp: Enable SMI handler ......................................................................
Patch Set 18:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46231/16/src/soc/intel/xeon_sp/Kcon... File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/46231/16/src/soc/intel/xeon_sp/Kcon... PS16, Line 66: REG_SCRIPT
W-why?
the code in soc/intel/xeon_sp/pmc.c used it :-(
With SMM this code is actually used so the linker actually complains about undefined reference to reg_script_run_on_dev
https://review.coreboot.org/c/coreboot/+/46231/16/src/soc/intel/xeon_sp/skx/... File src/soc/intel/xeon_sp/skx/cpu.c:
https://review.coreboot.org/c/coreboot/+/46231/16/src/soc/intel/xeon_sp/skx/... PS16, Line 215: 1 << 12
`4 * KiB` would also work and IMHO would be more readable
Done
https://review.coreboot.org/c/coreboot/+/46231/16/src/soc/intel/xeon_sp/smih... File src/soc/intel/xeon_sp/smihandler.c:
https://review.coreboot.org/c/coreboot/+/46231/16/src/soc/intel/xeon_sp/smih... PS16, Line 2: /* This file is part of the coreboot project. */
This comment should be gone
Done
-
Arthur Heymans (Code Review)