Change in coreboot[master]: dedede: Create metaknight variant

[Tim Chen (Code Review)]

Hello Tim Chen,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/46568

to review the following change.

Change subject: dedede: Create metaknight variant
......................................................................

dedede: Create metaknight variant

Create the metaknight variant of the waddledee reference board by
copying the template files to a new directory named for the variant.

(Auto-Generated by create_coreboot_variant.sh version 4.2.0).

BUG=b:169813211
BRANCH=None
TEST=util/abuild/abuild -p none -t google/dedede -x -a
make sure the build includes GOOGLE_METAKNIGHT

Signed-off-by: Tim Chen 
Change-Id: Ia2e473eb1d0a2c819b874e497de0823fca75645a
---
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/dedede/Kconfig.name
A src/mainboard/google/dedede/variants/metaknight/include/variant/ec.h
A src/mainboard/google/dedede/variants/metaknight/include/variant/gpio.h
A src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc
A src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt
A src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt
A src/mainboard/google/dedede/variants/metaknight/overridetree.cb
8 files changed, 77 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/46568/1

diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig
index 377702d..a273c9c 100644
--- a/src/mainboard/google/dedede/Kconfig
+++ b/src/mainboard/google/dedede/Kconfig
@@ -94,6 +94,7 @@
    default "Waddledee" if BOARD_GOOGLE_WADDLEDEE
    default "Wheelie" if BOARD_GOOGLE_WHEELIE
    default "Magolor" if BOARD_GOOGLE_MAGOLOR
+	default "Metaknight" if BOARD_GOOGLE_METAKNIGHT

config MAX_CPUS
    int
@@ -123,5 +124,6 @@
    default "waddledee" if BOARD_GOOGLE_WADDLEDEE
    default "wheelie" if BOARD_GOOGLE_WHEELIE
    default "magolor" if BOARD_GOOGLE_MAGOLOR
+	default "metaknight" if BOARD_GOOGLE_METAKNIGHT

endif #BOARD_GOOGLE_BASEBOARD_DEDEDE
diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name
index 563a309..689df68 100644
--- a/src/mainboard/google/dedede/Kconfig.name
+++ b/src/mainboard/google/dedede/Kconfig.name
@@ -63,3 +63,8 @@
    select BASEBOARD_DEDEDE_LAPTOP
    select DRIVERS_INTEL_MIPI_CAMERA
    select SOC_INTEL_COMMON_BLOCK_IPU
+
+config BOARD_GOOGLE_METAKNIGHT
+	bool "-> Metaknight"
+	select BOARD_GOOGLE_BASEBOARD_DEDEDE
+	select BASEBOARD_DEDEDE_LAPTOP
diff --git a/src/mainboard/google/dedede/variants/metaknight/include/variant/ec.h b/src/mainboard/google/dedede/variants/metaknight/include/variant/ec.h
new file mode 100644
index 0000000..08870e0
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/metaknight/include/variant/ec.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef MAINBOARD_EC_H
+#define MAINBOARD_EC_H
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/dedede/variants/metaknight/include/variant/gpio.h b/src/mainboard/google/dedede/variants/metaknight/include/variant/gpio.h
new file mode 100644
index 0000000..9078664
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/metaknight/include/variant/gpio.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef MAINBOARD_GPIO_H
+#define MAINBOARD_GPIO_H
+
+#include <baseboard/gpio.h>
+
+#endif /* MAINBOARD_GPIO_H */
diff --git a/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc b/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc
new file mode 100644
index 0000000..b0ca222
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/metaknight/memory/Makefile.inc
@@ -0,0 +1,5 @@
+## SPDX-License-Identifier: GPL-2.0-or-later
+## This is an auto-generated file. Do not edit!!
+## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
+
+SPD_SOURCES = placeholder.spd.hex
diff --git a/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt
new file mode 100644
index 0000000..fa24790
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/metaknight/memory/dram_id.generated.txt
@@ -0,0 +1 @@
+DRAM Part Name                 ID to assign
diff --git a/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt
new file mode 100644
index 0000000..59381dc
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/metaknight/memory/mem_parts_used.txt
@@ -0,0 +1,6 @@
+# This is a CSV file containing a list of memory parts used by this variant.
+# Generate an updated Makefile.inc and dram_id.generated.txt by running the
+# gen_part_id tool from util/spd_tools/lp4x
+# See util/spd_tools/lp4x/README.md for more details and instructions.
+
+# Part Name
diff --git a/src/mainboard/google/dedede/variants/metaknight/overridetree.cb b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
new file mode 100644
index 0000000..404024b
--- /dev/null
+++ b/src/mainboard/google/dedede/variants/metaknight/overridetree.cb
@@ -0,0 +1,42 @@
+chip soc/intel/jasperlake
+
+	# Intel Common SoC Config
+	#+-------------------+---------------------------+
+	#| Field             |  Value                    |
+	#+-------------------+---------------------------+
+	#| GSPI0             | cr50 TPM. Early init is   |
+	#|                   | required to set up a BAR  |
+	#|                   | for TPM communication     |
+	#|                   | before memory is up       |
+	#| I2C0              | Trackpad                  |
+	#| I2C1              | Digitizer                 |
+	#| I2C2              | Touchscreen               |
+	#| I2C3              | Camera                    |
+	#| I2C4              | Audio                     |
+	#+-------------------+---------------------------+
+	register "common_soc_config" = "{
+		.gspi[0] = {
+			.speed_mhz = 1,
+			.early_init = 1,
+		},
+		.i2c[0] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[1] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[2] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[3] = {
+			.speed = I2C_SPEED_FAST,
+		},
+		.i2c[4] = {
+			.speed = I2C_SPEED_FAST,
+		},
+	}"
+
+	device domain 0 on
+		device pci 15.0 on end
+	end
+end