Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45142 )
Change subject: geminilake: Factor out MAX_CPUS value ......................................................................
geminilake: Factor out MAX_CPUS value
Both Gemini Lake boards in the tree use the same value.
Change-Id: Ib6bd05206026736fd7e3d44b49e4d8ba217c2708 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/octopus/Kconfig M src/mainboard/intel/glkrvp/Kconfig M src/soc/intel/apollolake/Kconfig 3 files changed, 4 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/45142/1
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 4c0cdff..b9c6a1b 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -97,10 +97,6 @@ string default "Google_Octopus"
-config MAX_CPUS - int - default 4 - config UART_FOR_CONSOLE int default 2 diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index 86920ca..7b1b564 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -68,10 +68,6 @@ string default "Intel_Glkrvp" if BOARD_INTEL_GLKRVP
-config MAX_CPUS - int - default 4 - config UART_FOR_CONSOLE int default 2 diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index 7467f28..08710d2 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -107,6 +107,10 @@ select INTEL_GMA_SWSMISCI select HAVE_ASAN_IN_ROMSTAGE
+config MAX_CPUS + int + default 4 if SOC_INTEL_GEMINILAKE + config CHROMEOS select CHROMEOS_RAMOOPS_DYNAMIC
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45142 )
Change subject: geminilake: Factor out MAX_CPUS value ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45142 )
Change subject: geminilake: Factor out MAX_CPUS value ......................................................................
geminilake: Factor out MAX_CPUS value
Both Gemini Lake boards in the tree use the same value.
Change-Id: Ib6bd05206026736fd7e3d44b49e4d8ba217c2708 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45142 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/google/octopus/Kconfig M src/mainboard/intel/glkrvp/Kconfig M src/soc/intel/apollolake/Kconfig 3 files changed, 4 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 4c0cdff..b9c6a1b 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -97,10 +97,6 @@ string default "Google_Octopus"
-config MAX_CPUS - int - default 4 - config UART_FOR_CONSOLE int default 2 diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index 86920ca..7b1b564 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -68,10 +68,6 @@ string default "Intel_Glkrvp" if BOARD_INTEL_GLKRVP
-config MAX_CPUS - int - default 4 - config UART_FOR_CONSOLE int default 2 diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index fec0fc9..f5d9323 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -108,6 +108,10 @@ select INTEL_GMA_SWSMISCI select HAVE_ASAN_IN_ROMSTAGE
+config MAX_CPUS + int + default 4 if SOC_INTEL_GEMINILAKE + config CHROMEOS select CHROMEOS_RAMOOPS_DYNAMIC
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45142 )
Change subject: geminilake: Factor out MAX_CPUS value ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18384 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18383 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/18382 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18381 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/18380 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/18387 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18386 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18385
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)