Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/28393 )
Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.... File src/mainboard/lenovo/t430s/romstage.c:
https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.... PS2, Line 72: enum hybrid_graphics_req mode = HYBRID_GRAPHICS_INTEGRATED;
Sorry for the confusion. […]
There's a third way. We could move this code (I'm talking about the code that writes to pmh7 registers) to pmh7.c and call it `pmh7_dgpu_enable`, like `pmh7_backlight_enable` and other functions that are already there. This way we will not use hybrid graphics driver for T430s and also not duplicate dGPU on/off code.
-
Evgeny Zinoviev (Code Review)