Change in coreboot[4.11_branch]: mb/ocp/monolake: Override SMBIOS data with IPMI read FRU data
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37445 )
Change subject: mb/ocp/monolake: Override SMBIOS data with IPMI read FRU data ......................................................................
Patch Set 8: Code-Review-1
(1 comment)
Minor nit, otherwise looks good to me.
https://review.coreboot.org/c/coreboot/+/37445/8/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37445/8/src/mainboard/ocp/monolake/... PS8, Line 133: } else nit: use braces for the else clauses, since the if clauses are multiple lines
(See https://doc.coreboot.org/coding_style.html#placing-braces-and-spaces, in the example before the Spaces section)
-
David Hendricks (Code Review)