Minor nit, otherwise looks good to me.

Patch set 8:Code-Review -1

View Change

1 comment:

• File src/mainboard/ocp/monolake/mainboard.c:

  • Patch Set #8, Line 133: } else

    nit: use braces for the else clauses, since the if clauses are multiple lines

    (See https://doc.coreboot.org/coding_style.html#placing-braces-and-spaces, in the example before the Spaces section)

To view, visit change 37445. To unsubscribe, or for help writing mail filters, visit settings.