Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44559 )
Change subject: mb/google/volteer: Update SLP_Sx assertion widths and PwrCycDur ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44559/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44559/2/src/mainboard/google/voltee... PS2, Line 152: 3
MinAssertDur50ms
Tim, with current common code implementation, I think this definition cannot be used directly here to set the correct value. To add more information about the list of values to set, I updated more comments for each parameter. Please let me know if this looks okay. Thank you.
https://review.coreboot.org/c/coreboot/+/44559/2/src/mainboard/google/voltee... PS2, Line 153: 1
MinAssertDur1s
Same as above.
https://review.coreboot.org/c/coreboot/+/44559/2/src/mainboard/google/voltee... PS2, Line 154: 3
MinAssertDur1s
Same as above.
https://review.coreboot.org/c/coreboot/+/44559/2/src/mainboard/google/voltee... PS2, Line 155: 3
MinAssertDur98ms
Same as above.