Change in coreboot[master]: crossgcc: Upgrade GMP to v6.2.0

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

18 Jan 2020 18 Jan '20

4:46 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38465 )

Change subject: crossgcc: Upgrade GMP to v6.2.0 ......................................................................

crossgcc: Upgrade GMP to v6.2.0

gmp_freebsd-configure.patch is integrated in upstream so we don't need them anymore.

Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc D util/crossgcc/patches/gmp-6.1.2_freebsd-configure.patch D util/crossgcc/sum/gmp-6.1.2.tar.xz.cksum A util/crossgcc/sum/gmp-6.2.0.tar.xz.cksum 4 files changed, 2 insertions(+), 22 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/38465/1

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index ab2ea89..c9609e0 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -47,7 +47,7 @@ THREADS=1

# GCC toolchain version numbers -GMP_VERSION=6.1.2 +GMP_VERSION=6.2.0 MPFR_VERSION=4.0.2 MPC_VERSION=1.1.0 GCC_VERSION=8.3.0 diff --git a/util/crossgcc/patches/gmp-6.1.2_freebsd-configure.patch b/util/crossgcc/patches/gmp-6.1.2_freebsd-configure.patch deleted file mode 100644 index 5770af6..0000000 --- a/util/crossgcc/patches/gmp-6.1.2_freebsd-configure.patch +++ /dev/null @@ -1,20 +0,0 @@ ---- gmp-6.1.2.orig/configure 2016-12-16 16:45:32.000000000 +0100 -+++ gmp-6.1.2/configure 2017-03-08 14:26:11.194245000 +0100 -@@ -6776,7 +6776,7 @@ - long i; - for (i = 0; i < 88 + 1; i++) - a[i] = ~0L; -- r = malloc (10000 * sizeof (unsigned long)); -+ r = calloc (10000, sizeof (unsigned long)); - r2 = r; - for (i = 0; i < 528; i += 23) - { -@@ -8394,7 +8394,7 @@ - long i; - for (i = 0; i < 88 + 1; i++) - a[i] = ~0L; -- r = malloc (10000 * sizeof (unsigned long)); -+ r = calloc (10000, sizeof (unsigned long)); - r2 = r; - for (i = 0; i < 528; i += 23) - { diff --git a/util/crossgcc/sum/gmp-6.1.2.tar.xz.cksum b/util/crossgcc/sum/gmp-6.1.2.tar.xz.cksum deleted file mode 100644 index 774658c..0000000 --- a/util/crossgcc/sum/gmp-6.1.2.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -9dc6981197a7d92f339192eea974f5eca48fcffe tarballs/gmp-6.1.2.tar.xz diff --git a/util/crossgcc/sum/gmp-6.2.0.tar.xz.cksum b/util/crossgcc/sum/gmp-6.2.0.tar.xz.cksum new file mode 100644 index 0000000..b00b669 --- /dev/null +++ b/util/crossgcc/sum/gmp-6.2.0.tar.xz.cksum @@ -0,0 +1 @@ +052a5411dc74054240eec58132d2cf41211d0ff6 tarballs/gmp-6.2.0.tar.xz

Attachments:

attachment.htm (text/html — 5.2 KB)

Show replies by date

HAOUAS Elyes (Code Review)

18 Jan 18 Jan

4:49 p.m.

Hello Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38465

to look at the new patch set (#2).

Change subject: crossgcc: Upgrade GMP to v6.2.0 ......................................................................

crossgcc: Upgrade GMP to v6.2.0

gmp_freebsd-configure.patch is integrated in upstream so we don't need it anymore.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/38465/2

Idwer Vollering (Code Review)

19 Jan 19 Jan

1:37 p.m.

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38465 )

Change subject: crossgcc: Upgrade GMP to v6.2.0 ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 19 Jan 2020 13:37:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

27 Feb 27 Feb

11:48 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38465 )

Change subject: crossgcc: Upgrade GMP to v6.2.0 ......................................................................

Patch Set 2:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 27 Feb 2020 11:48:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11:49 a.m.

New subject: Change in coreboot[master]: [WIP]crossgcc: Upgrade GMP to v6.2.0

Hello Idwer Vollering, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38465

to look at the new patch set (#3).

Change subject: [WIP]crossgcc: Upgrade GMP to v6.2.0 ......................................................................

[WIP]crossgcc: Upgrade GMP to v6.2.0

gmp_freebsd-configure.patch is integrated in upstream so we don't need it anymore.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/38465/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

30 Mar 30 Mar

7:18 a.m.

New subject: Change in coreboot[master]: [WIP]crossgcc: Upgrade GMP to v6.2.0

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38465 )

Change subject: [WIP]crossgcc: Upgrade GMP to v6.2.0 ......................................................................

Patch Set 6: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38465/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38465/6//COMMIT_MSG@10 PS6, Line 10: so we don't need it anymore. Re-flow for 72/75 characters per line?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 30 Mar 2020 07:18:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:47 a.m.

New subject: Change in coreboot[master]: [WIP]crossgcc: Upgrade GMP to v6.2.0

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38465 )

Change subject: [WIP]crossgcc: Upgrade GMP to v6.2.0 ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38465/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/38465/6//COMMIT_MSG@10 PS6, Line 10: so we don't need it anymore.

...

Re-flow for 72/75 characters per line?

Done. thank you

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 30 Mar 2020 09:47:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:47 a.m.

New subject: Change in coreboot[master]: [WIP]crossgcc: Upgrade GMP to v6.2.0

Hello build bot (Jenkins), Patrick Georgi, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38465

to look at the new patch set (#8).

Change subject: [WIP]crossgcc: Upgrade GMP to v6.2.0 ......................................................................

[WIP]crossgcc: Upgrade GMP to v6.2.0

gmp_freebsd-configure.patch is integrated in upstream so we don't need it anymore.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/38465/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

9:49 a.m.

New subject: Change in coreboot[master]: [WIP]crossgcc: Upgrade GMP to v6.2.0

Hello build bot (Jenkins), Patrick Georgi, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38465

to look at the new patch set (#9).

Change subject: [WIP]crossgcc: Upgrade GMP to v6.2.0 ......................................................................

[WIP]crossgcc: Upgrade GMP to v6.2.0

gmp_freebsd-configure.patch is integrated in upstream so we don't need it anymore.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/38465/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

10:14 a.m.

Hello build bot (Jenkins), Patrick Georgi, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38465

to look at the new patch set (#10).

Change subject: crossgcc: Upgrade GMP to v6.2.0 ......................................................................

crossgcc: Upgrade GMP to v6.2.0

gmp_freebsd-configure.patch is integrated in upstream so we don't need it anymore.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/38465/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

25 Jul 25 Jul

8:20 a.m.

Hello build bot (Jenkins), Patrick Georgi, Idwer Vollering, Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38465

to look at the new patch set (#21).

Change subject: crossgcc: Upgrade GMP to v6.2.0 ......................................................................

crossgcc: Upgrade GMP to v6.2.0

gmp_freebsd-configure.patch is integrated in upstream so we don't need it anymore. Changes: https://gmplib.org/gmp6.2

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/38465/21

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 21 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Christian Walter (Code Review)

11 Aug 11 Aug

8:34 p.m.

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38465 )

Change subject: crossgcc: Upgrade GMP to v6.2.0 ......................................................................

Patch Set 22: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 22 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 11 Aug 2020 20:34:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

17 Aug 17 Aug

7:03 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38465 )

Change subject: crossgcc: Upgrade GMP to v6.2.0 ......................................................................

crossgcc: Upgrade GMP to v6.2.0

gmp_freebsd-configure.patch is integrated in upstream so we don't need it anymore. Changes: https://gmplib.org/gmp6.2

Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38465 Reviewed-by: Christian Walter christian.walter@9elements.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Idwer Vollering vidwer@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/crossgcc/buildgcc D util/crossgcc/patches/gmp-6.1.2_freebsd-configure.patch D util/crossgcc/sum/gmp-6.1.2.tar.xz.cksum A util/crossgcc/sum/gmp-6.2.0.tar.xz.cksum 4 files changed, 2 insertions(+), 22 deletions(-)

Approvals: build bot (Jenkins): Verified Idwer Vollering: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve Christian Walter: Looks good to me, approved

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index dc59ce1..10f858f 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -33,7 +33,7 @@ THREADS=1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38465 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8404872f1b65e9173c1fcbd24d7da7bdd7937503 Gerrit-Change-Number: 38465 Gerrit-PatchSet: 24 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Christian Walter christian.walter@9elements.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1591

days inactive

1803

days old

coreboot-gerrit@coreboot.org

12 comments

5 participants

tags (0)

participants (5)

Christian Walter (Code Review)
HAOUAS Elyes (Code Review)
Idwer Vollering (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)