Nico Huber has posted comments on this change. ( https://review.coreboot.org/28862 )
Change subject: sb/intel/common: Add common reset handler ......................................................................
Patch Set 2:
(1 comment)
Now I'm wondering: With nb/intel/fsp_rangeley fixed, would it build w/o a do_soft_reset() implementation?
I've never seen any Intel chipset that would not do a hard reset if it detects a prior soft reset. So having a do_soft_reset() for Intel doesn't make much sense.
The situation is even more annyoing if you look at soc/intel/common/. They just redefined the meaning of the different resets.
https://review.coreboot.org/#/c/28862/2/src/southbridge/intel/fsp_rangeley/r... File src/southbridge/intel/fsp_rangeley/reset.c:
https://review.coreboot.org/#/c/28862/2/src/southbridge/intel/fsp_rangeley/r... PS2, Line 23: Guess who seems to be the only one calling soft_reset()? it's nb/intel/fsp_rangeley... That call should be fixed, I guess.
-
Nico Huber (Code Review)