Now I'm wondering: With nb/intel/fsp_rangeley fixed, would it build
w/o a do_soft_reset() implementation?

I've never seen any Intel chipset that would not do a hard reset if
it detects a prior soft reset. So having a do_soft_reset() for Intel
doesn't make much sense.

The situation is even more annyoing if you look at soc/intel/common/.
They just redefined the meaning of the different resets.

View Change

1 comment:

To view, visit change 28862. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e359b0c4d5a1060edd0940d24c2f78dfed8a590
Gerrit-Change-Number: 28862
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Alexandru Gagniuc <alexandrux.gagniuc@intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 13:48:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No