Change in coreboot[master]: sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37341 )

Change subject: sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1'
......................................................................

sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1'

Error found using -Wconversion on mainboard/macbook21/static.c

Change-Id: I23d7b876f778ab78e922709a0a36f5eec4d60e3d
Signed-off-by: Elyes HAOUAS 
---
M src/southbridge/intel/i82801gx/chip.h
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/37341/1

diff --git a/src/southbridge/intel/i82801gx/chip.h b/src/southbridge/intel/i82801gx/chip.h
index 75b9575..f844515 100644
--- a/src/southbridge/intel/i82801gx/chip.h
+++ b/src/southbridge/intel/i82801gx/chip.h
@@ -76,9 +76,9 @@
    /* Enable linear PCIe Root Port function numbers starting at zero */
    uint8_t pcie_port_coalesce;

-	int c4onc3_enable:1;
-	int docking_supported:1;
-	int p_cnt_throttling_supported:1;
+	signed char c4onc3_enable:1;
+	signed char docking_supported:1;
+	signed char p_cnt_throttling_supported:1;
    int c3_latency;

/* Additional LPC IO decode ranges */

[HAOUAS Elyes (Code Review)]

Hello Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37341

to look at the new patch set (#2).

Change subject: sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1'
......................................................................

sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1'

Error found using -Wconversion on mainboard/macbook21/static.c:
"error: conversion from 'int' to 'signed char:1' changes value from '1' to '-1'"

Change-Id: I23d7b876f778ab78e922709a0a36f5eec4d60e3d
Signed-off-by: Elyes HAOUAS 
---
M src/southbridge/intel/i82801gx/chip.h
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/37341/2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37341 )

Change subject: sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1'
......................................................................

Abandoned

see 34092