Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33377 )
Change subject: soc/intel/common/block/xhci: Add API to disable USB devices ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33377/5/src/soc/intel/common/block/... File src/soc/intel/common/block/xhci/xhci.c:
https://review.coreboot.org/c/coreboot/+/33377/5/src/soc/intel/common/block/... PS5, Line 52: false
Just thinking out loud: If BAR is not allocated to XHCI, this would end up disabling all internal po […]
I thought about it too. But wasn't sure to leave them enabled or disabled. It seems you are hinting to leave it enabled if BAR is not allocated.
https://review.coreboot.org/c/coreboot/+/33377/5/src/soc/intel/common/block/... PS5, Line 85: false
nit: If you set this to true by default, then you won't need the else case for ext_usb_xhci_en_cb
That works too.
-
Karthik Ramasubramanian (Code Review)