Change in ...coreboot[master]: mb/google/octopus: Fix termination for unused dual voltage pins
Shamile Khan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30823
Change subject: mb/google/octopus: Fix termination for unused dual voltage pins ......................................................................
mb/google/octopus: Fix termination for unused dual voltage pins
These pins should not have pull downs configured in standby state as that can cause contention on the termination circuitry and lead to incorrect behavior as per Doc# 572688 Gemini Lake Processor GPIOTermination Configuration.
BUG=b:79982669 TEST=Checked that code compiles with changes.
Change-Id: If3cadc000ec6fc56019ee3f57e556dc819d5e0a5 Signed-off-by: Shamile Khan shamile.khan@intel.com --- M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/30823/1
diff --git a/src/mainboard/google/octopus/variants/casta/gpio.c b/src/mainboard/google/octopus/variants/casta/gpio.c index ba26e31..d061cb2 100644 --- a/src/mainboard/google/octopus/variants/casta/gpio.c +++ b/src/mainboard/google/octopus/variants/casta/gpio.c @@ -27,11 +27,11 @@
PAD_NC(GPIO_67, UP_20K), /* EN_PP3300_DX_LTE_SOC -- unused */
- PAD_NC(GPIO_105, DN_20K), /* TOUCHSCREEN_RST -- unused */ + PAD_NC(GPIO_105, UP_20K), /* TOUCHSCREEN_RST -- unused */ PAD_NC(GPIO_108, NONE), /* PMU_SUSCLK -- unused */
- PAD_NC(GPIO_114, DN_20K), /* I2C7 Touchscreen -- unused */ - PAD_NC(GPIO_115, DN_20K), /* I2C7 Touchscreen -- unused */ + PAD_NC(GPIO_114, UP_20K), /* I2C7 Touchscreen -- unused */ + PAD_NC(GPIO_115, UP_20K), /* I2C7 Touchscreen -- unused */
PAD_NC(GPIO_117, UP_20K), /* PCIE_WAKE1_B - No LTE*/ PAD_NC(GPIO_119, UP_20K), /* PCIE_WAKE3_B - only use CNVI */ diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index 39d239b..b8db331 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -32,8 +32,8 @@ PAD_CFG_GPI_APIC_IOS(GPIO_134, NONE, DEEP, EDGE_SINGLE, INVERT, TxDRxE, DISPUPD),
- PAD_NC(GPIO_138, DN_20K), - PAD_NC(GPIO_139, DN_20K), + PAD_NC(GPIO_138, UP_20K), + PAD_NC(GPIO_139, UP_20K), PAD_NC(GPIO_140, UP_20K), PAD_NC(GPIO_143, UP_20K), PAD_NC(GPIO_144, UP_20K),
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30823 )
Change subject: mb/google/octopus: Fix termination for unused dual voltage pins ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30823 )
Change subject: mb/google/octopus: Fix termination for unused dual voltage pins ......................................................................
mb/google/octopus: Fix termination for unused dual voltage pins
These pins should not have pull downs configured in standby state as that can cause contention on the termination circuitry and lead to incorrect behavior as per Doc# 572688 Gemini Lake Processor GPIOTermination Configuration.
BUG=b:79982669 TEST=Checked that code compiles with changes.
Change-Id: If3cadc000ec6fc56019ee3f57e556dc819d5e0a5 Signed-off-by: Shamile Khan shamile.khan@intel.com Reviewed-on: https://review.coreboot.org/c/30823 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c 2 files changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/casta/gpio.c b/src/mainboard/google/octopus/variants/casta/gpio.c index 1746e4f..fcb7ab5 100644 --- a/src/mainboard/google/octopus/variants/casta/gpio.c +++ b/src/mainboard/google/octopus/variants/casta/gpio.c @@ -27,11 +27,11 @@
PAD_NC(GPIO_67, UP_20K), /* EN_PP3300_DX_LTE_SOC -- unused */
- PAD_NC(GPIO_105, DN_20K), /* TOUCHSCREEN_RST -- unused */ + PAD_NC(GPIO_105, UP_20K), /* TOUCHSCREEN_RST -- unused */ PAD_NC(GPIO_108, NONE), /* PMU_SUSCLK -- unused */
- PAD_NC(GPIO_114, DN_20K), /* I2C7 Touchscreen -- unused */ - PAD_NC(GPIO_115, DN_20K), /* I2C7 Touchscreen -- unused */ + PAD_NC(GPIO_114, UP_20K), /* I2C7 Touchscreen -- unused */ + PAD_NC(GPIO_115, UP_20K), /* I2C7 Touchscreen -- unused */
PAD_NC(GPIO_117, UP_20K), /* PCIE_WAKE1_B - No LTE*/ PAD_NC(GPIO_119, UP_20K), /* PCIE_WAKE3_B - only use CNVI */ diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index b1f377b..6bb78aa 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -28,8 +28,8 @@ PAD_NC(GPIO_67, UP_20K), PAD_NC(GPIO_117, UP_20K),
- PAD_NC(GPIO_138, DN_20K), - PAD_NC(GPIO_139, DN_20K), + PAD_NC(GPIO_138, UP_20K), + PAD_NC(GPIO_139, UP_20K), PAD_NC(GPIO_140, UP_20K), PAD_NC(GPIO_143, UP_20K), PAD_NC(GPIO_144, UP_20K),
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Shamile Khan (Code Review)