Change in coreboot[master]: vc/amd/fsp/picasso: Add bitfields for PSP info in transfer block
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45804 )
Change subject: vc/amd/fsp/picasso: Add bitfields for PSP info in transfer block ......................................................................
vc/amd/fsp/picasso: Add bitfields for PSP info in transfer block
BUG=b:168895748 TEST=None BRANCH=Zork
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I299fdd0f007f7e4a8f597931a52f68dc98acc9ac --- M src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45804/1
diff --git a/src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h b/src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h index 69ada34..684929d 100644 --- a/src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h +++ b/src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h @@ -54,6 +54,10 @@ #define SVC_SHA 0x46 #define SVC_RSAPKCS_VERIFY 0x47
+#define PSP_INFO_PRODUCTION_MODE 0x00000001UL +#define PSP_INFO_PRODUCTION_SI 0x00000002UL +#define PSP_INFO_VALID 0x80000000UL + typedef struct _RSAPSS_VERIFY_PARAMS_T { char *pHash; // Message digest to verify the RSA signature
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45804
to look at the new patch set (#2).
Change subject: vc/amd/fsp/picasso: Add bitfields for PSP info in transfer block ......................................................................
vc/amd/fsp/picasso: Add bitfields for PSP info in transfer block
BUG=b:168895748 TEST=None BRANCH=Zork
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I299fdd0f007f7e4a8f597931a52f68dc98acc9ac --- M src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45804/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45804
to look at the new patch set (#3).
Change subject: vc/amd/fsp/picasso: Add bit definitions for PSP info in transfer block ......................................................................
vc/amd/fsp/picasso: Add bit definitions for PSP info in transfer block
BUG=b:168895748 TEST=None BRANCH=Zork
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I299fdd0f007f7e4a8f597931a52f68dc98acc9ac --- M src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45804/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45804
to look at the new patch set (#4).
Change subject: vc/amd/fsp/picasso: Add bit definitions for PSP info in transfer block ......................................................................
vc/amd/fsp/picasso: Add bit definitions for PSP info in transfer block
BUG=b:168895748 TEST=None BRANCH=Zork
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I299fdd0f007f7e4a8f597931a52f68dc98acc9ac --- M src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45804/4
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45804 )
Change subject: vc/amd/fsp/picasso: Add bit definitions for PSP info in transfer block ......................................................................
Patch Set 4: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45804 )
Change subject: vc/amd/fsp/picasso: Add bit definitions for PSP info in transfer block ......................................................................
Patch Set 4: Code-Review+2
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45804 )
Change subject: vc/amd/fsp/picasso: Add bit definitions for PSP info in transfer block ......................................................................
vc/amd/fsp/picasso: Add bit definitions for PSP info in transfer block
BUG=b:168895748 TEST=None BRANCH=Zork
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I299fdd0f007f7e4a8f597931a52f68dc98acc9ac Reviewed-on: https://review.coreboot.org/c/coreboot/+/45804 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h b/src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h index 69ada34..7cc9fd4 100644 --- a/src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h +++ b/src/vendorcode/amd/fsp/picasso/include/bl_uapp/bl_syscall_public.h @@ -54,6 +54,11 @@ #define SVC_SHA 0x46 #define SVC_RSAPKCS_VERIFY 0x47
+/* Bit definitions for the psp_info field in the PSP transfer_info_struct */ +#define PSP_INFO_PRODUCTION_MODE 0x00000001UL +#define PSP_INFO_PRODUCTION_SILICON 0x00000002UL +#define PSP_INFO_VALID 0x80000000UL + typedef struct _RSAPSS_VERIFY_PARAMS_T { char *pHash; // Message digest to verify the RSA signature
-
Felix Held (Code Review) -
Martin Roth (Code Review)
-
Paul Fagerburg (Code Review)