Change in coreboot[master]: mb/google/zork: Temporary init for backlight in the OS

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Martin Roth (Code Review)

30 Sep 2020 30 Sep '20

1:05 a.m.

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45854 )

Change subject: mb/google/zork: Temporary init for backlight in the OS ......................................................................

mb/google/zork: Temporary init for backlight in the OS

This needs to go into ACPI, but that's taking me a while, so I figured I'd push this temporarily.

Not for merge.

Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea --- M src/mainboard/google/zork/smihandler.c 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/45854/1

diff --git a/src/mainboard/google/zork/smihandler.c b/src/mainboard/google/zork/smihandler.c index 12a3b64..6fc6f92 100644 --- a/src/mainboard/google/zork/smihandler.c +++ b/src/mainboard/google/zork/smihandler.c @@ -33,5 +33,9 @@ if (CONFIG(EC_GOOGLE_CHROMEEC)) chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, MAINBOARD_EC_SMI_EVENTS); + /* Temporary fix - Needs to go into ACPI instead */ + /* Turn on the backlight when we go to ACPI mode */ + gpio_set(GPIO_85, 0); + return 0; }

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Paul Menzel (Code Review)

30 Sep 30 Sep

6:36 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45854 )

Change subject: mb/google/zork: Temporary init for backlight in the OS ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45854/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45854/1//COMMIT_MSG@7 PS1, Line 7: Temporary Temporarily init backlight in the OS

Martin Roth (Code Review)

7:47 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45854

to look at the new patch set (#2).

Change subject: mb/google/zork: Temporary init for backlight in the OS ......................................................................

mb/google/zork: Temporary init for backlight in the OS

This fix needs to go into ACPI in the long-term, but this should suffice in the short-term.

Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea --- M src/mainboard/google/zork/smihandler.c 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/45854/2

Martin Roth (Code Review)

7:48 p.m.

New subject: Change in coreboot[master]: mb/google/zork: Initialize the backlight in the OS

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45854

to look at the new patch set (#3).

Change subject: mb/google/zork: Initialize the backlight in the OS ......................................................................

mb/google/zork: Initialize the backlight in the OS

This fix needs to go into ACPI in the long-term, but this should suffice in the short-term.

Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea --- M src/mainboard/google/zork/smihandler.c 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/45854/3

Martin Roth (Code Review)

7:50 p.m.

New subject: Change in coreboot[master]: mb/google/zork: Initialize the backlight in the OS

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45854

to look at the new patch set (#4).

Change subject: mb/google/zork: Initialize the backlight in the OS ......................................................................

mb/google/zork: Initialize the backlight in the OS

This fix needs to go into ACPI in the long-term, but this should suffice in the short-term.

BUG=b:158087989 TEST=Boot berknip, verify backlight is enabled. Test suspend & resume sequence, backlight is still enabled. BRANCH=Zork

Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea --- M src/mainboard/google/zork/smihandler.c 1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/45854/4

Martin Roth (Code Review)

7:52 p.m.

New subject: Change in coreboot[master]: mb/google/zork: Initialize the backlight in the OS

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45854 )

Change subject: mb/google/zork: Initialize the backlight in the OS ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45854/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45854/1//COMMIT_MSG@7 PS1, Line 7: Temporary

...

Temporarily init backlight in the OS

updated.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea Gerrit-Change-Number: 45854 Gerrit-PatchSet: 4 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-Comment-Date: Wed, 30 Sep 2020 17:52:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Martin Roth (Code Review)

9:52 p.m.

New subject: Change in coreboot[master]: mb/google/zork: Initialize the backlight in the OS

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45854

to look at the new patch set (#5).

Change subject: mb/google/zork: Initialize the backlight in the OS ......................................................................

mb/google/zork: Initialize the backlight in the OS

This fix needs to go into ACPI in the long-term, but this should suffice in the short-term.

BUG=b:158087989 TEST=Boot berknip, verify backlight is enabled. Test suspend & resume sequence, backlight is still enabled. BRANCH=Zork

Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea --- M src/mainboard/google/zork/smihandler.c 1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/45854/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/45854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea Gerrit-Change-Number: 45854 Gerrit-PatchSet: 5 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-MessageType: newpatchset

Marshall Dawson (Code Review)

9:53 p.m.

New subject: Change in coreboot[master]: mb/google/zork: Initialize the backlight in the OS

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45854 )

Change subject: mb/google/zork: Initialize the backlight in the OS ......................................................................

Patch Set 5: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45854/4/src/mainboard/google/zork/s... File src/mainboard/google/zork/smihandler.c:

https://review.coreboot.org/c/coreboot/+/45854/4/src/mainboard/google/zork/s... PS4, Line 38: gpio_set(GPIO_85, 0); Maybe the following if I understand your intent

if (apmc == APM_CNT_ACPI_ENABLE) gpio_set(GPIO_85, 0);

-- To view, visit https://review.coreboot.org/c/coreboot/+/45854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea Gerrit-Change-Number: 45854 Gerrit-PatchSet: 5 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-Comment-Date: Wed, 30 Sep 2020 19:53:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Marshall Dawson (Code Review)

9:54 p.m.

New subject: Change in coreboot[master]: mb/google/zork: Initialize the backlight in the OS

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45854 )

Change subject: mb/google/zork: Initialize the backlight in the OS ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45854/4/src/mainboard/google/zork/s... File src/mainboard/google/zork/smihandler.c:

https://review.coreboot.org/c/coreboot/+/45854/4/src/mainboard/google/zork/s... PS4, Line 38: gpio_set(GPIO_85, 0);

...

Maybe the following if I understand your intent […]

Ugh, forgot about my draft...

-- To view, visit https://review.coreboot.org/c/coreboot/+/45854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea Gerrit-Change-Number: 45854 Gerrit-PatchSet: 5 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-Comment-Date: Wed, 30 Sep 2020 19:54:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

1 Oct 1 Oct

2:47 a.m.

New subject: Change in coreboot[master]: mb/google/zork: Initialize the backlight in the OS

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45854 )

Change subject: mb/google/zork: Initialize the backlight in the OS ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea Gerrit-Change-Number: 45854 Gerrit-PatchSet: 5 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-Comment-Date: Thu, 01 Oct 2020 00:47:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

2:47 a.m.

New subject: Change in coreboot[master]: mb/google/zork: Initialize the backlight in the OS

Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45854 )

Change subject: mb/google/zork: Initialize the backlight in the OS ......................................................................

mb/google/zork: Initialize the backlight in the OS

This fix needs to go into ACPI in the long-term, but this should suffice in the short-term.

BUG=b:158087989 TEST=Boot berknip, verify backlight is enabled. Test suspend & resume sequence, backlight is still enabled. BRANCH=Zork

Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea Reviewed-on: https://review.coreboot.org/c/coreboot/+/45854 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/smihandler.c 1 file changed, 6 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/zork/smihandler.c b/src/mainboard/google/zork/smihandler.c index 12a3b64..6ef2704 100644 --- a/src/mainboard/google/zork/smihandler.c +++ b/src/mainboard/google/zork/smihandler.c @@ -33,5 +33,11 @@ if (CONFIG(EC_GOOGLE_CHROMEEC)) chromeec_smi_apmc(apmc, MAINBOARD_EC_SCI_EVENTS, MAINBOARD_EC_SMI_EVENTS); + + /* Temporary fix - Needs to go into ACPI instead */ + /* Turn on the backlight when we go to ACPI mode */ + if (apmc == APM_CNT_ACPI_ENABLE) + gpio_set(GPIO_85, 0); + return 0; }

-- To view, visit https://review.coreboot.org/c/coreboot/+/45854 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea Gerrit-Change-Number: 45854 Gerrit-PatchSet: 6 Gerrit-Owner: Martin Roth martinroth@google.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Eric Peers epeers@google.com Gerrit-CC: Felix Held felix-coreboot@felixheld.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rob Barnes robbarnes@google.com Gerrit-MessageType: merged

1302

days inactive

1304

days old

coreboot-gerrit@coreboot.org

10 comments

4 participants

tags (0)

participants (4)

Marshall Dawson (Code Review)
Martin Roth (Code Review)
Paul Fagerburg (Code Review)
Paul Menzel (Code Review)