Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31315 )
Change subject: arch/arm64: Make ARM64 specific options depend on ARCH_ARM64
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31315/5/src/arch/arm64/Kconfig
File src/arch/arm64/Kconfig:
https://review.coreboot.org/#/c/31315/5/src/arch/arm64/Kconfig@4
PS5, Line 4: if ARCH_ARM64
Why not put this below the individual stage options and then 'select ARCH_ARM64' from each of them? The stage options aren't visible in menuconfig anyway so it makes no difference, but it's one less option that SoCs need to select.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa9cd902281e51f823717f6ea4c72e5736fefb31
Gerrit-Change-Number: 31315
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 31 May 2019 21:48:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment