Change in coreboot[master]: soc/intel/common: Add support for CSE IOM/NPHY sub-parition update
Attention is currently required from: Tim Wawrzynczak, Julius Werner, Sridhar Siricilla. Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59685 )
Change subject: soc/intel/common: Add support for CSE IOM/NPHY sub-parition update ......................................................................
Patch Set 15:
(13 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
PS14:
Separate CL to enable this for ADL please
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/d96b9fff_c448ee69 PS14, Line 29: /* If SOC is not Alderlake A2, skip update */ : if (cpu_get_cpuid() != CPUID_ALDERLAKE_A2) { : printk(BIOS_INFO, "CSE Sub-partition update not required\n"); : return true; : } : return false;
I would rather keep the print in common code, and then this function just becomes: […]
Done
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/59685/comment/6a6f4d70_8bdd8aca PS11, Line 888: cbfs_locate_file_in_region
Looks like this API is getting deprecated. […]
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/89f092bb_de0a032e PS11, Line 1035: void cse_fw_sync(void)
cse_fw_sync() is being called from SoC romstage.c, but getting enabled from mainboard Kconfig. […]
Done
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/59685/comment/1d235717_56698a8a PS14, Line 743: uint16_t
`enum bpdt_entry_type`
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/f5fd219a_68ccc339 PS14, Line 756: uint16_t
`enum bpdt_entry_type `
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/133c1f6d_5d521c7a PS14, Line 799: uint16_t
`enum bpdt_entry_type`
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/f93f02c6_7637b72a PS14, Line 833: ptr + SUBPART_HEADER_SZ
It is technically illegal C to do pointer arithmetic on a `void *`, but GCC does allow it (and proba […]
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/0279c4bc_8f2a163c PS14, Line 855: uint16_t
`enum bpdt_entry_type`
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/9da8165c_872f36c7 PS14, Line 913:
nit: extra blank line
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/21f9442a_a95d6ad4 PS14, Line 997: /* : * If system is in recovery mode, don't trigger recovery again */
nit: single-line comment
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/a86f3eab_8af8166d PS14, Line 1018:
nit: extra space
Done
https://review.coreboot.org/c/coreboot/+/59685/comment/74e7a219_0a0183cd PS14, Line 1020: return;
nit: blank line after `}`
Done
-
Krishna P Bhat D (Code Review)