Attention is currently required from: Tim Wawrzynczak, Julius Werner, Sridhar Siricilla.
13 comments:
File src/soc/intel/alderlake/romstage/romstage.c:
Separate CL to enable this for ADL please
Done
/* If SOC is not Alderlake A2, skip update */
if (cpu_get_cpuid() != CPUID_ALDERLAKE_A2) {
printk(BIOS_INFO, "CSE Sub-partition update not required\n");
return true;
}
return false;
I would rather keep the print in common code, and then this function just becomes: […]
Done
File src/soc/intel/common/block/cse/cse_lite.c:
Patch Set #11, Line 888: cbfs_locate_file_in_region
Looks like this API is getting deprecated. […]
Done
Patch Set #11, Line 1035: void cse_fw_sync(void)
cse_fw_sync() is being called from SoC romstage.c, but getting enabled from mainboard Kconfig. […]
Done
File src/soc/intel/common/block/cse/cse_lite.c:
Patch Set #14, Line 743: uint16_t
`enum bpdt_entry_type`
Done
Patch Set #14, Line 756: uint16_t
`enum bpdt_entry_type `
Done
Patch Set #14, Line 799: uint16_t
`enum bpdt_entry_type`
Done
Patch Set #14, Line 833: ptr + SUBPART_HEADER_SZ
It is technically illegal C to do pointer arithmetic on a `void *`, but GCC does allow it (and proba […]
Done
Patch Set #14, Line 855: uint16_t
`enum bpdt_entry_type`
Done
nit: extra blank line
Done
/*
* If system is in recovery mode, don't trigger recovery again */
nit: single-line comment
Done
nit: extra space
Done
Patch Set #14, Line 1020: return;
nit: blank line after `}`
Done
To view, visit change 59685. To unsubscribe, or for help writing mail filters, visit settings.