Change in coreboot[master]: acpi: Bump SRAT revision to 3

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: acpi:...

HAOUAS Elyes (Code Review)

3 Jul 2020 3 Jul '20

5:25 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

Regarding ACPI spec 6.3, current SRAT version is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/1

diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index df733ce..6db72e8 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1601,7 +1601,7 @@ case SSDT: /* ACPI 3.0 upto 6.3: 2 */ return 2; case SRAT: /* ACPI 2.0: 1, ACPI 3.0: 2, ACPI 4.0 upto 6.3: 3 */ - return 1; /* TODO Should probably be upgraded to 2 */ + return 3; case DMAR: return 1; case SLIT: /* ACPI 2.0 upto 6.3: 1 */

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Paul Menzel (Code Review)

3 Jul 3 Jul

6:18 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43054/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43054/1//COMMIT_MSG@10 PS1, Line 10: Can you point to the changes in version 3, and also state what the current version in coreboot is?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Jul 2020 06:18:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:29 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43054/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43054/1//COMMIT_MSG@10 PS1, Line 10:

...

Can you point to the changes in version 3, and also state what the current version in coreboot is?

This change needs CB:43013 so I have to merge them together.

currently the revision is 1 and should be 3.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Jul 2020 09:29:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:08 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43054

to look at the new patch set (#2).

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

This adds SRAT processor local x2APIC and GICC affinity structures. Current revision is 1. Regarding ACPI v6.3 specs, SRAT revision is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 55 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/2

HAOUAS Elyes (Code Review)

1:32 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

Patch Set 3:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 03 Jul 2020 13:32:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

KOUAM Ledoux (Code Review)

8 Jul 8 Jul

1:26 p.m.

KOUAM Ledoux has uploaded a new patch set (#4) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

This adds SRAT processor local x2APIC and GICC affinity structures. Current revision is 1. Regarding ACPI v6.3 specs, SRAT revision is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 116 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/4

KOUAM Ledoux (Code Review)

1:32 p.m.

KOUAM Ledoux has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

Patch Set 4:

This adds SRAT processor local x2APIC, GICC, GIC, ITS and Generic Initiator affinity structures.Current revision is 1.Regarding ACPI v6.3 specs, SRAT revision is 3.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 08 Jul 2020 13:32:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

KOUAM Ledoux (Code Review)

1:36 p.m.

KOUAM Ledoux has uploaded a new patch set (#5) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

This adds SRAT processor local x2APIC and GICC affinity structures. Current revision is 1. Regarding ACPI v6.3 specs, SRAT revision is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 116 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

9 Jul 9 Jul

7:06 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

Patch Set 5:

(8 comments)

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@261 PS5, Line 261: u16 resv; u16 resv; /* Reserved, must be zero *

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@266 PS5, Line 266: acpi_srat_gen_init_struct maybe "acpi_srat_generic_initiator" ?

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@269 PS5, Line 269: Reserved Reserved and must be zero

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@269 PS5, Line 269: u16 u8 ?

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@269 PS5, Line 269: resv1 maybe "resv"

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@273 PS5, Line 273: /* */ /* bit 0: if clear, the OSPM ignores the contents of acpi_srat_gicc. * bit[31:1] must be 0 */

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@274 PS5, Line 274: resv2 maybe "resv1"?

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@963 PS5, Line 963: int acpi_create_srat_gen_init_struct_(acpi_srat_gen_init_struct_t acpi_create_srat_generic_initiator(acpi_srat_generic_initiator... ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Jul 2020 07:06:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:11 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43054/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43054/5//COMMIT_MSG@9 PS5, Line 9: please update you also added arch specific affinity and generic initiator

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 09 Jul 2020 07:11:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:20 a.m.

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43054

to look at the new patch set (#6).

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

This adds SRAT processor local x2APIC and GICC affinity structures. Current revision is 1. Regarding ACPI v6.3 specs, SRAT revision is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: KOUAM Ledoux kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 116 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

KOUAM Ledoux (Code Review)

10 Jul 10 Jul

11:10 p.m.

KOUAM Ledoux has uploaded a new patch set (#7) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

This adds SRAT processor local x2APIC and GICC affinity structures. Current revision is 1. Regarding ACPI v6.3 specs, SRAT revision is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: KOUAM Ledoux kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 116 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

KOUAM Ledoux (Code Review)

11:52 p.m.

KOUAM Ledoux has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

Patch Set 7:

(4 comments)

Only updated Architecture Specific Affinity Structure and Generic Initiator Affinity Structure

https://review.coreboot.org/c/coreboot/+/43054/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43054/5//COMMIT_MSG@9 PS5, Line 9:

...

please update […]

Adding of Architecture Specific Affinity Structure and Generic Initiator Affinity Structure

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@261 PS5, Line 261: u16 resv;

...

u16 resv; /* Reserved, must be zero *

Done

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@266 PS5, Line 266: acpi_srat_gen_init_struct

...

maybe "acpi_srat_generic_initiator" ?

Done

https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@273 PS5, Line 273: /* */

...

/* bit 0: if clear, the OSPM ignores the contents of acpi_srat_gicc. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 10 Jul 2020 23:52:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

KOUAM Ledoux (Code Review)

11:52 p.m.

KOUAM Ledoux has uploaded a new patch set (#8) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

This adds SRAT processor local x2APIC and GICC affinity structures. Current revision is 1. Regarding ACPI v6.3 specs, SRAT revision is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: KOUAM Ledoux kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 118 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

KOUAM Ledoux (Code Review)

11 Jul 11 Jul

12:04 a.m.

KOUAM Ledoux has uploaded a new patch set (#9) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

This adds SRAT processor local x2APIC and GICC affinity structures. Current revision is 1. Regarding ACPI v6.3 specs, SRAT revision is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: KOUAM Ledoux kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 118 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

KOUAM Ledoux (Code Review)

12:08 a.m.

KOUAM Ledoux has uploaded a new patch set (#10) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

This adds SRAT processor local x2APIC and GICC affinity structures. Current revision is 1. Regarding ACPI v6.3 specs, SRAT revision is 3. Architecture Specific Affinity Structure and Generic Initiator Affinity Structure was added

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: KOUAM Ledoux kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 118 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 10 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

KOUAM Ledoux (Code Review)

12:17 a.m.

KOUAM Ledoux has uploaded a new patch set (#11) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: KOUAM Ledoux kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 118 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

7:42 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43054/11//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43054/11//COMMIT_MSG@11 PS11, Line 11: Architecture Specific Affinity Structure and Generic Initiator Affinity Structure was added Please wrap the line after 75 characters, and add a dot/period at the end of sentences.

https://review.coreboot.org/c/coreboot/+/43054/11//COMMIT_MSG@11 PS11, Line 11: was added Please use present tense: is added.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 11 Jul 2020 07:42:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

KOUAM Ledoux (Code Review)

12 Jul 12 Jul

9:58 p.m.

KOUAM Ledoux has uploaded a new patch set (#12) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

This adds SRAT processor local x2APIC, Architecture Specific Affinity Structure and Generic Initiator Affinity Structure and GICC affinity structures. Current revision is 1. Regarding ACPI v6.3 specs, SRAT revision is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: KOUAM Ledoux kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 118 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

KOUAM Ledoux (Code Review)

10:01 p.m.

KOUAM Ledoux has uploaded a new patch set (#13) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

This adds SRAT processor local x2APIC, Architecture Specific Affinity Structure and Generic Initiator Affinity Structure and GICC affinity structures.rrent revision is 1. Regarding ACPI v6.3 specs, SRAT revision is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: KOUAM Ledoux kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 118 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/13

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 13 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

KOUAM Ledoux (Code Review)

10:02 p.m.

KOUAM Ledoux has uploaded a new patch set (#14) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: acpi: Bump SRAT revision to 3 ......................................................................

acpi: Bump SRAT revision to 3

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: KOUAM Ledoux kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 118 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 14 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

KOUAM Ledoux (Code Review)

10:14 p.m.

New subject: Change in coreboot[master]: Acpi: Bump SRAT revision to 3

KOUAM Ledoux has uploaded a new patch set (#15) to the change originally created by HAOUAS Elyes. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: Acpi: Bump SRAT revision to 3 ......................................................................

Acpi: Bump SRAT revision to 3

Adds SRAT processor local Regarding ACPI v6.3 specs, SRAT revision is 3.

Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Signed-off-by: KOUAM Ledoux kouamdoux@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 118 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43054/15

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 15 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

11 Aug 11 Aug

10:45 p.m.

New subject: Change in coreboot[master]: Acpi: Bump SRAT revision to 3

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43054 )

Change subject: Acpi: Bump SRAT revision to 3 ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/43054 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I72b9ec3b0e1be4200417c95d5540606b776e1225 Gerrit-Change-Number: 43054 Gerrit-PatchSet: 15 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: KOUAM Ledoux kouamdoux@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1594

days inactive

1633

days old

coreboot-gerrit@coreboot.org

22 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
KOUAM Ledoux (Code Review)
Paul Menzel (Code Review)